[Libreoffice-bugs] [Bug 107915] Icons for styles in the Styles menu
https://bugs.documentfoundation.org/show_bug.cgi?id=107915 Xisco Faulí changed: What|Removed |Added CC||xiscofa...@libreoffice.org --- Comment #8 from Xisco Faulí --- A polite ping to Yousuf Philips: is this bug fixed? if so, could you please close it as RESOLVED FIXED ? Thanks -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107915] Icons for styles in the Styles menu
https://bugs.documentfoundation.org/show_bug.cgi?id=107915 --- Comment #7 from Commit Notification --- Yousuf Philips committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=f9cbf67fb2cf817b6d201604eb7d4bf6182a1392 tdf#107915 More paragraph and character style aliases It will be available in 6.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107915] Icons for styles in the Styles menu
https://bugs.documentfoundation.org/show_bug.cgi?id=107915 Commit Notification changed: What|Removed |Added Whiteboard|target:5.5.0|target:5.5.0 target:6.0.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107915] Icons for styles in the Styles menu
https://bugs.documentfoundation.org/show_bug.cgi?id=107915 --- Comment #6 from Commit Notification --- Yousuf Philips committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=fe6fb37dff61f83e80076a0c9d9caf3714ed590f tdf#107915 Add paragraph and character style aliases It will be available in 5.5.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107915] Icons for styles in the Styles menu
https://bugs.documentfoundation.org/show_bug.cgi?id=107915 Commit Notification changed: What|Removed |Added Whiteboard||target:5.5.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107915] Icons for styles in the Styles menu
https://bugs.documentfoundation.org/show_bug.cgi?id=107915 --- Comment #5 from Yousuf Philips (jay) --- Initial patch is in for styles formatting toolbar. https://gerrit.libreoffice.org/38009 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107915] Icons for styles in the Styles menu
https://bugs.documentfoundation.org/show_bug.cgi?id=107915
--- Comment #4 from Maxim Monastirsky ---
(In reply to Yousuf Philips (jay) from comment #2)
> (In reply to Maxim Monastirsky from comment #1)
> > It's possible after escaping all problematic characters, see the
> > lclConvertToCanonicalName function from
> Seems very complicated and couldnt figure out the conversion. :D
Like this:
sc_styleapply%3fstyle%3astring=standard&familyname%3astring=paragraphstyles.png
Supporting spaces in lclConvertToCanonicalName is only a matter of adding there
this one line:
case ' ': aBuffer.append("%20"); bRemoveSlash = false; break;
... and replacing spaces in the image file name with %20.
> Yes it would only be for built-in styles that we place in the Styles menu,
> so this seems to be the simplest option. ;D
Agree. I would suggest that too.
(In reply to Thomas Lendo from comment #3)
> I don't follow you both. While working with an own company's style toolbar,
> I'm already assigning icons to these styles via the Add commands window in
> the Customize dialog. It's working with styles I added manually as described
> by Regina and it's also working with styles I added in 5.4/5.5 via Add
> commands.
Yes, you can assign icons manually. It just that they won't pick icons
automatically, once we assign them for internal use (e.g. for the Styles menu).
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107915] Icons for styles in the Styles menu
https://bugs.documentfoundation.org/show_bug.cgi?id=107915 --- Comment #3 from Thomas Lendo --- (In reply to Yousuf Philips (jay) from comment #2) > (In reply to Maxim Monastirsky from comment #1) > > Yes, that should work too. But keep in mind that it won't work with styles > > that user might add via the Add Commands dialog. But if this isn't a > > problem, then it's a good solution too. > Yes it would only be for built-in styles that we place in the Styles menu, > so this seems to be the simplest option. ;D I don't follow you both. While working with an own company's style toolbar, I'm already assigning icons to these styles via the Add commands window in the Customize dialog. It's working with styles I added manually as described by Regina and it's also working with styles I added in 5.4/5.5 via Add commands. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107915] Icons for styles in the Styles menu
https://bugs.documentfoundation.org/show_bug.cgi?id=107915 Yousuf Philips (jay) changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #2 from Yousuf Philips (jay) --- (In reply to Maxim Monastirsky from comment #1) > It's possible after escaping all problematic characters, see the > lclConvertToCanonicalName function from > http://opengrok.libreoffice.org/xref/core/framework/source/uiconfiguration/ > CommandImageResolver.cxx#lclConvertToCanonicalName > > There is however one problem if you're going to use links.txt with a command > that has a space (e.g. for "Heading 1"), as the links.txt parser assumes > that a space separates a link from the original image. But this can be > easily solved by adding a space escaping into lclConvertToCanonicalName. Seems very complicated and couldnt figure out the conversion. :D > Yes, that should work too. But keep in mind that it won't work with styles > that user might add via the Add Commands dialog. But if this isn't a > problem, then it's a good solution too. Yes it would only be for built-in styles that we place in the Styles menu, so this seems to be the simplest option. ;D -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107915] Icons for styles in the Styles menu
https://bugs.documentfoundation.org/show_bug.cgi?id=107915 --- Comment #1 from Maxim Monastirsky --- (In reply to Yousuf Philips (jay) from comment #0) > @Maxim: With styles in the Style menu using UNO commands like > .uno:StyleApply?Style:string=Standard&FamilyName:string=ParagraphStyles, > is it possible to assign icons to them and if so, how would it be named It's possible after escaping all problematic characters, see the lclConvertToCanonicalName function from http://opengrok.libreoffice.org/xref/core/framework/source/uiconfiguration/CommandImageResolver.cxx#lclConvertToCanonicalName There is however one problem if you're going to use links.txt with a command that has a space (e.g. for "Heading 1"), as the links.txt parser assumes that a space separates a link from the original image. But this can be easily solved by adding a space escaping into lclConvertToCanonicalName. > Was thinking that the work around would be to make alias commands for each > of the styles and then it is easy to assign icons to those. Yes, that should work too. But keep in mind that it won't work with styles that user might add via the Add Commands dialog. But if this isn't a problem, then it's a good solution too. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
