[Libreoffice-bugs] [Bug 108919] Assertion failed when inserting rectangle shape in spreadsheet

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108919

Stephan Bergmann  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
   Assignee|libreoffice-b...@lists.free |sberg...@redhat.com
   |desktop.org |

--- Comment #7 from Stephan Bergmann  ---
(In reply to Oliver Specht (CIB) from comment #5)
> It should have been 
> pObj->SetMergedItem( SvxAdjustItem( SVX_ADJUST_CENTER, EE_PARA_JUST ) );

Thanks, fixed that now, see comment 6.

Oliver, any thoughts on "whether SfxItemSet instances containing WID=0 should
be allowed" (i.e., whether

"Make SfxItemSet ranges correct by construction" should be changed so that e.g.

  SfxItemSet(pool, {{0, 0}})

would generally be allowed)?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108919] Assertion failed when inserting rectangle shape in spreadsheet

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108919

--- Comment #6 from Commit Notification 
 ---
Stephan Bergmann committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=ec1de6895d84fbe4f2d5fb7135a59a918138d970

tdf#108919: Fix WID, should be EE_PARA_JUST instead of 0

It will be available in 6.0.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108919] Assertion failed when inserting rectangle shape in spreadsheet

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108919

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.0.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108919] Assertion failed when inserting rectangle shape in spreadsheet

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108919

--- Comment #5 from Oliver Specht (CIB)  ---
(In reply to Stephan Bergmann from comment #4)
> 
> It is still unclear to me whether SfxItemSet instances containing WID=0
> should e allowed, or whether the change in
> sc/source/ui/drawfunc/fuconcustomshape.cxx (done by Oliver) was wrong. 
> Oliver, any thoughts?
It should have been 
pObj->SetMergedItem( SvxAdjustItem( SVX_ADJUST_CENTER, EE_PARA_JUST ) );

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108919] Assertion failed when inserting rectangle shape in spreadsheet

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108919

Stephan Bergmann  changed:

   What|Removed |Added

 CC||oliver.spe...@cib.de

--- Comment #4 from Stephan Bergmann  ---
That's interesting.  When doing

"Make SfxItemSet ranges correct by construction" I naively assumed that an
SfxItemSet's ranges would never include a WID=0, and that therefore the
constructor with a single range,

> SfxItemSet( SfxItemPool&, sal_uInt16 nWhich1, sal_uInt16 nWhich2 );

should never be called with nWhich1=0 (just as for the multi-range constructor

> SfxItemSet( SfxItemPool&, int nWh1, int nWh2, int nNull, ... );

an argument of 0 signals end-of-ranges).

However, ever since

"INTEGRATION: CWS pchfix04", FuConstCustomShape::SetAttributes
(sc/source/ui/drawfunc/fuconcustomshape.cxx) creates an SvxAdjustItem with
WID=0, which is then passed into the SfxItemSet constructor as seen in the
backtrace in attachment 134466.

The other changes from that CWS pchfix04 (see "git log --patch --grep='#i73604#
 eeitemid.hxx removed'" and "git log --patch --grep='#i73604# usage of
ITEMID_\* removed'") create SvxAdjustItem instances with RES_PARATR_ADJUST or
EE_PARA_JUST, it appears to be just this one exception with an explicit WID=0.

It is still unclear to me whether SfxItemSet instances containing WID=0 should
e allowed, or whether the change in sc/source/ui/drawfunc/fuconcustomshape.cxx
(done by Oliver) was wrong.  Oliver, any thoughts?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108919] Assertion failed when inserting rectangle shape in spreadsheet

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108919

--- Comment #3 from Julien Nabet  ---
Created attachment 134466
  --> https://bugs.documentfoundation.org/attachment.cgi?id=134466&action=edit
bt with debug symbols (gtk3)

On pc Debian x86-64 with master sources updated yesterday, I could reproduce
this.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108919] Assertion failed when inserting rectangle shape in spreadsheet

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108919

Julien Nabet  changed:

   What|Removed |Added

   Keywords||haveBacktrace

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108919] Assertion failed when inserting rectangle shape in spreadsheet

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108919

Aron Budea  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #2 from Aron Budea  ---
I assume that counts as confirmation, thanks Julien!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108919] Assertion failed when inserting rectangle shape in spreadsheet

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108919

Julien Nabet  changed:

   What|Removed |Added

 CC||sberg...@redhat.com,
   ||serval2...@yahoo.fr

--- Comment #1 from Julien Nabet  ---
"Regression" from
https://cgit.freedesktop.org/libreoffice/core/commit/?id=13bb5a4b09f5b2ad19dad1b55f45d0fe2b2fb908
I put quotes because perhaps it revealed a real bug.

Stephan: thought you might be interested in this one.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs