[Libreoffice-bugs] [Bug 109062] Scrolling with touchpad or scrollwheel is not working on Mac

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109062

Caolán McNamara  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
   Assignee|libreoffice-b...@lists.free |caol...@redhat.com
   |desktop.org |

--- Comment #36 from Caolán McNamara  ---
re "wider problem", I don't think so.

backports to earlier versions in gerrit now

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109062] Scrolling with touchpad or scrollwheel is not working on Mac

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109062

--- Comment #35 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=bf92a5af6cb2928578bade9d367738d7e0f283e7

tdf#109062 restore osx scrollwheel logic

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109062] Scrolling with touchpad or scrollwheel is not working on Mac

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109062

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.1.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109062] Scrolling with touchpad or scrollwheel is not working on Mac

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109062

--- Comment #34 from Telesto  ---
(In reply to Caolán McNamara from comment #33)
> aha, excellent stuff Telesto, the old situation would have truncated some
> 0.X cases to 0, which would then have been detected as 0 and the = 1 would
> happen. Seeing as you appear to be in a position to compile it yourself to
> test it, does https://gerrit.libreoffice.org/#/c/48249/ solve the problem ?

Working like a charm! Thanks Caolán! 

Side note: could this be a wider problem? My initial solution for bug 92190 was
defining the paper-size into millimeters instead of inches. Weird, but working.
(Ignore the 0.5 part)

See comment: https://bugs.documentfoundation.org/show_bug.cgi?id=92190#c76

and response of Tor Lillqvist
https://bugs.documentfoundation.org/show_bug.cgi?id=92190#c82

I came up with a different 'solution', but there might be a problem underneath.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109062] Scrolling with touchpad or scrollwheel is not working on Mac

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109062

--- Comment #33 from Caolán McNamara  ---
aha, excellent stuff Telesto, the old situation would have truncated some 0.X
cases to 0, which would then have been detected as 0 and the = 1 would happen.
Seeing as you appear to be in a position to compile it yourself to test it,
does https://gerrit.libreoffice.org/#/c/48249/ solve the problem ?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109062] Scrolling with touchpad or scrollwheel is not working on Mac

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109062

--- Comment #32 from Telesto  ---
Created attachment 139219
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139219=edit
Patch proposal

@Caolán
I might found a clue (or a solution). Changing "fabs" to std:abs has the
desired effect. For example here:
https://opengrok.libreoffice.org/xref/core/vcl/osx/salframeview.mm#941

See also: https://forums.developer.apple.com/thread/90710

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109062] Scrolling with touchpad or scrollwheel is not working on Mac

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109062

--- Comment #31 from Telesto  ---
(In reply to Caolán McNamara from comment #30)
> You're absolutely sure that before f7d2bf216afa10268e6a7c1d4613a2fd8f7c7f3c
> it works and right after f7d2bf216afa10268e6a7c1d4613a2fd8f7c7f3c it doesn't
> ?

The summary is misleading. Comment 7 has a proper description.  
* "Scrolling up or left works normally. Attempting to scroll down or right
slowly or by a single cell produces no movement at all. Attempting a faster
scroll down or right works but is not controllable, so there is no way to
scroll in these directions and control the amount of scroll." [Comment 7]

* The same issue seems to occur in other dialogs. For example when scrolling
through the list in Tools -> Customize

* The is no problem scrolling in text documents. 

It should be the identified commit...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109062] Scrolling with touchpad or scrollwheel is not working on Mac

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109062

--- Comment #30 from Caolán McNamara  ---
You're absolutely sure that before f7d2bf216afa10268e6a7c1d4613a2fd8f7c7f3c it
works and right after f7d2bf216afa10268e6a7c1d4613a2fd8f7c7f3c it doesn't ?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109062] Scrolling with touchpad or scrollwheel is not working on Mac

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109062

--- Comment #28 from Telesto  ---
Manual bisected to 
author  Caolán McNamara 2017-05-16 10:12:09 +0100
committer   Miklos Vajna   2017-05-24 10:36:16
+0200
commit  f7d2bf216afa10268e6a7c1d4613a2fd8f7c7f3c (patch)
treea7a36402f4d630b4bc9006ba153018a4bf2fa2d9
parent  c05f35f4f56a1e65b92f4b1bc43b0fa6138d209c (diff)
Resolves: tdf#103174 & rhbz#1367846 improve gtk3 trackpad scrolling
convert number of "lines" scrolled to double and allow
fractional parts of lines/columns

Repro with
Version: 5.3.4.0.0+
Build ID: 1a14a0404ef02a76cfc3b6bfd50b1c78bb150d45
CPU Threads: 4; OS Version: Mac OS X 10.13.1; UI Render: default; Layout
Engine: new; 
Locale: nl-NL (nl_US.UTF-8); Calc: group

No repro with
Version: 5.3.4.0.0+
Build ID: c05f35f4f56a1e65b92f4b1bc43b0fa6138d209c
CPU Threads: 4; OS Version: Mac OS X 10.13.1; UI Render: default; Layout
Engine: new; 
Locale: nl-NL (nl_US.UTF-8); Calc: group

https://opengrok.libreoffice.org/xref/core/vcl/osx/salframeview.mm#833

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109062] Scrolling with touchpad or scrollwheel is not working on Mac

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109062

Telesto  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bisected
 CC||caol...@redhat.com

--- Comment #29 from Telesto  ---
Adding CC to Caolán McNamara

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109062] Scrolling with touchpad or scrollwheel is not working on Mac

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109062

--- Comment #27 from Telesto  ---
Same issue seems to occur in other dialogs. For example when scrolling through
the list in Tools -> Customize

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109062] Scrolling with touchpad or scrollwheel is not working on Mac

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109062

Telesto  changed:

   What|Removed |Added

 CC||lenorehor...@sbcglobal.net

--- Comment #26 from Telesto  ---
*** Bug 114579 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109062] Scrolling with touchpad or scrollwheel is not working on Mac

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109062

--- Comment #25 from Telesto  ---
I'm able to repro this one. Same specs as comment 7. A likely candidate - based
on comment 8 - would be the commit for bug 103158, in my opinion.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109062] Scrolling with touchpad or scrollwheel is not working on Mac

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109062

--- Comment #24 from Telesto  ---
@Carsten
(In reply to Carsten from comment #23)
> Independent from this erratic behavior, the scrolling performance on the
> MacBook Pro is very poor unless I switch the color profile to the standard
> RGB profile. It doesn't reach the performance of the 6 years-older MacBook
> Air, where I can't detect an impact of the color profile to the scrolling
> performance at all.

Interesting. Please open a new bug report for this one. Thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109062] Scrolling with touchpad or scrollwheel is not working on Mac

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109062

--- Comment #23 from Carsten  ---
I can reproduce the erratic scrolling behavior on two MacBooks.

MacBook Air, Mid 2011, High Sierra 10.13.1
MacBook Pro, 2017, High Sierra 10.13.1

On both machines, scrolling works fine up to version 5.3.3.2, the erratic
behavior starts with version 5.3.4.1.

The symptoms are as described before: scrolling towards higher rows (down) and
columns (right) is not working reliable, sometimes it takes 3
two-finger-touches to start scrolling with the touchpad. Calc is not usable
with that behavior.

Independent from this erratic behavior, the scrolling performance on the
MacBook Pro is very poor unless I switch the color profile to the standard RGB
profile. It doesn't reach the performance of the 6 years-older MacBook Air,
where I can't detect an impact of the color profile to the scrolling
performance at all.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109062] Scrolling with touchpad or scrollwheel is not working on Mac

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109062

Buovjaga  changed:

   What|Removed |Added

Summary|Two-finger scroll with  |Scrolling with touchpad or
   |touchpad is not working on  |scrollwheel is not working
   |Mac |on Mac

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs