[Libreoffice-bugs] [Bug 112423] MySQL native connector "Commands out of sync..." when calling procedure second time. - Crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112423

Lionel Elie Mamane  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |lio...@mamane.lu
   |desktop.org |
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112423] MySQL native connector "Commands out of sync..." when calling procedure second time. - Crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112423

--- Comment #31 from Julien Nabet  ---
(In reply to Julien Nabet from comment #30)
> I gave a try with https://gerrit.libreoffice.org/c/core/+/93686
> 
> I just used
> https://dev.mysql.com/doc/refman/8.0/en/c-api-multiple-queries.html but
> don't know if it's the right thing to do.

Just for information, the patch was wrong, I abandoned it.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112423] MySQL native connector "Commands out of sync..." when calling procedure second time. - Crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112423

--- Comment #30 from Julien Nabet  ---
I gave a try with https://gerrit.libreoffice.org/c/core/+/93686

I just used https://dev.mysql.com/doc/refman/8.0/en/c-api-multiple-queries.html
but don't know if it's the right thing to do.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112423] MySQL native connector "Commands out of sync..." when calling procedure second time. - Crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112423

Julien Nabet  changed:

   What|Removed |Added

 Status|REOPENED|NEW
 Whiteboard|target:6.0.0 target:5.4.3   |

--- Comment #29 from Julien Nabet  ---
On pc Debian x86-64 with master sources updated today, I could reproduce this.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112423] MySQL native connector "Commands out of sync..." when calling procedure second time. - Crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112423

--- Comment #28 from Alex Thurgood  ---
Thanks Robert, lets keep it open then.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112423] MySQL native connector "Commands out of sync..." when calling procedure second time. - Crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112423

--- Comment #27 from Robert Großkopf  ---
(In reply to Alex Thurgood from comment #26)
> 
> @Robert : can we close this now as fixed ?

Have tested it again with the original description and LO 6.3.3.2 on OpenSUSE
15.1 64bit rpm Linux.
The behavior is the same: 
fist
CALL `AllNames`;
shows output
"-1 rows updated"
second
CALL `AllNames`;
doesn't give a result, shows status
"Commands out of sync; you can't run this command now"

If I try the same with PHPMyAdmin I get the resulte of the procedure, in this
part the result of 
SELECT * FROM `NamesTest`;

So the bug is still there with the MySQL native connector.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112423] MySQL native connector "Commands out of sync..." when calling procedure second time. - Crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112423

--- Comment #26 from Alex Thurgood  ---
(In reply to Julien Nabet from comment #25)
> (In reply to robert from comment #24)

> > ...
> > please have a look at comment14. I will see if I could test it again
> > tomorrow.



@Robert : can we close this now as fixed ?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112423] MySQL native connector "Commands out of sync..." when calling procedure second time. - Crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112423

Xisco Faulí  changed:

   What|Removed |Added

 Blocks|119196  |104790


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=104790
[Bug 104790] [META] Database connectivity interfaces (ODBC, JDBC..) and
external databases
https://bugs.documentfoundation.org/show_bug.cgi?id=119196
[Bug 119196] [META] MySQL related bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112423] MySQL native connector "Commands out of sync..." when calling procedure second time. - Crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112423

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org
 Blocks||119196


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=119196
[Bug 119196] [META] MySQL related bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112423] MySQL native connector "Commands out of sync..." when calling procedure second time. - Crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112423

--- Comment #25 from Julien Nabet  ---
(In reply to robert from comment #24)
> ...
> please have a look at comment14. I will see if I could test it again
> tomorrow.
Thank you for your quick feedback, I thought it was related to patch applied to
extension or direct LO.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112423] MySQL native connector "Commands out of sync..." when calling procedure second time. - Crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112423

--- Comment #24 from rob...@familiegrosskopf.de ---
(In reply to Julien Nabet from comment #23)
> Robert: why did you reopen the tracker?

Hi Julien,

please have a look at comment14. I will see if I could test it again tomorrow.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112423] MySQL native connector "Commands out of sync..." when calling procedure second time. - Crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112423

--- Comment #23 from Julien Nabet  ---
Robert: why did you reopen the tracker?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112423] MySQL native connector "Commands out of sync..." when calling procedure second time. - Crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112423

--- Comment #22 from Lionel Elie Mamane  ---
(In reply to Julien Nabet from comment #21)
> Lionel: just an hypothesis, since Robert uses the old extension perhaps this
> part doesn't work for him:

Yes, that seems probable.

> --- a/mysqlc/source/mysqlc_statement.cxx
> +++ b/mysqlc/source/mysqlc_statement.cxx

> Of course, these methods are called from a try/catch but are the catches
> sufficient to deal with the lack of one (or both) of these methods in the
> extension?

No, the try/catch deals with exceptions but here no exception is thrown by the
buggy version.

The bug really was that the MySQL extension was _lying_. It said "yes, I
support multiple results from one query (interface XMultipleResults)", but then
it returned garbage data when one tried to use it. It should have either
cleanly _not_ proposed the XMultipleResults interface *or* implement it
correctly (which was very easy since MySQL Connector C++ implements it... maybe
it didn't at the time this code was written. ).

The garbage data comes from a misunderstanding of the XMultipleResults
interface. The person that wrote that probably thought that:

 - getMoreResults() returning false means "no next result available".
   That is wrong. It means "there is a next result, and the next result
   is an update count, not a resultset". A resultset = a sequence of rows of
   columns (like what a SELECT query returns).
 - getUpdateCount() returning zero is ... I don't know what he/she though.
   It means "the current result is an update count, and that count is zero,
   i.e. the UPDATE/DELETE/... changed zero rows, but otherwise was successfully
   executed". For a "shim" implementation it should have returned "-1", which
   means "the current result is not an update count.

So essentially, the old MySQL extension was causing an infinite loop in any
caller that expected a correct XMultipleResults, since it was always saying
"there is a next result giving an update count" and giving a valid value (zero)
for the update count. While if it getMoreResults() returns false getUpdateCount
returns -1, that is the signal for "there is no further result".

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112423] MySQL native connector "Commands out of sync..." when calling procedure second time. - Crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112423

--- Comment #21 from Julien Nabet  ---
Lionel: just an hypothesis, since Robert uses the old extension perhaps this
part doesn't work for him:
--- a/mysqlc/source/mysqlc_statement.cxx
+++ b/mysqlc/source/mysqlc_statement.cxx
@@ -175,7 +175,7 @@ Reference< XConnection > SAL_CALL
OCommonStatement::getConnection()

 sal_Int32 SAL_CALL OCommonStatement::getUpdateCount()
 {
-return 0;
+return cppStatement->getUpdateCount();
 }

 Any SAL_CALL OStatement::queryInterface(const Type & rType)
@@ -238,9 +238,7 @@ sal_Bool SAL_CALL OCommonStatement::getMoreResults()
 MutexGuard aGuard(m_aMutex);
 checkDisposed(rBHelper.bDisposed);

-// if your driver supports more than only one resultset
-// and has one more at this moment return true
-return false;
+return cppStatement->getMoreResults();
 }

Of course, these methods are called from a try/catch but are the catches
sufficient to deal with the lack of one (or both) of these methods in the
extension?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112423] MySQL native connector "Commands out of sync..." when calling procedure second time. - Crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112423

--- Comment #20 from Alex Thurgood  ---
I am using the mysql native connector extension which I built at the same time
as my master build.

For me, Julien's commits have fixed the problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112423] MySQL native connector "Commands out of sync..." when calling procedure second time. - Crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112423

--- Comment #19 from Alex Thurgood  ---
Confirming that this is fixed for me (as is the COMMAND OUT OF SYNC) problem
with:


Version: 6.0.0.0.alpha0+
Build ID: 80d135922d5a5d0fd0d7178935653870cecf58ea
CPU threads: 4; OS: Mac OS X 10.12.6; UI render: default; 
Locale: fr-FR (fr_FR.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112423] MySQL native connector "Commands out of sync..." when calling procedure second time. - Crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112423

--- Comment #18 from Julien Nabet  ---
Lionel: some details about the fix for the crash
Let's start from frame of the bt of this tdf:
frame #3: 0x00018521c305
libdbulo.dylib`dbaui::SbaTableQueryBrowser::implSelect(this=,
_rDataSourceName=0x7fff5fbfde48, _rCommand=, _nCommandType=0,
_bEscapeProcessing=, _rxConnection=0x7fff5fbfde00,
_bSelectDirect=) at unodatbr.cxx:2458


2442  SvTreeListEntry* pCommand = getObjectEntry( _rDataSourceName,
_rCommand, _nCommandType, , , true, _rxConnection );
2443  
2444  if (pCommand)
2445  {
2446  bool bSuccess = true;
2447  if ( _bSelectDirect )
2448  {
2449  bSuccess = implSelect( pCommand );
2450  }
2451  else
2452  {
2453  m_pTreeView->getListBox().Select( pCommand );
2454  }
2455  
2456  if ( bSuccess )
2457  {
2458  m_pTreeView->getListBox().MakeVisible(pCommand);
2459  m_pTreeView->getListBox().SetCursor(pCommand);
(see
https://opengrok.libreoffice.org/xref/core/dbaccess/source/ui/browser/unodatbr.cxx#2442)


The pb of the crash was pCommand retrieved by getObjectEntry was not ok.
So the result was we entered in a catch in the method implSelect (line 2449)
but the catch didn't set the return to false.
So LO went to line 2458 to execute MakeVisible and since this method needs a
correct entry (so a correct pCommand), it crashed.

Unwinding to the getObjectEntry, I wanted to call ensureEntryObject before the
if:
1200  pObject =
m_pTreeView->getListBox().GetEntryPosByName(sPath, pCommandType);
1201  pCommandType = pObject;
1202  if ( nIndex >= 0 )
1203  {
1204  if (ensureEntryObject(pObject))
1205  {
(see
https://opengrok.libreoffice.org/xref/core/dbaccess/source/ui/browser/unodatbr.cxx#1200)
since nIndex = -1 at this moment. Indeed we would have returned nullptr instead
of an incorrect object. But then, even if there was no crash when opening the
table, I hadn't the popup error "Commands out of sync; you can't run command
now". So the cause of the empty table was unknown.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112423] MySQL native connector "Commands out of sync..." when calling procedure second time. - Crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112423

--- Comment #17 from Lionel Elie Mamane  ---
The "Commands out of sync; you can't run this command now" message has been
fixed as bug 83995; there were changes both in LibreOffice itself and in the
MySQL extension. According to Julien, this also works around the crash (by not
putting MySQL in a situation where it gives that error).

For the crash part (that is, when MySQL gives that kind of error, LibreOffice
crashes):
1) The "place of crash" from Alex doesn't make sense to me...
2) According to Julien, his patch (in LibreOffice itself, not the extension)
   fixes that crash. I didn't test that, but his patch looked very reasonable.
   (How it led to a crash is unclear to me.)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112423] MySQL native connector "Commands out of sync..." when calling procedure second time. - Crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112423

--- Comment #16 from rob...@familiegrosskopf.de ---
(In reply to Julien Nabet from comment #15)
> I started from scratch (removed the table, the procedure then execute the
> steps), I don't reproduce this with master sources updated today :-(
> When you say "run the following commands, each separately:", must I close
> Tools/sql direct after each command?

Hi Julien,

did you fix this bug in LO directly or did you fix the extension? I have
installed the old extension, because I don't know where to get a new one.

I have only called the procedure I have created before I reported this bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112423] MySQL native connector "Commands out of sync..." when calling procedure second time. - Crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112423

--- Comment #15 from Julien Nabet  ---
I started from scratch (removed the table, the procedure then execute the
steps), I don't reproduce this with master sources updated today :-(
When you say "run the following commands, each separately:", must I close
Tools/sql direct after each command?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112423] MySQL native connector "Commands out of sync..." when calling procedure second time. - Crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112423

rob...@familiegrosskopf.de changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

--- Comment #14 from rob...@familiegrosskopf.de ---
I have tested with 
Version: 6.0.0.0.alpha0+
Build ID: 40892cd3311021c55e943228e16bfd36df7b1011
CPU threads: 4; OS: Linux 4.4; UI render: default; VCL: kde4; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time:
2017-09-25_01:20:06
Locale: de-DE (de_DE.UTF-8); Calc: group

Opened Tools > SQL
Run 
CALL `AllNames`;

Execute is pressed and then LO hangs.

Same with
CALL `AllNames`();

Procedure is running well with PHPMyAdmin and shows the result.

So I couldn't test the old bug, because the the command couldn't be executed
any more. I will reopen the bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112423] MySQL native connector "Commands out of sync..." when calling procedure second time. - Crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112423

Julien Nabet  changed:

   What|Removed |Added

 CC||ipla...@tuta.io

--- Comment #13 from Julien Nabet  ---
*** Bug 83995 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112423] MySQL native connector "Commands out of sync..." when calling procedure second time. - Crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112423

Julien Nabet  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #12 from Julien Nabet  ---
Let's consider this one for crash only and so put this one to FIXED.
The related one has been fixed on master and waits for review on 5.4

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112423] MySQL native connector "Commands out of sync..." when calling procedure second time. - Crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112423

--- Comment #11 from Commit Notification 
 ---
Julien Nabet committed a patch related to this issue.
It has been pushed to "libreoffice-5-4":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=52230cb62d2784a5e5eae6f9982a7d1b2d8e43e9=libreoffice-5-4

Related tdf#112423: avoid crash when calling procedure twice (dbaccess)

It will be available in 5.4.3.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112423] MySQL native connector "Commands out of sync..." when calling procedure second time. - Crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112423

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:6.0.0|target:6.0.0 target:5.4.3

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112423] MySQL native connector "Commands out of sync..." when calling procedure second time. - Crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112423

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.0.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112423] MySQL native connector "Commands out of sync..." when calling procedure second time. - Crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112423

--- Comment #10 from Commit Notification 
 ---
Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=0297d9cc3b3fb990956cc2f8021a645d3c4fb86f

Related tdf#112423: avoid crash when calling procedure twice (dbaccess)

It will be available in 6.0.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112423] MySQL native connector "Commands out of sync..." when calling procedure second time. - Crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112423

--- Comment #9 from Julien Nabet  ---
Lionel, as you may have seen, I submitted
https://gerrit.libreoffice.org/#/c/42564/ for review.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112423] MySQL native connector "Commands out of sync..." when calling procedure second time. - Crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112423

--- Comment #8 from Julien Nabet  ---
So 2 problems to fix:
1) the crash
2) the call to execute
Of course, fixing 2) should prevent from getting 1) but in any case, 1)
shouldn't happen.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112423] MySQL native connector "Commands out of sync..." when calling procedure second time. - Crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112423

--- Comment #7 from Julien Nabet  ---
Lionel: testing again calls to callstatements, it seems indeed more than 1 rs
triggers pb.
Indeed, it fails here:
mariadb-connector-c/libmariadb/libmariadb.c
557   if (mysql->status != MYSQL_STATUS_READY ||
558   mysql->server_status & SERVER_MORE_RESULTS_EXIST)
559   {
560 SET_CLIENT_ERROR(mysql, CR_COMMANDS_OUT_OF_SYNC, unknown_sqlstate,
0);
561 goto end;
562   }
mysql->status is equal to MYSQL_STATUS_READY but I encountered the second
condition.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112423] MySQL native connector "Commands out of sync..." when calling procedure second time. - Crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112423

--- Comment #6 from Alex Thurgood  ---
Me too, it was irrelevant whether that box was ticked or not, the result was
the same message and then crash when attempting to open a table.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112423] MySQL native connector "Commands out of sync..." when calling procedure second time. - Crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112423

--- Comment #5 from Julien Nabet  ---
(In reply to Lionel Elie Mamane from comment #4)
> Is the "show result of SELECT statements" checkbox checked?

I got the same pb when checking this checkbox or not.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112423] MySQL native connector "Commands out of sync..." when calling procedure second time. - Crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112423

--- Comment #4 from Lionel Elie Mamane  ---
Is the "show result of SELECT statements" checkbox checked?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112423] MySQL native connector "Commands out of sync..." when calling procedure second time. - Crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112423

Alex Thurgood  changed:

   What|Removed |Added

   Keywords||haveBacktrace

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112423] MySQL native connector "Commands out of sync..." when calling procedure second time. - Crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112423

--- Comment #3 from Alex Thurgood  ---
Created attachment 136330
  --> https://bugs.documentfoundation.org/attachment.cgi?id=136330=edit
Backtrace from lldb debug session

Enclosed backtrace from lldb debug session

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112423] MySQL native connector "Commands out of sync..." when calling procedure second time. - Crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112423

Alex Thurgood  changed:

   What|Removed |Added

   Priority|medium  |high
   Severity|normal  |major

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112423] MySQL native connector "Commands out of sync..." when calling procedure second time. - Crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112423

--- Comment #2 from Alex Thurgood  ---
The crash occurs here :

Process 93714 launched:
'/Users/Shared/LO/core/instdir/LibreOfficeDev.app/Contents/MacOS/soffice'
(x86_64)
Process 93714 stopped
* thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS
(code=EXC_I386_GPFLT)
frame #0: 0x000103ca1206
libsvtlo.dylib`SvTreeListEntry::HasChildrenOnDemand(this=0x11105618)
const at treelistentry.cxx:216
   213  
   214  bool SvTreeListEntry::HasChildrenOnDemand() const
   215  {
-> 216  return (bool)(nEntryFlags & SvTLEntryFlags::CHILDREN_ON_DEMAND);
   217  }
   218  
   219  bool SvTreeListEntry::HasInUseEmphasis() const

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112423] MySQL native connector "Commands out of sync..." when calling procedure second time. - Crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112423

Alex Thurgood  changed:

   What|Removed |Added

 OS|Linux (All) |All

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112423] MySQL native connector "Commands out of sync..." when calling procedure second time. - Crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112423

Alex Thurgood  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #1 from Alex Thurgood  ---
Confirming with 

Version: 6.0.0.0.alpha0+
Build ID: ab65fe804cf3a97bd172b5551b553b9bcde6d756
CPU threads: 4; OS: Mac OS X 10.12.6; UI render: default; 
Locale: fr-FR (fr_FR.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112423] MySQL native connector "Commands out of sync..." when calling procedure second time. - Crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112423

rob...@familiegrosskopf.de changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||3685

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs