[Libreoffice-bugs] [Bug 112519] FILESAVE: RTF: Shape changes position after RT

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112519

Aron Budea  changed:

   What|Removed |Added

   Keywords|bibisected  |notBibisectable
 CC||ba...@caesar.elte.hu
Version|4.1 all versions|3.6.0.4 release

--- Comment #12 from Aron Budea  ---
(In reply to Xisco Faulí from comment #8)
> Regression introduced in range
> https://cgit.freedesktop.org/libreoffice/core/log/
> ?qt=range=43c7830b03d141ae11d8617c0fdabefa32dd243c..
> ce97851773a06103504972eb2771eecd7dd81e36=50
The range covers two months, from 2011-12-13 to 2013-02-06, keyword
notBibisectable seems more appropriate.

Bug still in LO 7.0.0.0.alpha0+ (aa191f35978ea48bbacc0e613ae8f0e6536ebcfc).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112519] FILESAVE: RTF: Shape changes position after RT

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112519

--- Comment #11 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112519] FILESAVE: RTF: Shape changes position after RT

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112519

Thomas Lendo  changed:

   What|Removed |Added

 Blocks||113403


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=113403
[Bug 113403] [META] RTF (text) shape-related issues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112519] FILESAVE: RTF: Shape changes position after RT

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112519

--- Comment #10 from Miklos Vajna  ---
Commandline does not wait for idle jobs (layout, word count, etc), while
typically by the time you manage to get to File -> Save as, they are completed.
That might be a difference. At least for the layout, the Word export filters
explicitly calc the layout for a long time; the ODT export started to do that
just recently.

So such behavior difference can happen, but the intention is that these
differences are eliminated.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112519] FILESAVE: RTF: Shape changes position after RT

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112519

Xisco Faulí  changed:

   What|Removed |Added

 CC||vmik...@collabora.co.uk

--- Comment #9 from Xisco Faulí  ---
(In reply to Xisco Faulí from comment #8)
> Regression introduced in range
> https://cgit.freedesktop.org/libreoffice/core/log/
> ?qt=range=43c7830b03d141ae11d8617c0fdabefa32dd243c..
> ce97851773a06103504972eb2771eecd7dd81e36=50

ahhh, this is weird, the behaviour is different when using the --convert-to
from command line or when doing it from the UI. The issue in Tamás' attachment
is not reproduced using the command line if
83fbebfea32b27cd722466607aa978244ac53575 is reverted, but not from the UI.

@Miklos, could you please shed some light on this issue?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112519] FILESAVE: RTF: Shape changes position after RT

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112519

Xisco Faulí  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bibisected

--- Comment #8 from Xisco Faulí  ---
Regression introduced in range
https://cgit.freedesktop.org/libreoffice/core/log/?qt=range=43c7830b03d141ae11d8617c0fdabefa32dd243c..ce97851773a06103504972eb2771eecd7dd81e36=50

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112519] FILESAVE: RTF: Shape changes position after RT

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112519

Xisco Faulí  changed:

   What|Removed |Added

   Keywords|bibisected, bisected|bibisectRequest
Version|6.0.0.0.alpha0+ Master  |4.1 all versions

--- Comment #7 from Xisco Faulí  ---
it seems to be an old regression.

The blue rectangle is shifted to the top on

Version 4.1.0.0.alpha0+ (Build ID: 8669ad398a2971706ce22b6e5fe316991977452)

but not in

LibreOffice 3.5.0 
Build ID: d6cde02

Updating the info. Thanks for taking a look at it

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112519] FILESAVE: RTF: Shape changes position after RT

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112519

--- Comment #6 from Tamás Zolnai  ---
Hi Xisco,

Can you check with the attached ODT whether there is a regression in RTF export
causing this issue. It might be easier to find out a solution.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112519] FILESAVE: RTF: Shape changes position after RT

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112519

--- Comment #5 from Tamás Zolnai  ---
Created attachment 136399
  --> https://bugs.documentfoundation.org/attachment.cgi?id=136399=edit
Shape anchored as character with top vertical positioning

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112519] FILESAVE: RTF: Shape changes position after RT

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112519

--- Comment #4 from Tamás Zolnai  ---
I checked what the issue here. The behavior change is caused by the code change
in oox/source/vml/vmlshape.cxx file. I changed the inline shapes import (DOCX)
to have top vertical position instead of the default one, because this kind of
alignment is closer to MSO inline alignment behavior.
The issue is that RTF export seem to not handle top vertical positioning of
shapes anchored as character. I'll attach an ODS test document showing the same
issue.
So the root of the problem is not in the code change I added (DOCX import), but
in RTF export which is untoched by the referenced commit.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112519] FILESAVE: RTF: Shape changes position after RT

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112519

--- Comment #3 from Xisco Faulí  ---
Same behaviour with attachment 69953 from bug 56950

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112519] FILESAVE: RTF: Shape changes position after RT

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112519

Xisco Faulí  changed:

   What|Removed |Added

   Keywords||filter:rtf

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112519] FILESAVE: RTF: Shape changes position after RT

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112519

Xisco Faulí  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||2520

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112519] FILESAVE: RTF: Shape changes position after RT

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112519

--- Comment #2 from Xisco Faulí  ---
--->> attachment 91407 from bug 73215

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112519] FILESAVE: RTF: Shape changes position after RT

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112519

Xisco Faulí  changed:

   What|Removed |Added

   Keywords||bibisected, bisected,
   ||regression
 Status|UNCONFIRMED |NEW
 CC||xiscofa...@libreoffice.org,
   ||zolnaitamas2...@gmail.com
 Ever confirmed|0   |1

--- Comment #1 from Xisco Faulí  ---
Regression introduced by:

author  Tamás Zolnai    2017-08-22 00:02:07
(GMT)
committer   Tamás Zolnai    2017-08-22
05:53:36 (GMT)
commit  2d1fe7fb67ec1ff1b96912c0945d17d54aecb12e (patch)
tree6d783d7a89d3613544b6de64245f7e9ae147bc75
parent  508957dbf49be577188fb4c112405717957b2734 (diff)
Fix two issues in ActiveX DOCX import / export code
* Inline anchored VML shape had wrong vertical position
** In MSO inline shapes are positioned to the top of the baseline
* During export all shape ids were the same (shape_0)
** VML shapes used to be exported only as fallback,
   I guess that's why it did not cause any issue before.
** Override the shapeid generator with a new one, which
   actually generates unique shapeids.

Bisected with: bibisect-linux64-6.0

Adding Cc: to Tamás Zolnai

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs