[Libreoffice-bugs] [Bug 112989] Time required to export a large document has doubled for Latin (text layout issue)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112989

--- Comment #49 from Telesto  ---
(In reply to Xisco Faulí from comment #48)
> it takes
> 
> real  0m35,795s
> user  0m35,734s
> sys   0m0,301s
> 
> in
> 
> Version: 7.4.0.0.alpha0+ / LibreOffice Community
> Build ID: 9d02b1edafd44b75a8996a97c329fdd4967e8f54
> CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3
> Locale: es-ES (es_ES.UTF-8); UI: en-US
> Calc: threaded

Results are for attachment 136841? Time to export is unchanged for me on
Windows. (Note: I created a fresh report bug 147284)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 112989] Time required to export a large document has doubled for Latin (text layout issue)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112989

--- Comment #48 from Xisco Faulí  ---
it takes

real0m35,795s
user0m35,734s
sys 0m0,301s

in

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: 9d02b1edafd44b75a8996a97c329fdd4967e8f54
CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: es-ES (es_ES.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 112989] Time required to export a large document has doubled for Latin (text layout issue)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112989

--- Comment #47 from Xisco Faulí  ---
(In reply to Xisco Faulí from comment #46)
> Closing this issue as RESOLVED FIXED. I'll create a follow-up bug for the
> time it takes to export to PDF in master, in case it can be improved.

Reusing bug 116400 for that

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112989] Time required to export a large document has doubled for Latin (text layout issue)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112989

--- Comment #46 from Xisco Faulí  ---
I'm sorry but this issue is just a mess.
First, it was confirmed in comment 22 per duplicates but all the duplicates are
from the same person.
Second, This issue is about exporting to PDF, comment 16, comment 23 and some
duplicates are not about exporting PDF but other steps. What is their relation
?
Finally, as I mentioned in comment and comment 44, it's faster in master than
before 8f2dd1df1d6cc94ebbc1149de72bc6d6dffa6533. Besides, Noel pushed a patch
improving it.
Closing this issue as RESOLVED FIXED. I'll create a follow-up bug for the time
it takes to export to PDF in master, in case it can be improved.
@Telesto, please recheck the duplicates ones in master, if you still reproduce
them, change their status to UNCONFIRMED and wait for someone to confirm it.
Thanks in advance.

@Noel, thanks for taking a look at this issue and improving it

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112989] Time required to export a large document has doubled for Latin (text layout issue)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112989

Buovjaga  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #45 from Buovjaga  ---
Thanks for the improvement, Noel!

I'm going to go ahead and close this as fixed. If someone is able to articulate
precisely what else could be done code-wise, please open a new report. It is
clear at this point that we need a report with a proposed strategy - pure
observation is not enough.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112989] Time required to export a large document has doubled for Latin (text layout issue)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112989

--- Comment #44 from Xisco Faulí  ---
took measurements again:

real3m38,023s
user3m35,903s
sys 0m1,863s

in

Version: 6.5.0.0.alpha0+
Build ID: fb1eac64df88baae9f211d052793773686c0e180
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

-

real4m7,506s
user4m4,868s
sys 0m2,327s

in

Version: 6.2.0.0.alpha1+
Build ID: a20a2d7e0d28658f2d9089da076961a599833a28
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

-

real4m27,078s
user4m23,393s
sys 0m2,911s

in

Version: 5.4.0.0.alpha1+
Build ID: 9feb7f7039a3b59974cbf266922177e961a52dd1
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group

-

real8m18,685s
user8m14,931s
sys 0m2,220s

in

Version: 5.2.0.0.alpha1+
Build ID: 5b168b3fa568e48e795234dc5fa454bf24c9805e
CPU Threads: 4; OS Version: Linux 4.15; UI Render: default; 
Locale: ca-ES (ca_ES.UTF-8)

-

real10m22,674s
user10m16,218s
sys 0m2,475s

in

Version: 4.3.0.0.alpha1+
Build ID: c15927f20d4727c3b8de68497b6949e72f9e6e9e

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112989] Time required to export a large document has doubled for Latin (text layout issue)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112989

--- Comment #43 from Commit Notification 
 ---
Noel Grandin committed a patch related to this issue.
It has been pushed to "libreoffice-6-4":

https://git.libreoffice.org/core/commit/580f2b93a9c754743341e5e2f40084bceb8a1680

tdf#112989 reduce export to PDF time

It will be available in 6.4.0.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112989] Time required to export a large document has doubled for Latin (text layout issue)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112989

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:6.5.0|target:6.5.0 target:6.4.0.1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112989] Time required to export a large document has doubled for Latin (text layout issue)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112989

--- Comment #42 from Xisco Faulí  ---
using attachment 136841, export time goes from

real4m22,797s
user4m16,022s
sys 0m2,515s

before Noel's commit to

real4m1,308s
user3m57,773s
sys 0m2,485s

after Noel's commit

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112989] Time required to export a large document has doubled for Latin (text layout issue)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112989

--- Comment #41 from Commit Notification 
 ---
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/11c0effe3def917ec2002a30dbbcca1c5758ffa9

tdf#112989 reduce export to PDF time

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112989] Time required to export a large document has doubled for Latin (text layout issue)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112989

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.5.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112989] Time required to export a large document has doubled for Latin (text layout issue)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112989

--- Comment #40 from Noel Grandin  ---
I have a small fix for this issue, but the bulk of the regression is simply due
to the fact that we are doing more work these days because we cater properly
for more languages.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112989] Time required to export a large document has doubled for Latin (text layout issue)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112989

Xisco Faulí  changed:

   What|Removed |Added

 CC||noelgran...@gmail.com

--- Comment #39 from Xisco Faulí  ---
@Noel, I thought you could be interested in this issue...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112989] Time required to export a large document has doubled for Latin (text layout issue)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112989

--- Comment #38 from Xisco Faulí  ---
it takes

real5m10,981s
user4m53,429s
sys 0m2,727s


in

Version: 6.5.0.0.alpha0+
Build ID: 304368c7be2c9e408cc3884183e39d90a4b15da7
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112989] Time required to export a large document has doubled for Latin (text layout issue)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112989

Xisco Faulí  changed:

   What|Removed |Added

   Priority|high|highest

--- Comment #37 from Xisco Faulí  ---
Changing priority to 'highest' since this a regression and the number of
duplicates is higher than 5 or the number of people in CC higher than 20

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112989] Time required to export a large document has doubled for Latin (text layout issue)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112989

Xisco Faulí  changed:

   What|Removed |Added

   Priority|medium  |high
   Severity|normal  |major

--- Comment #36 from Xisco Faulí  ---
Changing priority to 'high' since the number of duplicates is 5 or higher

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112989] Time required to export a large document has doubled for Latin (text layout issue)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112989

--- Comment #35 from Telesto  ---
Created attachment 151246
  --> https://bugs.documentfoundation.org/attachment.cgi?id=151246=edit
Perf Flame Graph Win

Version: 6.3.0.0.alpha0+
Build ID: 128145e227ef91fb2f23893e73d38ae72cf074e5
CPU threads: 2; OS: Windows 6.3; UI render: default; VCL: win; 
Locale: nl-NL (nl_NL); UI-Language: en-US
Calc: threaded

symbol-only build

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112989] Time required to export a large document has doubled for Latin (text layout issue)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112989

--- Comment #34 from Buovjaga  ---
Created attachment 150572
  --> https://bugs.documentfoundation.org/attachment.cgi?id=150572=edit
Perf flamegraph

Arch Linux 64-bit
Version: 6.3.0.0.alpha0+
Build ID: 558956dc811a1f0f07411e348f7081a467bbc3b5
CPU threads: 8; OS: Linux 5.0; UI render: default; VCL: gtk3; 
Locale: fi-FI (fi_FI.UTF-8); UI-Language: en-US
Calc: threaded
Built on 4 April 2019

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112989] Time required to export a large document has doubled for Latin (text layout issue)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112989

Telesto  changed:

   What|Removed |Added

 CC||vmik...@collabora.co.uk

--- Comment #33 from Telesto  ---
@Miklos
Not sure if you're interested, but this might be related to "Text layout
performance". See comment 24

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112989] Time required to export a large document has doubled for Latin (text layout issue)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112989

--- Comment #32 from Telesto  ---
Repro with
Version: 6.2.0.0.alpha1+
Build ID: 96cf06c947838120e37f3fbb4d0543dd882cb20c
CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2018-10-25_22:57:51
Locale: nl-NL (nl_NL); Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112989] Time required to export a large document has doubled for Latin (text layout issue)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112989

--- Comment #31 from Telesto  ---
Hoping for some improvement in this area.. seeing:
https://gerrit.libreoffice.org/#/c/59108/
https://gerrit.libreoffice.org/#/c/59159/
https://gerrit.libreoffice.org/#/c/59169/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112989] Time required to export a large document has doubled for Latin (text layout issue)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112989

Telesto  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||5757

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112989] Time required to export a large document has doubled for Latin (text layout issue)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112989

--- Comment #30 from Telesto  ---
*** Bug 118165 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112989] Time required to export a large document has doubled for Latin (text layout issue)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112989

Timur  changed:

   What|Removed |Added

Summary|Time required to export a   |Time required to export a
   |large document has doubled  |large document has doubled
   ||for Latin (text layout
   ||issue)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112989] Time required to export a large document has doubled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112989

--- Comment #29 from Timur  ---
*** Bug 116399 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112989] Time required to export a large document has doubled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112989

Telesto  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||6400

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112989] Time required to export a large document has doubled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112989

--- Comment #28 from Telesto  ---
A more real life example: attachment 140185

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112989] Time required to export a large document has doubled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112989

--- Comment #27 from Telesto  ---
Only for the record (before I forget), an additional way to repro
1. Open the attached file 136841
2. Wait until the CPU usage falls back to around 0
3. At a page header

Still hoping for tender is this area ;-)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112989] Time required to export a large document has doubled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112989

--- Comment #26 from Khaled Hosny  ---
(In reply to Telesto from comment #25)
> I would add it to the tender suggestions. It's quite a core feature.

Please do.

> Or an attempt to find a sponsor for this one :-).

Good luck with that. I've been told (and experienced) no one cares about text
layout, no one with deep enough pockets to finance such work.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112989] Time required to export a large document has doubled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112989

--- Comment #25 from Telesto  ---
(In reply to Khaled Hosny from comment #24)
> Any meaningful comparison should use Arabic, Indic or other complex scripts.
> The old layout engines had a shortcut for Latin and similar scripts that did
> very simplistic and fast layout, the new engine does not have such shortcuts
> in principle.

I compared it again, with some Arabic text. Slow with the old engine, bit
faster but still slow with the new engine. 

> This is not to say our text layout is sub-optimal, it is very sub-optimal
> actually, but that is not a regression. It has always been sub-optimal, we
> were just lying by handling Latin in a special way.

It depends how you interpret a regression. There are multiple sub-types:
a. Regression due a change in the operation system (the code has not changed,
isn't working anymore as expected) 
b. A regression between versions of LibreOffice (the behavior changed to the
worse, sec)
c. Technical approach. A unexpected /unintended performance loss.

A/B feel like regressions in the users point of view, but maybe not in the
technical sense of a dev. So it's depending how the keywords are meant (not
clear to me)

Anyway, losing the Latin shortcuts is quite noticeable in quite a lot area's.
(I keep finding new variant). For example large copy/paste actions

I would add it to the tender suggestions. It's quite a core feature. Or an
attempt to find a sponsor for this one :-).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112989] Time required to export a large document has doubled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112989

--- Comment #24 from Khaled Hosny  ---
Any meaningful comparison should use Arabic, Indic or other complex scripts.
The old layout engines had a shortcut for Latin and similar scripts that did
very simplistic and fast layout, the new engine does not have such shortcuts in
principle.

This is not to say our text layout is sub-optimal, it is very sub-optimal
actually, but that is not a regression. It has always been sub-optimal, we were
just lying by handling Latin in a special way.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112989] Time required to export a large document has doubled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112989

--- Comment #23 from Telesto  ---
Created attachment 137988
  --> https://bugs.documentfoundation.org/attachment.cgi?id=137988=edit
Example file

A fast way to reproduce:
1. Open the attached file
2. Hold scroll down & monitor CPU usage; CPU will be 25% with the new Text
Layout engine and 12% with the old one. Scrolling speed is fine, though

Repro on Windows, but not on Linux

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112989] Time required to export a large document has doubled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112989

Buovjaga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #22 from Buovjaga  ---
NEW per dupes.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112989] Time required to export a large document has doubled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112989

--- Comment #21 from Buovjaga  ---
*** Bug 108513 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112989] Time required to export a large document has doubled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112989

--- Comment #20 from Telesto  ---
Created attachment 137818
  --> https://bugs.documentfoundation.org/attachment.cgi?id=137818=edit
Xcode Instruments Screenshots time profiler & code peaks

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112989] Time required to export a large document has doubled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112989

Telesto  changed:

   What|Removed |Added

 OS|Windows (All)   |All

--- Comment #19 from Telesto  ---
Similar result with MacOS

Version: 6.0.0.0.alpha1
Build ID: c1d1f859b268f650143d48f294999cda0fa57350
CPU threads: 4; OS: Mac OS X 10.12.6; UI render: default; 
Locale: nl-NL (nl_NL.UTF-8); Calc: group

MacBook-Air-van:~ demo$ time
/Applications/LibreOfficeDev.app/Contents/MacOS/soffice --headless --convert-to
pdf /Users/demo/Downloads/Demo\(3\)\ -\ kopie.odt --outdir
/Users/demo/Documents/
convert /Users/demo/Downloads/Demo(3) - kopie.odt ->
/Users/demo/Documents//Demo(3) - kopie.pdf using filter : writer_pdf_Export
Overwriting: /Users/demo/Documents//Demo(3) - kopie.pdf

real2m1.820s
user1m59.029s
sys 0m2.147s

-

Version: 5.3.7.2
Build ID: 6b8ed514a9f8b44d37a1b96673cbbdd077e24059
CPU Threads: 4; OS Version: Mac OS X 10.12.6; UI Render: default; Layout
Engine: old; 
Locale: nl-NL (nl_NL.UTF-8); Calc: group

without Harfbuzz

MacBook-Air-van:~ demo$ time
/Applications/LibreOffice.app/Contents/MacOS/soffice --headless --convert-to
pdf /Users/demo/Downloads/Demo\(3\)\ -\ kopie.odt --outdir
/Users/demo/Documents/
convert /Users/demo/Downloads/Demo(3) - kopie.odt ->
/Users/demo/Documents//Demo(3) - kopie.pdf using filter : writer_pdf_Export
Overwriting: /Users/demo/Documents//Demo(3) - kopie.pdf

real1m12.281s
user1m9.470s
sys 0m1.874s

with harfbuzz
MacBook-Air-van:~ demo$ time
/Applications/LibreOffice.app/Contents/MacOS/soffice --headless --convert-to
pdf /Users/demo/Downloads/Demo\(3\)\ -\ kopie.odt --outdir
/Users/demo/Documents/
convert /Users/demo/Downloads/Demo(3) - kopie.odt ->
/Users/demo/Documents//Demo(3) - kopie.pdf using filter : writer_pdf_Export
Overwriting: /Users/demo/Documents//Demo(3) - kopie.pdf

real1m52.251s
user1m48.966s
sys 0m2.180s

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112989] Time required to export a large document has doubled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112989

--- Comment #18 from Telesto  ---
Created attachment 137792
  --> https://bugs.documentfoundation.org/attachment.cgi?id=137792=edit
Example file

> The old layout engine on Windows (for Latin text) was a very simplistic and
> didn’t do much. It would be interesting to compare with non-Latin text (e.g.
> Arabic) to have a more meaningful comparison.

Scrolling speed with Harbuzz is a little slower

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112989] Time required to export a large document has doubled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112989

--- Comment #17 from Khaled Hosny  ---
(In reply to Telesto from comment #16)
> Only for the record. Another example.
> 1. Open attachment bug 123999
> 2. Hold page down key and take notice of the time to scroll down with page
> down (a similar increase as with the export time). LibO5.3 with the old
> layout engine noticeably faster. 
> Setting to win only

The old layout engine on Windows (for Latin text) was a very simplistic and
didn’t do much. It would be interesting to compare with non-Latin text (e.g.
Arabic) to have a more meaningful comparison.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112989] Time required to export a large document has doubled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112989

Telesto  changed:

   What|Removed |Added

 CC||todven...@suomi24.fi
  Component|Printing and PDF export |LibreOffice
 OS|All |Windows (All)

--- Comment #16 from Telesto  ---
Only for the record. Another example.
1. Open attachment bug 123999
2. Hold page down key and take notice of the time to scroll down with page down
(a similar increase as with the export time). LibO5.3 with the old layout
engine noticeably faster. 
Setting to win only

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112989] Time required to export a large document has doubled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112989

--- Comment #15 from Telesto  ---
Created attachment 137494
  --> https://bugs.documentfoundation.org/attachment.cgi?id=137494=edit
SHGetFileInfoW Non-Debug build

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112989] Time required to export a large document has doubled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112989

--- Comment #14 from Telesto  ---
Created attachment 137493
  --> https://bugs.documentfoundation.org/attachment.cgi?id=137493=edit
Very sleepy when exporting to PDF in multi-page view

I probably found a second issue.
1. Exporting to PDF is single page view (or using command line) is slow
2. Doing that in multi-page view makes thing even slower (something about
freeing SwAnchoredDrawObject::IsValidPos) [Not sure if I should report this
here, though]

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112989] Time required to export a large document has doubled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112989

--- Comment #13 from Telesto  ---
Created attachment 137492
  --> https://bugs.documentfoundation.org/attachment.cgi?id=137492=edit
Very Sleepy time profile results

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112989] Time required to export a large document has doubled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112989

--- Comment #12 from Telesto  ---
Created attachment 137491
  --> https://bugs.documentfoundation.org/attachment.cgi?id=137491=edit
Screenshot Non-Debug

Version: 6.0.0.0.alpha1+
Build ID: 13c5dd1d98a480cb01ca8f24242c80e326e4ade8
CPU threads: 4; OS: Windows 6.3; UI render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2017-10-30_23:52:07
Locale: nl-NL (nl_NL); Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112989] Time required to export a large document has doubled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112989

--- Comment #11 from Khaled Hosny  ---
(In reply to Telesto from comment #10)
> Created attachment 137481 [details]
> Screenshot
> 
> Most time is spend in ScriptRun:
> 
> u_getNumericValue_59  icuuc59 [unknown]   0   0x5c1f6ad7
> uscript_getScript_59  icuuc59 [unknown]   0   0x5c1f8d96
> vcl::ScriptRun::next  vcllo
> c:\cygwin\home\tinderbox\master\vcl\source\gdi\scrptrun.cxx   162 
> 0x5c77e8dd
> vcl::TextLayoutCache::TextLayoutCache vcllo
> c:\cygwin\home\tinderbox\master\vcl\source\gdi\commonsallayout.cxx290
> 0x5c782423
> CommonSalLayout::LayoutText   vcllo
> c:\cygwin\home\tinderbox\master\vcl\source\gdi\commonsallayout.cxx454
> 0x5c783d28

Debug builds are unreliable for performance profiling, you need to do this with
a non-debug build.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112989] Time required to export a large document has doubled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112989

--- Comment #10 from Telesto  ---
Created attachment 137481
  --> https://bugs.documentfoundation.org/attachment.cgi?id=137481=edit
Screenshot

Most time is spend in ScriptRun:

u_getNumericValue_59icuuc59 [unknown]   0   0x5c1f6ad7
uscript_getScript_59icuuc59 [unknown]   0   0x5c1f8d96
vcl::ScriptRun::nextvcllo  
c:\cygwin\home\tinderbox\master\vcl\source\gdi\scrptrun.cxx 162
0x5c77e8dd
vcl::TextLayoutCache::TextLayoutCache   vcllo  
c:\cygwin\home\tinderbox\master\vcl\source\gdi\commonsallayout.cxx  290
0x5c782423
CommonSalLayout::LayoutText vcllo  
c:\cygwin\home\tinderbox\master\vcl\source\gdi\commonsallayout.cxx  454
0x5c783d28

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112989] Time required to export a large document has doubled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112989

--- Comment #9 from Telesto  ---
Created attachment 137368
  --> https://bugs.documentfoundation.org/attachment.cgi?id=137368=edit
Very Sleepy results

(In reply to Khaled Hosny from comment #8)
> Can someone run this in a profiler and find where the new time is spent? I’m
> not very familiar with Windows to know how to do that, sorry.

I created a time profile with very sleepy (http://www.codersnotes.com/sleepy/).
http://github.com/CyberShadow/verysleepy/releases/download/v0.90/verysleepy-cs-0.90.exe

Not sure how reliable it is, but it might work. 

I did three runs (x86). Two with LibO 5.3.7.2 (old and new layout) and one with
a LibO6 debug build from 22 oct with symbols.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112989] Time required to export a large document has doubled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112989

--- Comment #8 from Khaled Hosny  ---
Can someone run this in a profiler and find where the new time is spent? I’m
not very familiar with Windows to know how to do that, sorry.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112989] Time required to export a large document has doubled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112989

--- Comment #7 from Telesto  ---
*** Bug 112979 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112989] Time required to export a large document has doubled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112989

--- Comment #6 from Telesto  ---
*** Bug 113350 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112989] Time required to export a large document has doubled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112989

--- Comment #5 from Telesto  ---
*** Bug 113139 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112989] Time required to export a large document has doubled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112989

Telesto  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #4 from Telesto  ---
LibO6 on Windows
$ time instdir/program/soffice --headless --convert-to pdf "C:\Demo.odt"
convert C:\Demo.odt -> C:\cygwin\home\DEMO\bibisect-win32-6.0\Demo.pdf using
filter : writer_pdf_Export

real1m8,039s
user0m0,015s
sys 0m0,000s

LibO5.2 on Windows
$ time instdir/program/soffice --headless --convert-to pdf "C:\Demo.odt"
convert C:\Demo.odt -> C:\cygwin\home\DEMO\bibisect-win32-5.2\Demo.pdf using
filter : writer_pdf_Export

real0m29,305s
user0m0,000s
sys 0m0,000s

It's the same file, I only renamed it.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112989] Time required to export a large document has doubled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112989

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||xiscofa...@libreoffice.org
 Ever confirmed|0   |1

--- Comment #3 from Xisco Faulí  ---
I can't confirm it. In

Version: 6.0.0.0.alpha0+
Build ID: 616f21db9e50a77b0c02dfb123f871a742f46216
CPU threads: 4; OS: Linux 4.10; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group

it takes 

real1m1,378s
user1m0,772s
sys 0m0,328s

to open and export it.
-> time program/soffice --headless --convert-to pdf
/home/xisco/Baixades/Demo\(3\)\ -\ kopie.odt --outdir /home/xisco/Escriptori/

OTOH, in

Version: 5.2.0.0.alpha1+
Build ID: 5b168b3fa568e48e795234dc5fa454bf24c9805e
CPU Threads: 4; OS Version: Linux 4.8; UI Render: default; 
Locale: ca-ES (ca_ES.UTF-8)

it takes

real2m18,425s
user2m3,976s
sys 0m0,400s

Could you please use 'time' to get accurate numbers?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112989] Time required to export a large document has doubled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112989

Telesto  changed:

   What|Removed |Added

   Keywords||bibisected, bisected, perf,
   ||regression

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112989] Time required to export a large document has doubled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112989

Telesto  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||3093

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112989] Time required to export a large document has doubled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112989

Telesto  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||2979

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112989] Time required to export a large document has doubled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112989

Telesto  changed:

   What|Removed |Added

 Blocks||103729


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103729
[Bug 103729] [META] HarfBuzz-based common text layout regressions
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112989] Time required to export a large document has doubled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112989

--- Comment #2 from Telesto  ---
Created attachment 136841
  --> https://bugs.documentfoundation.org/attachment.cgi?id=136841=edit
Example file

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112989] Time required to export a large document has doubled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112989

--- Comment #1 from Telesto  ---
Created attachment 136840
  --> https://bugs.documentfoundation.org/attachment.cgi?id=136840=edit
Bibisect log

author  Khaled Hosny 2016-11-02 21:52:06 (GMT)
committer   Khaled Hosny 2016-11-03 00:17:06
(GMT)
commit  8f2dd1df1d6cc94ebbc1149de72bc6d6dffa6533 (patch)
treedb496889434c484a87b13ffcc4650d65e6672129
parent  c8be45889217c555e4bec92af838d0524ceba4e0 (diff)
Revert "Revert "Enable the new text layout engine by default""
This reverts commit 3950166877bf1308f9e449992e20b558342af825.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs