[Libreoffice-bugs] [Bug 113647] UI Undocking the sidebar allows multiple settings windows to open simultaneously , which can crash the app

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113647

--- Comment #5 from Xisco Faulí  ---
I think there are two different crashes here.
I can't reproduce the one in the description, but I can the one in comment 1,
which is related to bug 105017.
I would suggest to have this ticket for the crash in 'New Theme' and open a new
one for the crash in the description

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113647] UI Undocking the sidebar allows multiple settings windows to open simultaneously , which can crash the app

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113647

Xisco Faulí  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||5017

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113647] UI Undocking the sidebar allows multiple settings windows to open simultaneously , which can crash the app

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113647

Xisco Faulí  changed:

   What|Removed |Added

 OS|Windows (All)   |All

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113647] UI Undocking the sidebar allows multiple settings windows to open simultaneously , which can crash the app

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113647

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org
Crash report or||["vcl::Window::EnableInput(
crash signature||bool,bool)"]

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113647] UI Undocking the sidebar allows multiple settings windows to open simultaneously , which can crash the app

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113647

--- Comment #4 from Mike Kaganski  ---
The steps to reproduce comment 1 (just in case the screencast gets no longer
available):

1. In Writer, undock side panel, and switch to Gallery pane.
2. Click "New Theme..." (pane's topmost button)
3. Click "New Theme..." second time.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113647] UI Undocking the sidebar allows multiple settings windows to open simultaneously , which can crash the app

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113647

Mike Kaganski  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #3 from Mike Kaganski  ---
Reproducible with 

Version: 6.0.0.0.alpha1+ (x64)
Build ID: b03fe77699b1ad30a9441bd9b283f25579ac261e
CPU threads: 4; OS: Windows 10.0; UI render: GL; 
Locale: en-US (ru_RU); Calc: CL

and

Version: 5.4.2.2 (x64)
Build ID: 22b09f6418e8c2d508a9eaf86b2399209b0990f4
CPU threads: 4; OS: Windows 6.19; UI render: GL; 
Locale: ru-RU (ru_RU); Calc: CL

Code pointers for an interested developer:

The crash happens because Dialog::ImplStartExecuteModal() tries to access
previous active modal dialog's member, but the previous active dialog is
already disposed of at that time (and
ImplGetSVData()->maWinData.mpLastExecuteDlg still points to that already
disposed dialog).

This happens (in case of gallery crash) in
GalleryBrowser1::ImplGalleryThemeProperties, where mpThemePropertiesDialog
(referencing the previous gallery dialog) is reassigned to a newly created
dialog, thus disposing previous one.

The problems:

1. It shouldn't be possible to operate on detached tools, like with attached;
so the reassignment wouldn't happen;
2. In that case, if we first checked for existence of the dialog, and possibly
just returned the already existing instance, it would work. Or maybe add an
assert that would express the invariant (that the mpThemePropertiesDialog must
be empty before assignment).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113647] UI Undocking the sidebar allows multiple settings windows to open simultaneously , which can crash the app

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113647

Dieter Praas  changed:

   What|Removed |Added

 CC||dgp-m...@gmx.de

--- Comment #2 from Dieter Praas  ---
I tried to reproduce it with the steps from the bug report, but I had no crash.

Version: 6.0.0.0.alpha1 (x64)
Build ID: c1d1f859b268f650143d48f294999cda0fa57350
CPU threads: 4; OS: Windows 10.0; UI render: default; 
Locale: de-DE (de_DE); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113647] UI Undocking the sidebar allows multiple settings windows to open simultaneously , which can crash the app

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113647

--- Comment #1 from Emil Tanev  ---
Here is another crash scenario - New Theme

https://www.screencast.com/t/LinOmuTEnY

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113647] UI Undocking the sidebar allows multiple settings windows to open simultaneously , which can crash the app

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113647

Emil Tanev  changed:

   What|Removed |Added

Summary|UI Undocking the sidebar|UI Undocking the sidebar
   |allows multiple setting |allows multiple settings
   |windows to open |windows to open
   |simultaneously, which can   |simultaneously, which can
   |crash the app   |crash the app

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs