[Libreoffice-bugs] [Bug 113979] Paste unformated text does not ignore empty cells

2017-12-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113979

Laurent BP  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |jumbo4...@yahoo.fr
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 113979] Paste unformated text does not ignore empty cells

2017-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113979

--- Comment #8 from cru...@gmail.com ---
I confirm the bug explained here or what I consider as so or at least a loss of
functionality. I clearly use this disappeared feature everyday since I put
formulas between pasted raw text. Therefore, thanks to Laurent investigation, I
had to revert to an ancient version that works it should.
OS : linux
version : back to 5.2.7.2

What I clearly ask is for an option to tick just like in copy-special paste
from csv to sheet

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 113979] Paste unformated text does not ignore empty cells

2017-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113979

--- Comment #7 from Laurent BP  ---
(In reply to Tamás Gulácsi from comment #6)
> The "Text to Columns" case is clear, you don't want to have anything there
> which weren't in the text before.
> The simplest case for this is converting ",a,b,c" to columns - you want "_ a
> b c" and not ",a,b,c a b c".
I do not totally agree with you. It's OK for the *first* column: if text starts
with a separator, first column must be empty.
But if text contains several successive separator, user may (or not) want to
keep the previous content of the cell.
Lets consider for example in column A: ",b,,d,,f". 
In Text to column with comma as separator, with previous behavior (prior 5.3)
content of column C and E where preserved (and column A was not emptied which
was the bug). With new behavior (from version 5.3), column A, C and E are
emptied.

As this was the behavior from the beginning, not erasing columns C and E should
be consider as a feature.

An option "Skip empty cells" would make all users happy, if Text to column
function considers to erase first column if text starts with a separator.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 113979] Paste unformated text does not ignore empty cells

2017-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113979

Laurent BP  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=69
   ||981

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 113979] Paste unformated text does not ignore empty cells

2017-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113979

--- Comment #6 from Tamás Gulácsi  ---
The "Text to Columns" case is clear, you don't want to have anything there
which weren't in the text before.
The simplest case for this is converting ",a,b,c" to columns - you want "_ a b
c" and not ",a,b,c a b c".

I can accept that pasting raw text may behave differently, and skip empty
cells, but that should be at least configurable, is someone want it
differently/consistently.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 113979] Paste unformated text does not ignore empty cells

2017-11-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113979

--- Comment #5 from Laurent BP  ---
Or shall we have an option "Skip empty cells" to let user decide which behavior
he is expecting?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 113979] Paste unformated text does not ignore empty cells

2017-11-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113979

--- Comment #4 from Laurent BP  ---
I came to the same conclusion with a manual bisection ;-)

It seems that this behavior was intentionally introduced with commit
96175a4bc6687c3adc31b9e0246fe49db2b7675e
https://cgit.freedesktop.org/libreoffice/core/commit/sc/source/ui?id=96175a4bc6687c3adc31b9e0246fe49db2b7675e

to fix bug 69981 for Text to column function.

Shall we have a different behavior when pasting raw text?
@Eike: any advice?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 113979] Paste unformated text does not ignore empty cells

2017-11-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113979

Xisco Faulí  changed:

   What|Removed |Added

   Keywords||bibisected, bisected
 Status|UNCONFIRMED |NEW
 CC||er...@redhat.com,
   ||tgulacsi78+libreoffice@gmai
   ||l.com,
   ||xiscofa...@libreoffice.org
 Ever confirmed|0   |1

--- Comment #3 from Xisco Faulí  ---
Regression introduced by:

author  Tamás Gulácsi 2016-11-11 20:11:01 (GMT)
committer   Eike Rathke   2016-11-12 14:43:22 (GMT)
commit  96175a4bc6687c3adc31b9e0246fe49db2b7675e (patch)
tree2cefbbe0c0f8be5a0b4ad5c402fd80bab80bbdf5
parent  f57502e75cae1020f3fcfa5919802a78a6ccb6ff (diff)
tdf#69981 - sc: blank empty cells in TextToColumns
If the string is empty, we must delete the destination cell.
This is done, iff we don't return early (rStr.isEmpty() check).
Instead, add a fast path for the empty string.

Bisected with: bibisect-linux-64-5.3

Adding Cc: to Tamás Gulácsi

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 113979] Paste unformated text does not ignore empty cells

2017-11-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113979

--- Comment #2 from Laurent BP  ---
Reproduce with:
- Version: 5.3.0.0.alpha1+ (x64)
Build ID: 9745d29227e471ce40e9992fefd92e10a48696fb
CPU Threads: 4; OS Version: Windows 6.1; UI Render: default; Layout Engine:
new; 
TinderBox: Win-x86_64@62-TDF, Branch:MASTER, Time: 2016-11-18_21:55:13
Locale: fr-FR (fr_FR); Calc: CL

NOT reproduce with:
- Version: 5.3.0.0.alpha1+
Build ID: bbd44f8f89839b5abb4ec6c7ea195431de5b2f48
CPU Threads: 4; OS Version: Windows 6.1; UI Render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2016-10-26_23:19:45
Locale: fr-FR (fr_FR); Calc: CL

Regression was introduced between 2016-10-26_23:19:45 and 2016-11-18_21:55:13

Still present in recent master:
- Version: 6.0.0.0.alpha1+ (x64)
Build ID: 6d24213d55df33c7bb5f10d511dcfc82b745db38
CPU threads: 4; OS: Windows 6.1; UI render: default; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2017-11-18_04:09:43
Locale: fr-FR (fr_FR); Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 113979] Paste unformated text does not ignore empty cells

2017-11-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113979

Laurent BP  changed:

   What|Removed |Added

Version|5.3.0.1 rc  |5.3.0.0.beta1

--- Comment #1 from Laurent BP  ---
Reproduce with:
- Version: 5.3.0.0.beta1 (x64)
Build ID: 690f553ecb3efd19143acbf01f3af4e289e94536
Threads CPU : 2; Version de l'OS :Windows 6.1; UI Render : par défaut; Layout
Engine: new; 
Locale : fr-FR (fr_FR); Calc: CL
- Version: 5.4.2.1 (x64)
Build ID: dfa67a98bede79c671438308dc9036d50465d2cb
Threads CPU : 2; OS : Windows 6.1; UI Render : par défaut; 
Locale : fr-FR (fr_FR); Calc: CL

Set as regression

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 113979] Paste unformated text does not ignore empty cells

2017-11-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113979

Laurent BP  changed:

   What|Removed |Added

   Keywords||regression

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs