[Libreoffice-bugs] [Bug 114839] During execution of the Document Recovery dialog, Dialog::Execute() keeps looping even if nothing happens

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114839

--- Comment #11 from Tor Lillqvist  ---
Well, I guess at least the bump of minimum macOS to 10.9 can not be done for
6.2, as it would come as a SURPRISE to both the LibreOffice users who still run
10.9, and we can't have that, can we? So in theory, assuming that the
"pulsating" thing actually works on 10.9 thanks to this code that was removed,
removing it in 6.2 would be a REGRESSION!!!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114839] During execution of the Document Recovery dialog, Dialog::Execute() keeps looping even if nothing happens

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114839

--- Comment #10 from Xisco Faulí  ---
@Tor Lillqvist, thanks for fixing this issue. Should it be cherry-picked to 6.2
branch ?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114839] During execution of the Document Recovery dialog, Dialog::Execute() keeps looping even if nothing happens

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114839

Tor Lillqvist  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114839] During execution of the Document Recovery dialog, Dialog::Execute() keeps looping even if nothing happens

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114839

--- Comment #9 from Commit Notification 
 ---
Tor Lillqvist committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/c76160c6e23f8a4e8d60068b7054591f238cbc9f%5E%21

tdf#114839: Drop ancient AquaBlinker crack

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114839] During execution of the Document Recovery dialog, Dialog::Execute() keeps looping even if nothing happens

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114839

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.3.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114839] During execution of the Document Recovery dialog, Dialog::Execute() keeps looping even if nothing happens

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114839

--- Comment #8 from Tor Lillqvist  ---
Bumping the minimum required version to 10.10 or 10.11 would be fine with me,
but I don't decide these things.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114839] During execution of the Document Recovery dialog, Dialog::Execute() keeps looping even if nothing happens

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114839

--- Comment #7 from Telesto  ---
(In reply to Tor Lillqvist from comment #5)
> I am told on IRC that OS X stopped having pulsating default buttons only in
> 10.10, and as LO supports 10.9 or newer, possibly the code is actually
> useful still. (But I doubt those who do run LO on 10.9 would be awfully
> disappointed if the blinking disappeared... Also, we could well bump the
> minimum OS version to 10.10 by LO 6.1, IMHO.)

Any change to get a bump the minimum OS version to 10.10 or even 10.11 for
LO6.3?
Mavericks getting old by now.. Not that I'm in a hurry..

And maybe a bump in compiler baseline too.. even if this isn't needed compiler
wise
(http://document-foundation-mail-archive.969070.n3.nabble.com/Compiler-baselines-was-Libreoffice-qa-minutes-of-ESC-call-td4244437.html#a4248710)

The last XCode bump did break some stuff on MacOS side (if I remember
correctly; page orientation while printing).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114839] During execution of the Document Recovery dialog, Dialog:: Execute() keeps looping even if nothing happens

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114839

Xisco Faulí  changed:

   What|Removed |Added

   Assignee|tele...@surfxs.nl   |libreoffice-b...@lists.free
   ||desktop.org

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114839] During execution of the Document Recovery dialog, Dialog:: Execute() keeps looping even if nothing happens

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114839

Telesto  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
   Assignee|libreoffice-b...@lists.free |tele...@surfxs.nl
   |desktop.org |
 Ever confirmed|0   |1

--- Comment #3 from Telesto  ---
Created attachment 139495
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139495=edit
Possible solution

I might found the cause (or a clue). The problem will disappear when commenting
out the following lines.

diff --git a/vcl/osx/salnativewidgets.cxx b/vcl/osx/salnativewidgets.cxx
index d311526c0168..32f940516bd5 100644
--- a/vcl/osx/salnativewidgets.cxx
+++ b/vcl/osx/salnativewidgets.cxx
@@ -64,10 +64,10 @@ public:
 {
 if( AquaSalFrame::isAlive( mpFrame ) && mpFrame->mbShown )
 {
-mpFrame->maBlinkers.remove( this );
-mpFrame->SendPaintEvent(  );
+ //   mpFrame->maBlinkers.remove( this );
+  //  mpFrame->SendPaintEvent(  );
 }
-delete this;
+  //  delete this;
 }
 };

More in general, what does Aquablink do? Creating a glow button or something
like that? I didn't notice any difference without it (patch attached). Note: I
didn't delete the reference in schedule

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114839] During execution of the Document Recovery dialog, Dialog:: Execute() keeps looping even if nothing happens

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114839

--- Comment #2 from Tor Lillqvist  ---
Possibly.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114839] During execution of the Document Recovery dialog, Dialog:: Execute() keeps looping even if nothing happens

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114839

--- Comment #1 from Telesto  ---
Any relation with bug 104030?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114839] During execution of the Document Recovery dialog, Dialog:: Execute() keeps looping even if nothing happens

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114839

Tor Lillqvist  changed:

   What|Removed |Added

 CC||t...@iki.fi
   Hardware|All |x86-64 (AMD64)
 OS|All |Mac OS X (All)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs