[Libreoffice-bugs] [Bug 115182] FILEOPEN XLSX Pie chart default percentage format does not match Excels

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115182

Eike Rathke  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |er...@redhat.com
   |desktop.org |
 Status|NEW |ASSIGNED

--- Comment #5 from Eike Rathke  ---
Old code obtained all percent formats for the locale and used the first it
encountered, which by chance was one without decimals. New code uses the
defined default percent format of the locale. If here it has to be without
decimals (which for a pie chart certainly makes sense) then we'll have to do it
differently.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115182] FILEOPEN XLSX Pie chart default percentage format does not match Excels

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115182

Aron Budea  changed:

   What|Removed |Added

 CC||er...@redhat.com
   Keywords||bibisected, bisected,
   ||regression

--- Comment #4 from Aron Budea  ---
This seems to be a regression, which started from the commit referenced below
(bibisected using repo bibisect-win32-5.1). I can't establish if this is indeed
a regression, or if it had worked fine by accident before the patch, Eike,
could you please share your thoughts?

https://cgit.freedesktop.org/libreoffice/core/commit/?id=0f4b3cb7d3d68906de316a64dcec281da2a641bd
author  Eike Rathke   2015-08-10 17:04:13 +0200
committer   Eike Rathke   2015-08-10 17:12:45 +0200

if we have a number formatter then use it, dammit..

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115182] FILEOPEN XLSX Pie chart default percentage format does not match Excels

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115182

--- Comment #3 from Andras Timar  ---
A related commit:
commit d22a4d945ccf1456fbdb2c39802d956afa583a2a
Author: Matúš Kukan 
Date:   Thu Sep 11 08:56:22 2014 +0200

bnc#892610: OOXML import: Improve chart number formats.

If sourceLinked is used, do not set "PercentageNumberFormat" even if
showPercent is true. The format string should be used for "NumberFormat".

c8cc89ff802d86b1f3a69afe1b4835b7df7f70c7 unnecessarily disabled
"LinkNumberFormatToSource". Use that for data labels but not for axis.

Also, actually make attaching number format supplier work for Calc.
Previously, non standard formats were added into wrong supplier,
and they were thrown away later because it was attached too late.
(See also ChartModel::attachNumberFormatsSupplier)

Change-Id: Iaf9945abc3d82d0ac63d9f36beb49f39ab57

It seems this logic is wrong. 

diff --git a/oox/source/drawingml/chart/objectformatter.cxx
b/oox/source/drawingml/chart/objectformatter.cxx
index 8d49c0d01fef..a90ca8f49f33 100644
--- a/oox/source/drawingml/chart/objectformatter.cxx
+++ b/oox/source/drawingml/chart/objectformatter.cxx
@@ -1080,7 +1080,7 @@ void ObjectFormatter::convertNumberFormat( PropertySet&
rPropSet, const NumberFo
 if( mxData->mxNumFmts.is() )
 {
 const bool bGeneral =
rNumberFormat.maFormatCode.equalsIgnoreAsciiCase("general");
-const bool bPercent = !bAxis && bShowPercent &&
!rNumberFormat.mbSourceLinked;
+const bool bPercent = !bAxis && bShowPercent;
 sal_Int32 nPropId = bPercent ? PROP_PercentageNumberFormat :
PROP_NumberFormat;
 OUString sFormatCode(rNumberFormat.maFormatCode);
 if (bPercent && bGeneral)

After this, percent values are shown as expected, but it breaks a unit test
(and indeed, import of chart2/qa/extras/data/xlsx/number-formats.xlsx becomes
wrong).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115182] FILEOPEN XLSX Pie chart default percentage format does not match Excels

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115182

Aron Budea  changed:

   What|Removed |Added

 Blocks||75057


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=75057
[Bug 75057] [META] OOXML Chart object issues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115182] FILEOPEN XLSX Pie chart default percentage format does not match Excels

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115182

m.a.riosv  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||miguelangelrv@libreoffice.o
   ||rg
 Ever confirmed|0   |1

--- Comment #2 from m.a.riosv  ---
Repro
Version: 5.4.4.2 (x64)
Build ID: 2524958677847fb3bb44820e40380acbe820f960
CPU threads: 4; OS: Windows 6.19; UI render: GL; 
Locale: es-ES (es_ES); Calc: CL

The 3D is marked on the char type but not selection between 'Simple' or
'Realistic'
Data format is imported 'Show values as percentage' with 'Percent format' as
'Source format'

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115182] FILEOPEN XLSX Pie chart default percentage format does not match Excels

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115182

--- Comment #1 from Gabor Kelemen  ---
Created attachment 139309
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139309=edit
Screenshot of the document in LO 5.4 and Excel 2013

LO 6.1 master shows the same problem.
Also one may note:
- no shadow in Calc
- no ALL CAPS character format for the chart title in Calc

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs