[Libreoffice-bugs] [Bug 116394] DocX Import - Word merge fields lose "=" character

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116394

Adolfo Jayme  changed:

   What|Removed |Added

 Whiteboard|target:7.2.0 target:7.0.5   |target:7.2.0 target:7.0.5
   |target:7.1.1 target:7.1.0   |target:7.1.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116394] DocX Import - Word merge fields lose "=" character

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116394

--- Comment #11 from Commit Notification 
 ---
Justin Luth committed a patch related to this issue.
It has been pushed to "libreoffice-7-1-0":

https://git.libreoffice.org/core/commit/9218b1f71ee522b69d09b9a62a3a2f04a6f9f543

tdf#116394 writerfilter: append '=' if not a formula marker

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116394] DocX Import - Word merge fields lose "=" character

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116394

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:7.2.0 target:7.0.5   |target:7.2.0 target:7.0.5
   |target:7.1.1|target:7.1.1 target:7.1.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116394] DocX Import - Word merge fields lose "=" character

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116394

--- Comment #10 from Commit Notification 
 ---
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/63239749683ad718e10a5f561f17ca3c41ab4466

tdf#116394: sw_ooxmlexport15: Add unittest

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116394] DocX Import - Word merge fields lose "=" character

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116394

--- Comment #9 from Commit Notification 
 ---
Justin Luth committed a patch related to this issue.
It has been pushed to "libreoffice-7-1":

https://git.libreoffice.org/core/commit/d864b799e0460c2c8ada62fd598e7adcb1ac6700

tdf#116394 writerfilter: append '=' if not a formula marker

It will be available in 7.1.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116394] DocX Import - Word merge fields lose "=" character

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116394

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:7.2.0 target:7.0.5   |target:7.2.0 target:7.0.5
   ||target:7.1.1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116394] DocX Import - Word merge fields lose "=" character

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116394

Xisco Faulí  changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED

--- Comment #8 from Xisco Faulí  ---
Verified in

Version: 7.2.0.0.alpha0+ / LibreOffice Community
Build ID: 6ce66560c59470a9eb76fbf80f439b452166d3e4
CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

@Justin Luth, thanks for fixing this issue!!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116394] DocX Import - Word merge fields lose "=" character

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116394

--- Comment #7 from Commit Notification 
 ---
Justin Luth committed a patch related to this issue.
It has been pushed to "libreoffice-7-0":

https://git.libreoffice.org/core/commit/1b5ff41ae250ccd6b0e73b412ab7bd655f489d74

tdf#116394 writerfilter: append '=' if not a formula marker

It will be available in 7.0.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116394] DocX Import - Word merge fields lose "=" character

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116394

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:7.2.0|target:7.2.0 target:7.0.5

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116394] DocX Import - Word merge fields lose "=" character

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116394

--- Comment #6 from Julien Nabet  ---
(In reply to Justin L from comment #5)
> Julien, you did almost all the work, so you deserve the credit for this one.

Just some great team work, Xisco found the commit, I made some hypothesis, you
made the fix! :-)
Thank you!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116394] DocX Import - Word merge fields lose "=" character

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116394

Justin L  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
 CC||jl...@mail.com

--- Comment #5 from Justin L  ---
Julien, you did almost all the work, so you deserve the credit for this one.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116394] DocX Import - Word merge fields lose "=" character

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116394

--- Comment #4 from Commit Notification 
 ---
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b232b422a3cfe3b410bbc75e0fffdfc238fd10e7

tdf#116394 writerfilter: append '=' if not a formula marker

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116394] DocX Import - Word merge fields lose "=" character

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116394

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116394] DocX Import - Word merge fields lose "=" character

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116394

Xisco Faulí  changed:

   What|Removed |Added

 Blocks||123370


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=123370
[Bug 123370] [META] "Expression is faulty" regressions
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116394] DocX Import - Word merge fields lose "=" character

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116394

Xisco Faulí  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||3357

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116394] DocX Import - Word merge fields lose "=" character

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116394

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||112969


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=112969
[Bug 112969] [META] DOCX (OOXML) field-related issues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116394] DocX Import - Word merge fields lose "=" character

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116394

Korrawit Pruegsanusak  changed:

   What|Removed |Added

 Attachment #140626|application/octet-stream|application/vnd.openxmlform
  mime type||ats-officedocument.wordproc
   ||essingml.document

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116394] DocX Import - Word merge fields lose "=" character

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116394

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr,
   ||vmik...@collabora.co.uk
   Severity|normal  |major

--- Comment #3 from Julien Nabet  ---
On pc Debian x86-64 with master sources updated today, I could reproduce this.
The pb is in these lines:
   2525 case '=':
   2526 if (token.isEmpty())
   2527 {
   2528 rHaveToken = true;
   2529 ++rIndex;
   2530 return OUString("FORMULA");
   2531 }
   2532 break;
in writerfilter/source/dmapper/DomainMapper_Impl.cxx

Miklos/Jean-Sebastien: thought you might be interested in this one following
Xisco's comment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116394] DocX Import - Word merge fields lose "=" character

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116394

Xisco Faulí  changed:

   What|Removed |Added

   Keywords||bibisected, bisected,
   ||regression
 Status|UNCONFIRMED |NEW
 CC||reali...@gmail.com,
   ||xiscofa...@libreoffice.org
  Component|filters and storage |Writer
Version|5.4.0.3 release |5.4.0.0.alpha0+
 Ever confirmed|0   |1

--- Comment #2 from Xisco Faulí  ---
Regression introduced by:

author  Jean-Sebastien Bevilacqua   2017-02-16 10:54:33
+0100
committer   Miklos Vajna   2017-03-30 17:39:00
+
commit  c568eb7d3bb4584867f0a1f0a7965f73097f009b (patch)
treeea7e6fb1e0d77369a90bc69dd8756f589bb352e4
parent  53c2507bf97867011fd2bfbbac6c86b7fc494338 (diff)
tdf#105975 Add Formula field parsing (docx) in SWriter
Introduction


In MSWord, you can create a formula field (starting with =).
When you save your file as `docx`, this `FORMULA` field is registered
in you file (a field starting with `=`). In its current state,
LibreOffice can't parse the `FORMULA` field in `docx` file.

Context of this fix
---

This fix is entirely located in the `DomainMapper_Impl.cxx` file
because it's where the parsing is done.

How this fix works
--

First, we add `FORMULA` support by adding it to the `aFields[]` variable.
Next, to handle the `FORMULA` constant, we add a condition (swith case) in
`DomainMapper_Impl::CloseFieldCommand()` to call `handleFieldFormula`.

Note


In function `lcl_ExtractToken`, if command starts with `=`, it's a
`FORMULA` field.


Bisected with: bibisect-linux-64-5.4

Adding Cc: to Jean-Sebastien Bevilacqua

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116394] DocX Import - Word merge fields lose "=" character

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116394

Paul  changed:

   What|Removed |Added

 CC||paul.jow...@systemic.com.au

--- Comment #1 from Paul  ---
Created attachment 140626
  --> https://bugs.documentfoundation.org/attachment.cgi?id=140626=edit
Minimal DOCX file showing 1 affected merge field.

Good import (content.xml) looks like:
  

Bab import (content.xml) looks like:
  

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs