[Libreoffice-bugs] [Bug 116680] Sidebar can't be undocked

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116680

Xisco Faulí  changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116680] Sidebar can't be undocked

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116680

--- Comment #12 from Jim Raykowski  ---
(In reply to Samuel Mehrbrodt (CIB) from comment #11)
> (In reply to Jim Raykowski from comment #10)
> > I believe the patch has fixed this. Is it customary for the bug reporter to
> > close the report or is it ok for anyone to close it?
> 
> If you fixed it, you can directly set it to RESOLVED FIXED. Once another
> person verifies the fix, he sets the status to RESOLVED VERIFIED.

Thanks for clearing that up for me.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116680] Sidebar can't be undocked

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116680

Jim Raykowski  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116680] Sidebar can't be undocked

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116680

--- Comment #11 from Samuel Mehrbrodt (CIB)  ---
(In reply to Jim Raykowski from comment #10)
> I believe the patch has fixed this. Is it customary for the bug reporter to
> close the report or is it ok for anyone to close it?

If you fixed it, you can directly set it to RESOLVED FIXED. Once another person
verifies the fix, he sets the status to RESOLVED VERIFIED.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116680] Sidebar can't be undocked

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116680

--- Comment #10 from Jim Raykowski  ---
I believe the patch has fixed this. Is it customary for the bug reporter to
close the report or is it ok for anyone to close it?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116680] Sidebar can't be undocked

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116680

--- Comment #9 from Xisco Faulí  ---
Fix verified in

Version: 6.1.0.0.alpha0+
Build ID: 2d5ce0e1b233c83f91481cd6b9306ac8de7f5ff8
CPU threads: 4; OS: Linux 4.13; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group

@Jim, Should it be closed as RESOLVED FIXED?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116680] Sidebar can't be undocked

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116680

--- Comment #8 from Commit Notification 
 ---
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=6c57ae39d783ae92a43dc2e113ea6e2dfb52af22

tdf#116680 fix sidebar can't undock

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116680] Sidebar can't be undocked

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116680

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.1.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116680] Sidebar can't be undocked

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116680

--- Comment #7 from Jim Raykowski  ---
I confirm this.

Here is a patch:
https://gerrit.libreoffice.org/#/c/52047/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116680] Sidebar can't be undocked

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116680

--- Comment #6 from Xisco Faulí  ---
Created attachment 140939
  --> https://bugs.documentfoundation.org/attachment.cgi?id=140939=edit
screencast

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116680] Sidebar can't be undocked

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116680

--- Comment #5 from Xisco Faulí  ---
dragging and dropping the sidebar decorator on top(In reply to Katarina Behrens
(CIB) from comment #3)
> @Xisco: how are you undocking sidebar?
> 
> Ctrl-doubleclick on some empty space (between widgets)?
> Sidebar config menu (gear icon) and then choosing undock from menu? 
> Drag with LMB pressed?

dragging and dropping the sidebar decorator on top

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116680] Sidebar can't be undocked

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116680

--- Comment #4 from Katarina Behrens (CIB)  ---

> Probably fixed in this branch
> https://cgit.freedesktop.org/libreoffice/core/log/?h=feature/docking_windows

Feature branch is ... well, just that -- a new feature. Once it's merged, users
will be able to undock sidebar by pressing LMB over a grip (just like in
toolbars) and drag'n'drop outside docking area.

But presumably Xisco is referring to some other ways to undock SB (thus my
question above) which no longer work

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116680] Sidebar can't be undocked

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116680

--- Comment #3 from Katarina Behrens (CIB)  ---
@Xisco: how are you undocking sidebar?

Ctrl-doubleclick on some empty space (between widgets)?
Sidebar config menu (gear icon) and then choosing undock from menu? 
Drag with LMB pressed?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116680] Sidebar can't be undocked

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116680

Samuel Mehrbrodt (CIB)  changed:

   What|Removed |Added

 CC||bu...@bubli.org,
   ||s.mehrbr...@gmail.com

--- Comment #2 from Samuel Mehrbrodt (CIB)  ---
Probably fixed in this branch
https://cgit.freedesktop.org/libreoffice/core/log/?h=feature/docking_windows

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116680] Sidebar can't be undocked

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116680

Xisco Faulí  changed:

   What|Removed |Added

   Keywords||bibisected, bisected,
   ||regression
 Status|UNCONFIRMED |NEW
 CC||rayk...@gmail.com,
   ||xiscofa...@libreoffice.org
 Ever confirmed|0   |1

--- Comment #1 from Xisco Faulí  ---
Regression introduced by:

author  Jim Raykowski    2018-02-04 14:12:32 -0900
committer   Samuel Mehrbrodt   2018-02-05
10:40:59 +0100
commit  bcfc348663b04834fe8e6d6315f647be1595469a (patch)
tree31789487672b5577fc1a42294aea7118740b2cda
parent  914a35e8467252da43f864c86b0a820d8c0bd38e (diff)
tdf#115434 Fix key press misbehaviors in sidebar
This patch also is for tdf#98505 and tdf#84657

Bisected with: bibisect-linux64-6.1

Adding Cc: to Jim Raykowski

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs