[Libreoffice-bugs] [Bug 116879] Crash when showing Comment

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116879

Armin Le Grand (CIB)  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |armin.le.gr...@me.com
   |desktop.org |

--- Comment #16 from Armin Le Grand (CIB)  ---
Start is in ScNoteMarker::~ScNoteMarker. It destructs a SdrModel which uses
::ClearModel() which uses ::DeletePage() to destruct the SdrPage(s).
SdrPage is derived from SdrObjList (was already in lo-6-0) which gets deleted
first. That again uses SdrObjList::Clear() which removes and deletes the
SdrObjects from the SdrObjList.

What has changed is that there is no longer a pModel SdrModel* in SdrObjList
that was set to nullptr in SdrObjList::~SdrObjList() in lo-6-0 with the
comment:

// To avoid that the Clear() method will broadcast changes when in
destruction
// which would call virtual method (not allowed in destructor), the model
is set
// to NULL here.

This did change and there is broadcasting now. Not directly a virtual functoin
call, but the broadcasts goes to ScDrawModelBroadcaster::Notify and there
SdrPage::GetUnoPage() is called exactly at the SdrPage that gets destructed.

Thus: Need to find a way not to broadcast in SdrObjList::Clear() when coming
from SdrObjList::~SdrObjList()...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116879] Crash when showing Comment

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116879

Armin Le Grand (CIB)  changed:

   What|Removed |Added

Summary|Crash when showing Comment  |Crash when showing Comment
   |( gtk/gtk3 )|

--- Comment #15 from Armin Le Grand (CIB)  ---
Linux debug version ready, taking a look...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116879] Crash when showing Comment ( gtk/gtk3 )

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116879

--- Comment #14 from Caolán McNamara  ---
gtk2/gtk3 have working accessibilty so its possible that this sort of thing is
an a11y related crash which might appear on turning on windows a11y (however
that's done)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116879] Crash when showing Comment ( gtk/gtk3 )

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116879

Xisco Faulí  changed:

   What|Removed |Added

 CC||caol...@redhat.com
Summary|Crash when showing Comment  |Crash when showing Comment
   ||( gtk/gtk3 )

--- Comment #13 from Xisco Faulí  ---
yep, it doesn't crash with gen, only gtk3 and gtk...

Adding Caolán to the loop as well

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116879] Crash when showing Comment

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116879

Armin Le Grand (CIB)  changed:

   What|Removed |Added

 OS|All |Linux (All)

--- Comment #12 from Armin Le Grand (CIB)  ---
Re-checked, no crash on Windows (Is there a setting like 'not_on_windows'
instead 'on_linux' ?)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116879] Crash when showing Comment

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116879

--- Comment #11 from Armin Le Grand (CIB)  ---
Happens on updated Linux, but not on updated Win -> strange, Win-only crash?
Will again update win version and get Linux-version with debug...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116879] Crash when showing Comment

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116879

--- Comment #10 from Xisco Faulí  ---
(In reply to Armin Le Grand (CIB) from comment #9)
> Could repro on Linux, non-current version. Updating to have fix for
> tdf#117145 included...

Still reproducible in

Version: 6.1.0.0.alpha1+
Build ID: f1579d3d6c5f5f3a651825e035b93bee7a4f43c6
CPU threads: 4; OS: Linux 4.13; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group

with the fix for bug 117145 included...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116879] Crash when showing Comment

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116879

--- Comment #9 from Armin Le Grand (CIB)  ---
Could repro on Linux, non-current version. Updating to have fix for tdf#117145
included...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116879] Crash when showing Comment

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116879

--- Comment #8 from Armin Le Grand (CIB)  ---
Tried to reproduce, but did not happen on Win. Checked the log, too - nothing
obvious. Maybe Linux only...? FGix for tdf#117145 already included in test
version, thuogh.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116879] Crash when showing Comment

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116879

Julien Nabet  changed:

   What|Removed |Added

 CC||buntysurc...@gmail.com

--- Comment #7 from Julien Nabet  ---
*** Bug 117200 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116879] Crash when showing Comment

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116879

Jean-Baptiste Faure  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #6 from Jean-Baptiste Faure  ---
(In reply to Elmar from comment #5)
> How will we know when this has been resolved?

You are subscribed to this bug report, so you will receive a mail when the
status will have been changed to resolved fixed.

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116879] Crash when showing Comment

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116879

Elmar  changed:

   What|Removed |Added

 Status|NEW |UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #5 from Elmar  ---
How will we know when this has been resolved?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116879] Crash when showing Comment

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116879

Xisco Faulí  changed:

   What|Removed |Added

 CC||rob...@iafrica.com

--- Comment #4 from Xisco Faulí  ---
*** Bug 116991 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116879] Crash when showing Comment

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116879

--- Comment #3 from Jean-Baptiste Faure  ---
Ran into this crash when trying to confirm bug 116998 in current master.

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116879] Crash when showing Comment

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116879

Xisco Faulí  changed:

   What|Removed |Added

 Blocks||116979


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=116979
[Bug 116979] [META] Regression introduced by Aw080
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116879] Crash when showing Comment

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116879

--- Comment #2 from Xavier Van Wijmeersch  ---
confirm

Version: 6.1.0.0.alpha0+
Build ID: 2c63fcb0cf10c7ce580545576f2bd40dbcdb61d0
CPU threads: 8; OS: Linux 4.14; UI render: default; VCL: gtk3; 
Locale: nl-BE (en_US.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116879] Crash when showing Comment

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116879

Xisco Faulí  changed:

   What|Removed |Added

   Keywords||haveBacktrace

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116879] Crash when showing Comment

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116879

Xisco Faulí  changed:

   What|Removed |Added

   Keywords||bibisected, bisected,
   ||regression
   Priority|medium  |highest
 Status|UNCONFIRMED |NEW
 CC||armin.le.gr...@me.com,
   ||xiscofa...@libreoffice.org
 Ever confirmed|0   |1
   Severity|normal  |critical

--- Comment #1 from Xisco Faulí  ---
Regression introduced by:

author  Armin Le Grand 2018-03-01 15:54:32
+0100
committer   Armin Le Grand   2018-04-07 00:28:30
+0200
commit  dfefe448c41921f2f1e54d3f69b8b9e89031d055 (patch)
tree1aace31054b5740e2faffcbc5de66a791be27f7d
parent  eba4d5b2b76cefde90cb3d6638c736f435023a45 (diff)
SOSAW080: Added first bunch of basic changes to helpers

Bisected with: bibisect-linux64-6.1

Adding Cc: to Armin Le Grand

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs