[Libreoffice-bugs] [Bug 117308] EDITING Comment box is not resized after Font size change after Save and Open

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117308

Armin Le Grand  changed:

   What|Removed |Added

 CC|armin.le.gr...@me.com   |

--- Comment #11 from Armin Le Grand  ---
This commit was developed for another code base, and not merged by me. For
complex changes like this, side-effects are to be expected; sadly I dont't have
the cycles to deal with all the fallout. Un-Ccing myself for the while.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 117308] EDITING Comment box is not resized after Font size change after Save and Open

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117308

--- Comment #10 from QA Administrators  ---
Dear Emil Tanev,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117308] EDITING Comment box is not resized after Font size change after Save and Open

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117308

--- Comment #9 from QA Administrators  ---
Dear Emil Tanev,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117308] EDITING Comment box is not resized after Font size change after Save and Open

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117308

Buovjaga  changed:

   What|Removed |Added

 CC||armin.le.gr...@me.com
   Keywords|bibisectRequest |bibisected

--- Comment #8 from Buovjaga  ---
Bibisected with 43max. The blamed commit is sort of suspicious, if the resizing
is indeed used by Calc comments as well.

commit 47e19757622969e3de29d64f027bde82741159fa
Author: Matthew Francis 
Date:   Thu May 28 20:31:43 2015 +0800

source-hash-9ee0cf63a1dafebb673fbee9ccfc82a56fd050d4

commit 9ee0cf63a1dafebb673fbee9ccfc82a56fd050d4
Author: Armin Le Grand 
AuthorDate: Thu Sep 19 11:34:41 2013 +
Commit: David Tardon 
CommitDate: Tue Mar 25 09:29:56 2014 +0100

i115391 corected from isLocked to IsPasteResize which was used in
modifiers for CustomShape and TextShape

Adding Cc: to Armin Le Grand
Apologies, if this turns out to be wrong blame.

The current form of the code snippet is

void SdrTextObj::AdaptTextMinSize()
{
if (!bTextFrame)
// Only do this for text frame.
return;

if (getSdrModelFromSdrObject().IsPasteResize())
// Don't do this during paste resize.
return;

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117308] EDITING Comment box is not resized after Font size change after Save and Open

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117308

--- Comment #7 from Marina Latini (CIB)  ---
repro in 
Version: 6.2.0.0.alpha0+
Build ID: e79dd394deedaeed122717700077b77d94360c12
CPU threads: 4; OS: Linux 4.16; UI render: default; VCL: kde4; 
Locale: it-IT (it_IT.UTF-8); Calc: group threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117308] EDITING Comment box is not resized after Font size change after Save and Open

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117308

malboarg  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117308] EDITING Comment box is not resized after Font size change after Save and Open

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117308

malboarg  changed:

   What|Removed |Added

 CC||malbo...@gmail.com

--- Comment #6 from malboarg  ---
This bug is still present in
Version: 6.1.0.0.beta1
Build ID: 8c76dfe1284e211954c30f219b3a38dcdd82f8a0
CPU threads: 2; OS: Linux 4.4; UI render: default; VCL: gtk2; 

This bug is not present in Libreoffice 4.0.0.1 thus it's a regression
Version 4.0.0.1 (Build ID: 527dba6f6e0cfbbc71bd6e7b88a52699bb48799)
Linux Ubuntu 64 bits

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117308] EDITING Comment box is not resized after Font size change after Save and Open

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117308

Buovjaga  changed:

   What|Removed |Added

 Blocks||101216
   Severity|normal  |minor
Version|unspecified |4.3.0.4 release
 OS|Windows (All)   |All
   Keywords||bibisectRequest, regression


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=101216
[Bug 101216] [META] Calc comment bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117308] EDITING Comment box is not resized after Font size change after Save and Open

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117308

--- Comment #5 from Buovjaga  ---
Created attachment 142792
  --> https://bugs.documentfoundation.org/attachment.cgi?id=142792=edit
Example file

(In reply to Emil Tanev from comment #4)
> Well, we seem to be able to do it in the scenario when the file is not
> saved, so why should it be different?

Right, sorry about that. Skipping the "Save the file and Close it" step indeed
lets us see it shrink.

Already in 4.3.0 (on Win), but yet in 3.6.7

Arch Linux 64-bit
Version 3.6.7.2 (Build ID: e183d5b)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117308] EDITING Comment box is not resized after Font size change after Save and Open

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117308

--- Comment #4 from Emil Tanev  ---
Well, we seem to be able to do it in the scenario when the file is not saved,
so why should it be different?

Replayed the steps just in case
Version: 6.1.0.0.beta2+
Build ID: 5e58b203e03fbcf6ca1399954bc01871474c973e
CPU threads: 1; OS: Windows 10.0; UI render: default; 
TinderBox: Win-x86@42, Branch:libreoffice-6-1, Time: 2018-06-16_04:07:37
Locale: ja-JP (ja_JP); Calc: group threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117308] EDITING Comment box is not resized after Font size change after Save and Open

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117308

Emil Tanev  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117308] EDITING Comment box is not resized after Font size change after Save and Open

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117308

Buovjaga  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO
 CC||todven...@suomi24.fi

--- Comment #3 from Buovjaga  ---
To be clear: you want the comment box to shrink, when you change the font size
to 13? I don't know, if this is something we should do automatically...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117308] EDITING Comment box is not resized after Font size change after Save and Open

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117308

--- Comment #2 from Emil Tanev  ---
I meant line 7 in the steps is important to reproduce the bug. I can't seem to
reproduce it without saving and reopening the file.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117308] EDITING Comment box is not resized after Font size change after Save and Open

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117308

raal  changed:

   What|Removed |Added

 CC||r...@post.cz

--- Comment #1 from raal  ---
Version: 6.1.0.0.alpha0+
Build ID: 930a3cbaeeaf6bca594f8651c4d5dffc1e5391d4
CPU threads: 4; OS: Linux 4.4; UI render: default; VCL: gtk3; 

after save and reopen is comment box still big - not resized.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs