[Libreoffice-bugs] [Bug 117994] Font size is too large in attached DOC in Word after roundtrip
https://bugs.documentfoundation.org/show_bug.cgi?id=117994 Justin L changed: What|Removed |Added Depends on|119079 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=119079 [Bug 119079] FILEOPEN DOC: character properties affecting CR, but shouldn't -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 117994] Font size is too large in attached DOC in Word after roundtrip
https://bugs.documentfoundation.org/show_bug.cgi?id=117994 Justin L changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #18 from Justin L --- This reverted 5.1.4 commit 817c3b17fa57a7c4c4f80569bc00a21001fb6807 Another reason for reverting it is bug 150613 whose fix depends on getting this fixed first. Making any export changes based on the formatting of numbering is extremely dangerous, especially in this time period after LO 4.1 when a wonky patch made wild assumptions about what was best. Well, that patch was reverted in LO 7.3 for bug 108518, and apparently obsoletes the usefulness this patch provided... This patch that I reverted caused some visible regressions SEEN ONLY IN WORD which further confirms that we still have lots of wrong assumptions in regards to numbering formatting. I'm happy to see it reverts without causing any unit test failures even before I make any changes. I confirmed that reverting the 4.1 patch with 7.3 commit 343d4d32f00053bd72cfe240125835fe25ce264f was what allowed testTdf99474 to still pass. Yeah - no backporting. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 117994] Font size is too large in attached DOC in Word after roundtrip
https://bugs.documentfoundation.org/show_bug.cgi?id=117994 --- Comment #17 from Commit Notification --- Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/449317473740d98338a61aca1e4ffb8821681c8e tdf#117994 doc: Revert "tdf#99474 close direct char fmt at end of para" It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 117994] Font size is too large in attached DOC in Word after roundtrip
https://bugs.documentfoundation.org/show_bug.cgi?id=117994 Commit Notification changed: What|Removed |Added Whiteboard||target:7.5.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 117994] Font size is too large in attached DOC in Word after roundtrip
https://bugs.documentfoundation.org/show_bug.cgi?id=117994 Justin L changed: What|Removed |Added Blocks||150613 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=150613 [Bug 150613] Format of chapter number changed by format of the last character on the line -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 117994] Font size is too large in attached DOC in Word after roundtrip
https://bugs.documentfoundation.org/show_bug.cgi?id=117994 Justin L changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||9079 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 117994] Font size is too large in attached DOC in Word after roundtrip
https://bugs.documentfoundation.org/show_bug.cgi?id=117994 Justin L changed: What|Removed |Added See Also|https://bugs.documentfounda | |tion.org/show_bug.cgi?id=51 | |129 | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117994] Font size is too large in attached DOC in Word after roundtrip
https://bugs.documentfoundation.org/show_bug.cgi?id=117994 Justin L changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=51 ||129 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117994] Font size is too large in attached DOC in Word after roundtrip
https://bugs.documentfoundation.org/show_bug.cgi?id=117994 --- Comment #15 from QA Administrators --- Dear Aron Budea, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117994] Font size is too large in attached DOC in Word after roundtrip
https://bugs.documentfoundation.org/show_bug.cgi?id=117994 --- Comment #14 from Xisco Faulí --- (In reply to Justin L from comment #13) > (In reply to Xisco Faulí from comment #12) > > So, what's the plan now that the patch has been reverted ? > Please attach a sample document for each of the different issues that you > find. Hi Justin, Sorry for the delay, I've identified two problems: * Hidden fields are displayed on MSO Word after RT ( doc ) - attachment 40533 from bug 31884 - https://bugzilla.abisource.com/attachment.cgi?id=4671 - attachment 95012 from bug 75559 - https://bugzilla.abisource.com/attachment.cgi?id=2376 * Content is displayed as deleted by the tracking changes after RT ( doc ) - attachment 137302 from bug 103967 - https://bugzilla.mozilla.org/attachment.cgi?id=413410 - https://bugzilla.mozilla.org/attachment.cgi?id=521402 Hope it helps... Regards -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117994] Font size is too large in attached DOC in Word after roundtrip
https://bugs.documentfoundation.org/show_bug.cgi?id=117994 --- Comment #13 from Justin L --- (In reply to Xisco Faulí from comment #12) > So, what's the plan now that the patch has been reverted ? Please attach a sample document for each of the different issues that you find. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117994] Font size is too large in attached DOC in Word after roundtrip
https://bugs.documentfoundation.org/show_bug.cgi?id=117994 --- Comment #12 from Xisco Faulí --- Hi Justin, So, what's the plan now that the patch has been reverted ? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117994] Font size is too large in attached DOC in Word after roundtrip
https://bugs.documentfoundation.org/show_bug.cgi?id=117994 Justin L changed: What|Removed |Added Whiteboard|target:6.2.0| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117994] Font size is too large in attached DOC in Word after roundtrip
https://bugs.documentfoundation.org/show_bug.cgi?id=117994 --- Comment #11 from Commit Notification --- Justin Luth committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=21f52dc70e0f74adc559375f560dff969b9498de Revert "tdf#117994 ww8export: extend Chp over CR" It will be available in 6.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117994] Font size is too large in attached DOC in Word after roundtrip
https://bugs.documentfoundation.org/show_bug.cgi?id=117994 Commit Notification changed: What|Removed |Added Whiteboard||target:6.2.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117994] Font size is too large in attached DOC in Word after roundtrip
https://bugs.documentfoundation.org/show_bug.cgi?id=117994 --- Comment #10 from Xisco Faulí --- (In reply to Justin L from comment #9) > (In reply to Xisco Faulí from comment #8) > > I found some regressions introduced > > by 091aedc63de2f6c8f0f4c60dd1fa93fe4c6ddde4. What should I do with them? > Add a few examples to this document, especially if the problem manifests > itself in a different way. > > > What is the reason behind pushing a patch that will be reverted one month > > later? IMHO, this shouldn't have been done unless there is a good reason to > > do so... > This area is extremely dangerous to work in (as evidenced by Caolan ignoring > an old regression that accumulated tons of varied examples), so although the > fix seemed good on all the documents I tested, and passed existing unit > tests, I don't trust it. Plus, once it is reverted, it will provide examples > of things it fixed, but are now "broken" again. Ok, fair enough. What about not reverting it and fixing the regression instead? In any other case, it's the usual workflow. So far I've found 2 different issues but I haven't checked all the results yet.I would prefer to report them separately, otherwise this bug would end up being a mess... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117994] Font size is too large in attached DOC in Word after roundtrip
https://bugs.documentfoundation.org/show_bug.cgi?id=117994 --- Comment #9 from Justin L --- (In reply to Xisco Faulí from comment #8) > I found some regressions introduced > by 091aedc63de2f6c8f0f4c60dd1fa93fe4c6ddde4. What should I do with them? Add a few examples to this document, especially if the problem manifests itself in a different way. > What is the reason behind pushing a patch that will be reverted one month > later? IMHO, this shouldn't have been done unless there is a good reason to > do so... This area is extremely dangerous to work in (as evidenced by Caolan ignoring an old regression that accumulated tons of varied examples), so although the fix seemed good on all the documents I tested, and passed existing unit tests, I don't trust it. Plus, once it is reverted, it will provide examples of things it fixed, but are now "broken" again. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117994] Font size is too large in attached DOC in Word after roundtrip
https://bugs.documentfoundation.org/show_bug.cgi?id=117994 --- Comment #8 from Xisco Faulí --- (In reply to Justin L from comment #7) > (In reply to Commit Notification from comment #6) > Temporary patch - this issue is not yet fixed because that patch will be > reverted in a month. Hi Justin, Using the office-interoperability-tools, I found some regressions introduced by 091aedc63de2f6c8f0f4c60dd1fa93fe4c6ddde4. What should I do with them? What is the reason behind pushing a patch that will be reverted one month later? IMHO, this shouldn't have been done unless there is a good reason to do so... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117994] Font size is too large in attached DOC in Word after roundtrip
https://bugs.documentfoundation.org/show_bug.cgi?id=117994 Justin L changed: What|Removed |Added Whiteboard|target:6.2.0| --- Comment #7 from Justin L --- (In reply to Commit Notification from comment #6) Temporary patch - this issue is not yet fixed because that patch will be reverted in a month. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117994] Font size is too large in attached DOC in Word after roundtrip
https://bugs.documentfoundation.org/show_bug.cgi?id=117994 --- Comment #6 from Commit Notification --- Justin Luth committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=091aedc63de2f6c8f0f4c60dd1fa93fe4c6ddde4 tdf#117994 ww8export: extend Chp over CR It will be available in 6.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117994] Font size is too large in attached DOC in Word after roundtrip
https://bugs.documentfoundation.org/show_bug.cgi?id=117994 Commit Notification changed: What|Removed |Added Whiteboard||target:6.2.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117994] Font size is too large in attached DOC in Word after roundtrip
https://bugs.documentfoundation.org/show_bug.cgi?id=117994 --- Comment #5 from Justin L --- Created attachment 143965 --> https://bugs.documentfoundation.org/attachment.cgi?id=143965=edit analyze117994.doc : bugs tested and the results - table list Other than one unit test (which looks better in Word, but worse in LO), the patch seems to be helpful, but not destructive. I'm planning to temporarily merge into master to see if any regressions are noticed, and then remove it again within a month. patch in gerrit: https://gerrit.libreoffice.org/58594 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117994] Font size is too large in attached DOC in Word after roundtrip
https://bugs.documentfoundation.org/show_bug.cgi?id=117994 Justin L changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=10 ||2334 Depends on||119079 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=119079 [Bug 119079] FILEOPEN DOC: character properties affecting CR, but shouldn't -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117994] Font size is too large in attached DOC in Word after roundtrip
https://bugs.documentfoundation.org/show_bug.cgi?id=117994 --- Comment #4 from Justin L --- Created attachment 143951 --> https://bugs.documentfoundation.org/attachment.cgi?id=143951=edit tdf117994_fixAttempt.patch - a keep-changing-things-until-somehow-it-all-works patch So, Luke's idea that after the CR, you "force" the CR to be included in the previous character attributes seems to be right. Before, I think large.doc "just happened" to look OK, because the following sentence used the same formatting. The reason Luke's patch worked only with his example is because he was working with an IsEmptySprm, which just got extended like he wanted. In this bug's case, there is an existing character format SPRM which triggers a new, empty, character format being created just for the CR. So, my patch changes the logic of "force", so that it doesn't just ensure that a mark is made, but that it specifically extends the existing character format to include this position. (I hope that still works as intended for the other existing use of "force" in redlining.) There really are two problems in this bug report. The one is import related - since LO doesn't show the LARGE spacing that Word does. And unfortunately, bug 102334's unit test likely hits that same problem because ww8export complains about hidden text showing up after this patch, but when opening the file in Word, the text is still hidden. So, first things first I guess, and that is to investigate the import bug. But anyone is welcome to check this export patch and tell me what regressions it will cause :-). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117994] Font size is too large in attached DOC in Word after roundtrip
https://bugs.documentfoundation.org/show_bug.cgi?id=117994 Justin L changed: What|Removed |Added CC||jl...@mail.com --- Comment #3 from Justin L --- attachment 124593 from the regression-causing bug 99474 is very interesting because it is a very similar document (numbering) and yet it requires the complete opposite of this bug in terms of OutputFKP(true/false). >From what I can see, "large.doc" wants NO FKP at all, while "testcase.odt" needs to have a forced FKP somewhere/anywhere. Best guess at the moment is because up until this point, there has been no character formatting at all until the red attribute? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117994] Font size is too large in attached DOC in Word after roundtrip
https://bugs.documentfoundation.org/show_bug.cgi?id=117994 Aron Budea changed: What|Removed |Added Blocks|112681, 112753 |118900 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=112681 [Bug 112681] [META] DOC (binary) character-related issues https://bugs.documentfoundation.org/show_bug.cgi?id=112753 [Bug 112753] [META] DOC (binary) style bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=118900 [Bug 118900] [META] Issues related to direct formatting in DOC (binary) bullet and numbering list -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117994] Font size is too large in attached DOC in Word after roundtrip
https://bugs.documentfoundation.org/show_bug.cgi?id=117994 Mike Kaganski changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||7923 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117994] Font size is too large in attached DOC in Word after roundtrip
https://bugs.documentfoundation.org/show_bug.cgi?id=117994 Mike Kaganski changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=99 ||474 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117994] Font size is too large in attached DOC in Word after roundtrip
https://bugs.documentfoundation.org/show_bug.cgi?id=117994 Xisco Faulí changed: What|Removed |Added Keywords||bibisected, bisected, ||regression CC||l...@deller.id.au, ||xiscofa...@libreoffice.org Version|6.1.0.0.beta1+ |5.2 all versions Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #2 from Xisco Faulí --- Regression introduced by: author Luke Deller 2016-04-27 02:09:48 +1000 committer Miklos Vajna 2016-04-27 15:17:22 + commit 817c3b17fa57a7c4c4f80569bc00a21001fb6807 (patch) treee0f3a1604313624c4688df2626be897f9bbff577 parent 99ea437f7570ab59f186583f368398919db67c3a (diff) tdf#99474 close direct char fmt at end of para When exporting to doc, ensure that the FKP entry for direct character formatting is closed at the end of a paragraph, so that any direct character formatting in the next paragraph does not apply to the end-of-paragraph marker (CR). Also revert the changes for i#119650 and tdf#87437 which targetted more specific examples of this problem, as those issues should now be covered by this fix. Add a test case for the example from tdf#99474 Bisected with: bibisect-linux-64-5.2 Adding Cc: to Luke Deller -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117994] Font size is too large in attached DOC in Word after roundtrip
https://bugs.documentfoundation.org/show_bug.cgi?id=117994 --- Comment #1 from Aron Budea --- Created attachment 142515 --> https://bugs.documentfoundation.org/attachment.cgi?id=142515=edit Before-after comparison screenshot -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
