[Libreoffice-bugs] [Bug 119190] Protecting sheets removes the all cell comments in LibreOffice Calc if the file format had been given as 'xlsx'
https://bugs.documentfoundation.org/show_bug.cgi?id=119190 --- Comment #16 from Commit Notification --- Xisco Fauli committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/224026a38ddc4008d1c73fa1ba95f672f03fac63 tdf#119190: sc_subsequent_filters_test2: Add unittest It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 119190] Protecting sheets removes the all cell comments in LibreOffice Calc if the file format had been given as 'xlsx'
https://bugs.documentfoundation.org/show_bug.cgi?id=119190 Commit Notification changed: What|Removed |Added Whiteboard||target:7.3.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 119190] Protecting sheets removes the all cell comments in LibreOffice Calc if the file format had been given as 'xlsx'
https://bugs.documentfoundation.org/show_bug.cgi?id=119190 Xisco Faulí changed: What|Removed |Added Status|RESOLVED|VERIFIED --- Comment #15 from Xisco Faulí --- (In reply to Justin L from comment #14) > Unfortunately, I hadn't bothered to first check if this was still a problem. > comment have been importing since 6.4.0.2. > > authorNoel Grandin on 2020-01-01 09:37:37 +0100 > commit4992d61600536fe14b97b718dbb11f00e936c6a9 > tdf#129228 speedup opening of xlsx file with lots of comments I do confirm it. Nice finding. Unittest added in https://gerrit.libreoffice.org/c/core/+/125874 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 119190] Protecting sheets removes the all cell comments in LibreOffice Calc if the file format had been given as 'xlsx'
https://bugs.documentfoundation.org/show_bug.cgi?id=119190 Justin L changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED CC||noelgran...@gmail.com See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||9228 --- Comment #14 from Justin L --- Unfortunately, I hadn't bothered to first check if this was still a problem. comment have been importing since 6.4.0.2. author Noel Grandin on 2020-01-01 09:37:37 +0100 commit 4992d61600536fe14b97b718dbb11f00e936c6a9 tdf#129228 speedup opening of xlsx file with lots of comments -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 119190] Protecting sheets removes the all cell comments in LibreOffice Calc if the file format had been given as 'xlsx'
https://bugs.documentfoundation.org/show_bug.cgi?id=119190 --- Comment #13 from Justin L --- LO 3.6 round-tripping attachment 156241: no comments exported, not protected. LO 4.0: comment exported/imported, not protected. Opens XLSX attachment 156242 as protected though (and of course no comment). So comment EXPORT support first came in the 4.0 range https://cgit.freedesktop.org/libreoffice/core/log/?id=3238606c8470f3eaeada3fc601e186ec5cfac925=range=f9a453fb01908e16032abdbf1f895666e1d260a6..20d4cd5e08c1400fcc5ae5eb45861f429b914969=50 P.S. LO 3.5 can read the non-protected comments generated by LO 4.0. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 119190] Protecting sheets removes the all cell comments in LibreOffice Calc if the file format had been given as 'xlsx'
https://bugs.documentfoundation.org/show_bug.cgi?id=119190 Justin L changed: What|Removed |Added CC||jl...@mail.com Hardware|x86-64 (AMD64) |All -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 119190] Protecting sheets removes the all cell comments in LibreOffice Calc if the file format had been given as 'xlsx'
https://bugs.documentfoundation.org/show_bug.cgi?id=119190 Aron Budea changed: What|Removed |Added CC||ba...@caesar.elte.hu Blocks|101216 |127172 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=101216 [Bug 101216] [META] Calc comment bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=127172 [Bug 127172] [META] XLSX (OOXML) Comments related issues -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119190] Protecting sheets removes the all cell comments in LibreOffice Calc if the file format had been given as 'xlsx'
https://bugs.documentfoundation.org/show_bug.cgi?id=119190 Xisco Faulí changed: What|Removed |Added Keywords||dataLoss -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119190] Protecting sheets removes the all cell comments in LibreOffice Calc if the file format had been given as 'xlsx'
https://bugs.documentfoundation.org/show_bug.cgi?id=119190 --- Comment #12 from NISZ LibreOffice Team --- Created attachment 156243 --> https://bugs.documentfoundation.org/attachment.cgi?id=156243=edit Excel made file opened in Excel and Calc -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119190] Protecting sheets removes the all cell comments in LibreOffice Calc if the file format had been given as 'xlsx'
https://bugs.documentfoundation.org/show_bug.cgi?id=119190 --- Comment #10 from NISZ LibreOffice Team --- Created attachment 156241 --> https://bugs.documentfoundation.org/attachment.cgi?id=156241=edit Password protected ods with comment password is: hello -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119190] Protecting sheets removes the all cell comments in LibreOffice Calc if the file format had been given as 'xlsx'
https://bugs.documentfoundation.org/show_bug.cgi?id=119190 --- Comment #11 from NISZ LibreOffice Team --- Created attachment 156242 --> https://bugs.documentfoundation.org/attachment.cgi?id=156242=edit Password protected xlsx with comment password is: hello -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119190] Protecting sheets removes the all cell comments in LibreOffice Calc if the file format had been given as 'xlsx'
https://bugs.documentfoundation.org/show_bug.cgi?id=119190 --- Comment #9 from NISZ LibreOffice Team --- Created attachment 156240 --> https://bugs.documentfoundation.org/attachment.cgi?id=156240=edit Example ods made in Calc, saved as xlsx then opened in Excel -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119190] Protecting sheets removes the all cell comments in LibreOffice Calc if the file format had been given as 'xlsx'
https://bugs.documentfoundation.org/show_bug.cgi?id=119190 --- Comment #8 from NISZ LibreOffice Team --- This looks more like an import time problem: - Excel-made xlsx file with comment is opened without comment in Calc - Calc-made xlsx file with comment is opened with comment in Excel but without comment in Calc. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119190] Protecting sheets removes the all cell comments in LibreOffice Calc if the file format had been given as 'xlsx'
https://bugs.documentfoundation.org/show_bug.cgi?id=119190 Timur changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=64 ||753 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119190] Protecting sheets removes the all cell comments in LibreOffice Calc if the file format had been given as 'xlsx'
https://bugs.documentfoundation.org/show_bug.cgi?id=119190 Timur changed: What|Removed |Added Severity|normal |major Priority|medium |high -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119190] Protecting sheets removes the all cell comments in LibreOffice Calc if the file format had been given as 'xlsx'
https://bugs.documentfoundation.org/show_bug.cgi?id=119190 Timur changed: What|Removed |Added CC||theo.ra...@orange.fr --- Comment #7 from Timur --- *** Bug 129053 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119190] Protecting sheets removes the all cell comments in LibreOffice Calc if the file format had been given as 'xlsx'
https://bugs.documentfoundation.org/show_bug.cgi?id=119190 raal changed: What|Removed |Added CC||noel.po...@gmail.com, ||r...@post.cz Keywords|bibisectRequest |bibisected, bisected --- Comment #6 from raal --- This seems to have begun at the below commit. Adding Cc: to Noel Power ; Could you possibly take a look at this one? Thanks 1dd01719cbf3c784715206f9c204705d1b8c31ad is the first bad commit commit 1dd01719cbf3c784715206f9c204705d1b8c31ad Author: Matthew Francis Date: Sat Sep 5 19:31:33 2015 +0800 source-hash-8ce1124359783df750d176b8390b4eb0f54fb6ba commit 8ce1124359783df750d176b8390b4eb0f54fb6ba Author: Noel Power AuthorDate: Thu Aug 1 14:29:34 2013 +0100 Commit: Noel Power CommitDate: Thu Aug 1 16:59:22 2013 +0100 2nd step to export SheetProtection fdo#64753, actually export the data Change-Id: Id9fa1f9b917f9df8ca0ead02dfd5405388039b4b -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119190] Protecting sheets removes the all cell comments in LibreOffice Calc if the file format had been given as 'xlsx'
https://bugs.documentfoundation.org/show_bug.cgi?id=119190 --- Comment #5 from himajin100...@gmail.com --- https://opengrok.libreoffice.org/xref/core/sc/source/filter/oox/workbookfragment.cxx?r=f87be145#497 https://opengrok.libreoffice.org/xref/core/sc/source/filter/oox/worksheethelper.cxx?r=60bc2635#1567 https://opengrok.libreoffice.org/xref/core/sc/source/filter/oox/worksheethelper.cxx?r=60bc2635#959 https://opengrok.libreoffice.org/xref/core/sc/source/filter/oox/worksheethelper.cxx?r=60bc2635#1328 https://opengrok.libreoffice.org/xref/core/sc/source/filter/oox/commentsbuffer.cxx?r=3e1d3c25#202 Note: CommentsFragment, CommentsBuffer , Comment are all different. Calling importOoxFragment here will not directly trigger Comment::finalizeImport , but tries to call CommentsFragment::finalizeImport, which is just the (empty) inherited method(FragmentHandler2::finalizeImport(). So we don't need to worry about the following code. https://opengrok.libreoffice.org/xref/core/sc/source/filter/oox/worksheetfragment.cxx?r=f87be145#353 https://opengrok.libreoffice.org/xref/core/sc/source/filter/oox/workbookfragment.cxx?r=f87be145#437 https://opengrok.libreoffice.org/xref/core/sc/source/filter/oox/workbookfragment.cxx?r=f87be145#480 https://opengrok.libreoffice.org/xref/core/sc/source/filter/oox/workbookfragment.cxx?r=f87be145#334 https://opengrok.libreoffice.org/xref/core/sc/source/filter/oox/workbookfragment.cxx?r=f87be145#256 https://opengrok.libreoffice.org/xref/core/sc/source/filter/oox/workbookhelper.cxx?r=fabbeb7a#958 https://opengrok.libreoffice.org/xref/core/oox/source/core/xmlfilterbase.cxx?r=60bc2635#338 etc. and the code eventually calls https://opengrok.libreoffice.org/xref/core/sc/source/filter/oox/worksheetfragment.cxx?r=f87be145#638 https://opengrok.libreoffice.org/xref/core/sc/source/filter/oox/worksheethelper.cxx?r=60bc2635#1562 https://opengrok.libreoffice.org/xref/core/sc/source/filter/oox/worksheethelper.cxx?r=60bc2635#947 as importSheetFragments comes before (*aIt)->finalizeDrawingImport() in WorkbookFragment::finalizeImport(), comment is not added to the protected sheets. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119190] Protecting sheets removes the all cell comments in LibreOffice Calc if the file format had been given as 'xlsx'
https://bugs.documentfoundation.org/show_bug.cgi?id=119190 himajin100...@gmail.com changed: What|Removed |Added CC||himajin100...@gmail.com --- Comment #4 from himajin100...@gmail.com --- https://opengrok.libreoffice.org/xref/core/sc/source/filter/oox/commentsbuffer.cxx?r=3e1d3c25#139 https://opengrok.libreoffice.org/xref/core/sc/source/ui/unoobj/docuno.cxx?r=a6a5064c#4368 https://opengrok.libreoffice.org/xref/core/sc/source/ui/docshell/docfunc.cxx?r=206b5b26#1249 https://opengrok.libreoffice.org/xref/core/sc/source/filter/oox/commentsbuffer.cxx?r=3e1d3c25#145 https://opengrok.libreoffice.org/xref/core/sc/source/filter/oox/commentsbuffer.cxx?r=3e1d3c25#177 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119190] Protecting sheets removes the all cell comments in LibreOffice Calc if the file format had been given as 'xlsx'
https://bugs.documentfoundation.org/show_bug.cgi?id=119190 Xisco Faulí changed: What|Removed |Added Keywords||bibisectRequest, regression CC||xiscofa...@libreoffice.org Version|6.1.0.3 release |4.2 all versions --- Comment #3 from Xisco Faulí --- I can reproduce it back to Version: 4.2.0.0.alpha1+ Build ID: fc8f44e82de4ebdd50ac5fbb9207cd1a59a927e3 but not in Version: 4.1.0.0.alpha1+ Build ID: a2c9d4f8bbde97f175bae4df771273a61251f40 it needs to be bisected with bibisect-42max repo -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119190] Protecting sheets removes the all cell comments in LibreOffice Calc if the file format had been given as 'xlsx'
https://bugs.documentfoundation.org/show_bug.cgi?id=119190 Mike Kaganski changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #2 from Mike Kaganski --- Repro with Version: 6.1.0.3 (x64) Build ID: efb621ed25068d70781dc026f7e9c5187a4decd1 CPU threads: 12; OS: Windows 10.0; UI render: GL; Locale: ru-RU (ru_RU); Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119190] Protecting sheets removes the all cell comments in LibreOffice Calc if the file format had been given as 'xlsx'
https://bugs.documentfoundation.org/show_bug.cgi?id=119190 --- Comment #1 from efkan --- Related question on https://ask.libreoffice.org https://ask.libreoffice.org/en/question/162501/protecting-sheets-removes-the-all-cell-comments-libreoffice-calc-file-format-xlsx/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
