[Libreoffice-bugs] [Bug 119191] FILEOPEN, FILESAVE The object rotates and switches position to a different cell everytime I Open/Close again.
https://bugs.documentfoundation.org/show_bug.cgi?id=119191 raal changed: What|Removed |Added Status|UNCONFIRMED |NEW Summary|FILEOPEN, FILESAVE |FILEOPEN, FILESAVE The ||object rotates and switches ||position to a different ||cell everytime I Open/Close ||again. CC||noelgran...@gmail.com, ||r...@post.cz Ever confirmed|0 |1 Keywords||bibisected, bisected, ||regression --- Comment #3 from raal --- This seems to have begun at the below commit. Adding Cc: to Noel Grandin ; Could you possibly take a look at this one? Thanks 95a48f86905ae970b3f12d05fa74d9c7787a8eb8 is the first bad commit commit 95a48f86905ae970b3f12d05fa74d9c7787a8eb8 Author: Matthew Francis Date: Fri Sep 18 10:34:13 2015 +0800 source-hash-f3ceb0be8805657a3b886509ac255128a11b5974 commit f3ceb0be8805657a3b886509ac255128a11b5974 Author: Noel Grandin AuthorDate: Wed Feb 20 13:43:03 2013 +0200 Commit: Noel Grandin CommitDate: Wed Feb 20 13:43:03 2013 +0200 fixup class vs. constructor definition Change-Id: Idab639141a989bc9752df67b083a5d6e1e01ac37 :04 04 f1ff2d173615d477227c06317ba4ec2c47dc1ab8 73e5eed929c3453eb967eed34c8e5fa36c2f19e4 M opt -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119191] FILEOPEN, FILESAVE The object rotates and switches position to a different cell everytime I Open/Close again.
https://bugs.documentfoundation.org/show_bug.cgi?id=119191 --- Comment #4 from Noel Grandin --- @raal are you sure about that, that's a KDE-specific commit? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119191] FILEOPEN, FILESAVE The object rotates and switches position to a different cell everytime I Open/Close again.
https://bugs.documentfoundation.org/show_bug.cgi?id=119191 --- Comment #5 from QA Administrators --- Dear wawa, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119191] FILEOPEN, FILESAVE The object rotates and switches position to a different cell everytime I Open/Close again.
https://bugs.documentfoundation.org/show_bug.cgi?id=119191
Regina Henschel changed:
What|Removed |Added
CC||rb.hensc...@t-online.de
--- Comment #6 from Regina Henschel ---
The problem still exists in Version: 6.5.0.0.alpha0+ (x64)
Build ID: 3a8d16ba8ca7ef7349e893f2bf1c7e12d9a8d7ae
CPU threads: 8; OS: Windows 10.0 Build 18362; UI render: default; VCL: win;
Locale: de-DE (en_US); UI-Language: en-US
Calc: CL
The problem is triggered in drw.layer.cxx#1041 with the call
pObj->SetSnapRect(rData.getShapeRect());
The error itself is in svdoashp.cxx#1464
void SdrObjCustomShape::NbcSetLogicRect( const tools::Rectangle& rRect )
{
maRect = rRect;
ImpJustifyRect(maRect);
InvalidateRenderGeometry();
AdaptTextMinSize();
SetRectsDirty();
SetChanged();
}
Here the to be "Snap"-Rectangle rRect is directly copied to maRect, which is
the "Logic"-Rectangle of the custom shape. A "Logic"-Rectangle is the rectangle
of the shape without rotation and shearing and "Snap"-Rectangle is including
rotation ans shearing.
We had some discussion, see
https://lists.freedesktop.org/archives/libreoffice/2019-November/083710.html
I thought it would be possible to solve it, by changing the callers to use a
logic rectangle as input and have adapted two places. But it seems, there exist
much more situations. So I need to re-think, how to solve the problems directly
in SdrObjCustomShape::NbcSetLogicRect.
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119191] FILEOPEN, FILESAVE The object rotates and switches position to a different cell everytime I Open/Close again.
https://bugs.documentfoundation.org/show_bug.cgi?id=119191
--- Comment #7 from Regina Henschel ---
Ups, wrong quote, here the correct one from line #1441:
void SdrObjCustomShape::NbcSetSnapRect( const tools::Rectangle& rRect )
{
maRect = rRect;
ImpJustifyRect(maRect);
InvalidateRenderGeometry();
AdaptTextMinSize();
ImpCheckShear();
SetRectsDirty();
SetChanged();
}
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119191] FILEOPEN, FILESAVE The object rotates and switches position to a different cell everytime I Open/Close again.
https://bugs.documentfoundation.org/show_bug.cgi?id=119191 Regina Henschel changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |rb.hensc...@t-online.de |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
