[Libreoffice-bugs] [Bug 120175] Breeze Dark icon theme is not detected as the preferred theme
https://bugs.documentfoundation.org/show_bug.cgi?id=120175 --- Comment #8 from Commit Notification --- Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-6-1": http://cgit.freedesktop.org/libreoffice/core/commit/?id=2e4e28004439c9d0cdd6414fbda6d41c0c000a42=libreoffice-6-1 Resolves: tdf#120175 normalize theme names to our naming scheme It will be available in 6.1.3. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120175] Breeze Dark icon theme is not detected as the preferred theme
https://bugs.documentfoundation.org/show_bug.cgi?id=120175 Commit Notification changed: What|Removed |Added Whiteboard|target:6.2.0|target:6.2.0 target:6.1.3 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120175] Breeze Dark icon theme is not detected as the preferred theme
https://bugs.documentfoundation.org/show_bug.cgi?id=120175 V Stuart Foote changed: What|Removed |Added Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120175] Breeze Dark icon theme is not detected as the preferred theme
https://bugs.documentfoundation.org/show_bug.cgi?id=120175 Alex changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 --- Comment #7 from Alex --- (In reply to V Stuart Foote from comment #6) > @Alex, as OP the NEEDINFO is to you. Please test with a nightly of > master/6.2.0 to verify the hyphenated theme is correctly picked up and gets > the right icons. I tested both Breeze Dark and Karasa Jaga, and they both now get picked up as the default. Thank you both for the fix. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120175] Breeze Dark icon theme is not detected as the preferred theme
https://bugs.documentfoundation.org/show_bug.cgi?id=120175 V Stuart Foote changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #6 from V Stuart Foote --- @Alex, as OP the NEEDINFO is to you. Please test with a nightly of master/6.2.0 to verify the hyphenated theme is correctly picked up and gets the right icons. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120175] Breeze Dark icon theme is not detected as the preferred theme
https://bugs.documentfoundation.org/show_bug.cgi?id=120175 --- Comment #5 from Caolán McNamara --- Feedback if that makes a difference welcome -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120175] Breeze Dark icon theme is not detected as the preferred theme
https://bugs.documentfoundation.org/show_bug.cgi?id=120175 --- Comment #4 from Commit Notification --- Caolán McNamara committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=f317a3de7473de5e6366ba4f2a4aa0ca25cdfdc1 Resolves: tdf#120175 normalize theme names to our naming scheme It will be available in 6.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120175] Breeze Dark icon theme is not detected as the preferred theme
https://bugs.documentfoundation.org/show_bug.cgi?id=120175 Commit Notification changed: What|Removed |Added Whiteboard||target:6.2.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120175] Breeze Dark icon theme is not detected as the preferred theme
https://bugs.documentfoundation.org/show_bug.cgi?id=120175 --- Comment #3 from Caolán McNamara --- I propose simply https://gerrit.libreoffice.org/#/c/61321/ i.e. replace "-" in incoming theme names with "_", which I imagine (breeze dark is unavailable to me to test) would solve the problem -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120175] Breeze Dark icon theme is not detected as the preferred theme
https://bugs.documentfoundation.org/show_bug.cgi?id=120175 agram...@gmail.com changed: What|Removed |Added Blocks||106228 --- Comment #2 from agram...@gmail.com --- (In reply to V Stuart Foote from comment #1) > OK, so "BREEZE_DARK_ID" is set [1] to "breeze_dark" with the underscore. If > it benefits the KDE 5 Plasma DE users, should be a 1 character change, why > not? Is the usage of underscores in the theme ID because of [1]? > But then SIFR_DARK_ID also gets the underscore with our naming, as does the > new KARASA_JAGA_ID theme. Any benefit to also change those for consistency > of matching external DE when calling IconThemeSelector() going forward? I don't know about SIFR, but it looks like Karasa Jaga suffers from the same issue as Breeze Dark, because the upstream Karasa Jaga theme is named "Karasa-Jaga" [2]. =-ref= [1] https://opengrok.libreoffice.org/xref/core/icon-themes/README#23-26 [2] https://github.com/rizmut/karasa-jaga-icon-theme/blob/72054b010a21d46a261d3a1599d0ee4689f41e46/install-karasa-jaga.sh#L25 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=106228 [Bug 106228] [META] Icon theme issues -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120175] Breeze Dark icon theme is not detected as the preferred theme
https://bugs.documentfoundation.org/show_bug.cgi?id=120175 V Stuart Foote changed: What|Removed |Added CC||caol...@redhat.com, ||vstuart.fo...@utsa.edu --- Comment #1 from V Stuart Foote --- OK, so "BREEZE_DARK_ID" is set [1] to "breeze_dark" with the underscore. If it benefits the KDE 5 Plasma DE users, should be a 1 character change, why not? But then SIFR_DARK_ID also gets the underscore with our naming, as does the new KARASA_JAGA_ID theme. Any benefit to also change those for consistency of matching external DE when calling IconThemeSelector() going forward? =-ref-= [1] https://opengrok.libreoffice.org/xref/core/vcl/source/app/IconThemeInfo.cxx?a=true=23#23 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
