[Libreoffice-bugs] [Bug 120550] Draw - Changes to table size "Optimal" features need documentation
https://bugs.documentfoundation.org/show_bug.cgi?id=120550 Justin L changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 120550] Draw - Changes to table size "Optimal" features need documentation
https://bugs.documentfoundation.org/show_bug.cgi?id=120550 sdc.bla...@youmail.dk changed: What|Removed |Added Status|ASSIGNED|NEW Assignee|sdc.bla...@youmail.dk |libreoffice-b...@lists.free ||desktop.org --- Comment #19 from sdc.bla...@youmail.dk --- Unfortunately the patches that were made for master was not cherry-picked for LO 7.4, even though they were ready before the string freeze. So, at present, the updated help is now committed to master, but as I understand, there may be changes coming to how "optimize column" will work, which will require updates to the help in master, so I will leave this ticket open, because the "status quo" has not changed in relation to the help available to users. Unassigning myself. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 120550] Draw - Changes to table size "Optimal" features need documentation
https://bugs.documentfoundation.org/show_bug.cgi?id=120550 sdc.bla...@youmail.dk changed: What|Removed |Added Status|NEEDINFO|ASSIGNED Assignee|libreoffice-b...@lists.free |sdc.bla...@youmail.dk |desktop.org | --- Comment #16 from sdc.bla...@youmail.dk --- This patch addresses all the relevant commands for Draw / Impress https://gerrit.libreoffice.org/c/help/+/135002 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 120550] Draw - Changes to table size "Optimal" features need documentation
https://bugs.documentfoundation.org/show_bug.cgi?id=120550 --- Comment #15 from Commit Notification --- Seth Chaiklin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/f2d2334b032780d97f7a95aacb8283008e91c529 tdf#121367 (related: tdf#120550) consistent labeling between modules It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 120550] Draw - Changes to table size "Optimal" features need documentation
https://bugs.documentfoundation.org/show_bug.cgi?id=120550 Commit Notification changed: What|Removed |Added Whiteboard||target:7.4.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 120550] Draw - Changes to table size "Optimal" features need documentation
https://bugs.documentfoundation.org/show_bug.cgi?id=120550 --- Comment #14 from Justin L --- (In reply to sdc.blanco from comment #11) > Does that sound right? It has been a while since I did this. Probably the only way to be accurate is to test all kinds of situations and see what actually happens. I assume that testing and confirming is already a large part of the documentation role. > 1. Minimal column: DOES grow table for Writer; DOES NOT grow for Draw Correct. Confirmed by testing in 7.4. > 2. Optimal column DOES grow table for Writer; DOES > NOT grow for Draw? Correct. Confirmed by testing. > 3. What does "if space is available" mean in this context? Up to 100% relative size of a table - fitting in the text margins. (Same idea in a frame.) > Will the top border of the table ever move up in the page, or is the space > always added at the end of the table? It always grows downward. I don't think that needs to be mentioned because that is the natural experience with tables as you add content etc. (In reply to sdc.blanco from comment #13) > Actual: table grows > Expected: (according to help): table shrinks. This is a bit of an extreme example. Minimal is a "fit to contents and nothing more". In your case you minimized the table below "fit to content" status, and thus it grew. Basically, minimize just gets rid of excess space. > But ... I did try to use the "Minimal" commands, and got an unexpected > result -- have attached the .odg, with a description of what I did, It works until 7.0.4. This is bug 139511. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 120550] Draw - Changes to table size "Optimal" features need documentation
https://bugs.documentfoundation.org/show_bug.cgi?id=120550 --- Comment #13 from sdc.bla...@youmail.dk --- Created attachment 180419 --> https://bugs.documentfoundation.org/attachment.cgi?id=180419=edit Draw document with attempt to use Minimal Row Height In Writer "Minimize row height: Adjusts the height of the selected rows to fit the content, causing the table to shrink. " Counter-demonstration to "causing the table to shrink" (or demonstration of my misunderstanding). 2 x 2 table 48 pt size text | 12 pt size text 12 pt size text | 12 pt size text 1. Cursor in first row 2. Right-click Size > Row Height 3. unclick "Fit to Size", set Height to 1cm 4. Select the two rows, right-click Size > Minimal Row Height Actual: table grows Expected: (according to help): table shrinks. I also tried in Draw -- but could not see that I can set Row Height (steps 2 and 3), so maybe this will not be an issue in Draw. But ... I did try to use the "Minimal" commands, and got an unexpected result -- have attached the .odg, with a description of what I did, what I expected, and what I got. (not claiming any misbehavior in Draw -- just seeking to gain a proper understanding). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 120550] Draw - Changes to table size "Optimal" features need documentation
https://bugs.documentfoundation.org/show_bug.cgi?id=120550 --- Comment #12 from sdc.bla...@youmail.dk --- > >.uno:SetMinimalRowHeight and uno:SetMinimalColumnWidth > Yes, these ought to be the same wording. Probably "minimal" to match "optimal" https://gerrit.libreoffice.org/c/core/+/135005 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 120550] Draw - Changes to table size "Optimal" features need documentation
https://bugs.documentfoundation.org/show_bug.cgi?id=120550 --- Comment #11 from sdc.bla...@youmail.dk --- (In reply to Justin L from comment #10) Thanks for clear answers, which help to define the scope of what is needed. Now to more forward with the actual descriptions. Comparing c22 (from Comment 0 here) (for Draw) and c23 and c23 (from Comment 1) here, plus bug 121367, comment 1 (for Writer): I see only one clear difference: Minimize Column Width. (in fact, your descriptions are identical for Draw and Writer, but then you add a note explaining "selected cells" (for Writer) vs. "entire column" for Draw -- will try to convey this difference.) Does that sound right? -- that the differences between Writer and Draw are in relation to "Minimal Column Width" (and possibly "Optimal Column Width", addressed in the next topic here.) If there are other differences, then please identify them, because I cannot see more in what has been provided. Bug 121367, comment 1 (for Writer) indicates: Minimize column and optimize column DO grow the table size if the space is available. Questions (to be sure I have it right): 1. Minimal column: DOES grow table for Writer; DOES NOT grow for Draw 2. Optimal column DOES grow table for Writer (if space is available); DOES NOT grow for Draw? (your descriptions for "Optimal" did not comment on growing, hence the uncertainty) 3. What does "if space is available" mean in this context? (left/right page margins? plus top/bottom margins, unless table can flow over a page? Will the top border of the table ever move up in the page, or is the space always added at the end of the table? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 120550] Draw - Changes to table size "Optimal" features need documentation
https://bugs.documentfoundation.org/show_bug.cgi?id=120550 --- Comment #10 from Justin L --- (In reply to sdc.blanco from comment #5) > Do any of the relevant pages need updating? All of the relevant pages will need updating since all functions have been tweaked. (In reply to sdc.blanco from comment #6) > Have now found "Optimize Size" > iiuc -- this page needs the following controls added for Draw: > > "Minimal Row Height" > "Minimal Column Width" > "Optimal Row Height" > "Optimal Column Width" Yes, and the descriptions for "Distribute * Equally" might need to be corrected as well. > I assume that the "Optimize Size" toolbar in Draw and Writer have (a) the > same controls, and (b) the same behavior. The same controls, yes. The behaviour is approximately the same, but not completely as indicated in comment 1 (since the code is completely different). (In reply to sdc.blanco from comment #7) > Just to be sure... no such menu for Calc? Correct. (In reply to sdc.blanco from comment #8) > Writer: "Minimize Row Height" "Minimize Column Width" > Draw/Impress: "Minimal Row Height" "Minimal Column Width" > > (but it looks like they use the same .uno:SetMinimalRowHeight and > uno:SetMinimalColumnWidth ) Yes, these ought to be the same wording. Probably "minimal" to match "optimal" (In reply to sdc.blanco from comment #9) > but it is possible that the text that appears in > https://help.libreoffice.org/master/en-US/text/swriter/main0110.html (with > possible additions) would be correct/adequate in relation to Draw/Impress (?) These descriptions are not very accurate or complete. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 120550] Draw - Changes to table size "Optimal" features need documentation
https://bugs.documentfoundation.org/show_bug.cgi?id=120550 sdc.bla...@youmail.dk changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #9 from sdc.bla...@youmail.dk --- (In reply to sdc.blanco from comment #6) > afaict -- no pages exist for > > "Minimal Row Height" > "Minimal Column Width" but it is possible that the text that appears in https://help.libreoffice.org/master/en-US/text/swriter/main0110.html (with possible additions) would be correct/adequate in relation to Draw/Impress (?) If yes, then these texts could be embedded into the "Optimize Size" menu (noted in comment 6) (from quick inspection the description appears pretty close -- but it is best that you specify what needs to be adjusted.) This seems as far as I can come -- setting NEEDINFO in relation to comment 5, comment 6, comment 7, comment 8 and comment 9 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 120550] Draw - Changes to table size "Optimal" features need documentation
https://bugs.documentfoundation.org/show_bug.cgi?id=120550 --- Comment #8 from sdc.bla...@youmail.dk --- Writer: "Minimize Row Height" "Minimize Column Width" Draw/Impress: "Minimal Row Height" "Minimal Column Width" (but it looks like they use the same .uno:SetMinimalRowHeight and uno:SetMinimalColumnWidth ) Assume these are same command => should be named the same (but have not filed a separate ticket). If the assumption is correct, would be much better to use the same name across modules (if only to make the help page maintenance much easier), and possibly for the sake of some users. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 120550] Draw - Changes to table size "Optimal" features need documentation
https://bugs.documentfoundation.org/show_bug.cgi?id=120550 --- Comment #7 from sdc.bla...@youmail.dk --- Just to be sure...Writer, Draw, Impress have the same "Optimize" dropdown menu on the Table toolbar, with the same functions, and no such menu for Calc? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 120550] Draw - Changes to table size "Optimal" features need documentation
https://bugs.documentfoundation.org/show_bug.cgi?id=120550 --- Comment #6 from sdc.bla...@youmail.dk --- (In reply to Justin L from comment #4) > There is nothing that tells the user what distinguishes distribute, > optimize, or minimal. Proposed wording indicated in comment 0's link. Can work with proposed wording, but need to locate which page(s) might need this wording. Have now found "Optimize Size" https://help.libreoffice.org/7.4/en-US/text/shared/02/0421.html?=DRAW iiuc -- this page needs the following controls added for Draw: "Minimal Row Height" "Minimal Column Width" "Optimal Row Height" "Optimal Column Width" I believe pages exist for "Optimal Row Height" (though currently it is "Optimal Height") and "Optimal Column Width". afaict -- no pages exist for "Minimal Row Height" "Minimal Column Width" => need to create pages for these two controls. I assume that the "Optimize Size" toolbar in Draw and Writer have (a) the same controls, and (b) the same behavior, so it is just a matter of "updating" the "Optimize Size" page. If that analysis is correct, then this page might also be the appropriate place to address the "differentiation" of these controls (which would solve the problem for both Draw and Writer). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 120550] Draw - Changes to table size "Optimal" features need documentation
https://bugs.documentfoundation.org/show_bug.cgi?id=120550 --- Comment #5 from sdc.bla...@youmail.dk --- (In reply to Justin L from comment #4) > also in the menu at Format - Table - ... While I could not find a help page for Format > Table in Draw (bug 149318), most of the submenu items (except for Minimal Row Height and Minimal Column Width) have help pages. Format > Table > (submenu item) Press F1 Do any of the relevant pages need updating? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 120550] Draw - Changes to table size "Optimal" features need documentation
https://bugs.documentfoundation.org/show_bug.cgi?id=120550 --- Comment #4 from Justin L --- (In reply to sdc.blanco from comment #3) > Afaict -- the only UI for table optimization in Draw is the Table toolbar No, it is also in the menu at Format - Table - ... > 2. If yes, please identify specifically what changes, if any, are needed to > that page. There is nothing that tells the user what distinguishes distribute, optimize, or minimal. Proposed wording indicated in comment 0's link. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 120550] Draw - Changes to table size "Optimal" features need documentation
https://bugs.documentfoundation.org/show_bug.cgi?id=120550 --- Comment #3 from sdc.bla...@youmail.dk --- Afaict -- the only UI for table optimization in Draw is the Table toolbar: https://help.libreoffice.org/master/en-US/text/shared/main0204.html?=DRAW Questions: 1. Is that analysis correct? 2. If yes, please identify specifically what changes, if any, are needed to that page. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 120550] Draw - Changes to table size "Optimal" features need documentation
https://bugs.documentfoundation.org/show_bug.cgi?id=120550 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||120200 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=120200 [Bug 120200] [META] Update or correct help for features -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120550] Draw - Changes to table size "Optimal" features need documentation
https://bugs.documentfoundation.org/show_bug.cgi?id=120550 Xisco Faulí changed: What|Removed |Added See Also|https://bugs.documentfounda |https://bugs.documentfounda |tion.org/show_bug.cgi?id=64 |tion.org/show_bug.cgi?id=12 |242 |1367 Summary|Changes to table size |Draw - Changes to table |"Optimal" features need |size "Optimal" features |documentation |need documentation -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
