[Libreoffice-bugs] [Bug 120603] Misleading error messages resulting from fixes for bug #120353
https://bugs.documentfoundation.org/show_bug.cgi?id=120603 t...@tim-passingham.co.uk changed: What|Removed |Added CC||t...@tim-passingham.co.uk --- Comment #10 from t...@tim-passingham.co.uk --- All OK by me. Thanks. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 120603] Misleading error messages resulting from fixes for bug #120353
https://bugs.documentfoundation.org/show_bug.cgi?id=120603 Lionel Elie Mamane changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #9 from Lionel Elie Mamane --- (In reply to Robert Großkopf from comment #8) > If input is required by the database (defined in table) you will get a > special error of your database. This error is always in English. Yes, you are right, I think this has changed at some point. LibreOffice used to try to enforce the NOT NULL on the table itself (and give the same error message as when the _form_ requires a value), now it just lets the database deal with it. That's better because the database may have a trigger that chooses a value, or another mechanism that LibreOffice doesn't know about. I don't immediately find the commit that did that, but it jogs my memory. (Incidentally, some databases allow error messages to be in another chosen language, not only English.) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 120603] Misleading error messages resulting from fixes for bug #120353
https://bugs.documentfoundation.org/show_bug.cgi?id=120603 --- Comment #8 from Robert Großkopf --- Isn't this bug already solved. Since https://bugs.documentfoundation.org/show_bug.cgi?id=150577 has been resolved it works as it should: Form fields, which are created new, will be set to Input required → no by default. If input is required by the database (defined in table) you will get a special error of your database. This error is always in English. If input is set "required" in a form control, you will get an error message of the form. This error is in your GUI language and much more user-friendly like the error, which has been returned by the database. All this is working well with LO 7.4.2.3. Shouldn't we close this bug? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 120603] Misleading error messages resulting from fixes for bug #120353
https://bugs.documentfoundation.org/show_bug.cgi?id=120603 Xisco Faulí changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #7 from Xisco Faulí --- Moving to NEW -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120603] Misleading error messages resulting from fixes for bug #120353
https://bugs.documentfoundation.org/show_bug.cgi?id=120603 --- Comment #6 from Julien Nabet --- (In reply to Lionel Elie Mamane from comment #5) >... > Giving a different error message when the "input required" bit comes from > the form or from the database can still be considered a worthy enhancement. If I understand well, you want to distinguish these 2 cases: - xFirstControlWithInputRequired - xFirstGridWithInputRequiredColumn see https://opengrok.libreoffice.org/xref/core/svx/source/form/formcontroller.cxx?r=cec7ae9f#219 So in function FormController::approveRowChange (cf https://opengrok.libreoffice.org/xref/core/svx/source/form/formcontroller.cxx?r=cec7ae9f#3706) instead of: 3706 OUString sMessage( SvxResId( RID_ERR_FIELDREQUIRED ) ); 3707 sMessage = sMessage.replaceFirst( "#", rColInfo.sName ); It would be something like: OUString sMessage( xFirstControlWithInputRequired?SvxResId( RID_ERR_FIELDREQUIRED _DB):SvxResId( RID_ERR_FIELDREQUIRED_FORM )); (or reuse RID_ERR_FIELDREQUIRED for DB and change the content to explicitly quote database and add RID_ERR_FIELDREQUIRED_FORM) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120603] Misleading error messages resulting from fixes for bug #120353
https://bugs.documentfoundation.org/show_bug.cgi?id=120603 --- Comment #5 from Lionel Elie Mamane --- Since LibreOffice 6.1.4 (and 6.2.0.0 from somewhere in early December 2018), odb files last saved by earlier versions of LibreOffice will have all form controls set to "Input required: no". See bug 120353 comment 27. This should massively help to sidestep this. Giving a different error message when the "input required" bit comes from the form or from the database can still be considered a worthy enhancement. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120603] Misleading error messages resulting from fixes for bug #120353
https://bugs.documentfoundation.org/show_bug.cgi?id=120603 Xisco Faulí changed: What|Removed |Added Severity|normal |enhancement -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120603] Misleading error messages resulting from fixes for bug #120353
https://bugs.documentfoundation.org/show_bug.cgi?id=120603 --- Comment #4 from Lionel Elie Mamane --- AFAIR, the same message is used whether the restriction is in the form or in the database. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120603] Misleading error messages resulting from fixes for bug #120353
https://bugs.documentfoundation.org/show_bug.cgi?id=120603 --- Comment #3 from Julien Nabet --- About "Input required in field 'xyz'. Please enter a value"., it's in https://opengrok.libreoffice.org/xref/core/include/svx/strings.hrc?r=c89a4996#1108 but "Error writing to the database" is nowhere to be seen in Opengrok so don't know where it comes from :-( -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120603] Misleading error messages resulting from fixes for bug #120353
https://bugs.documentfoundation.org/show_bug.cgi?id=120603 Xisco Faulí changed: What|Removed |Added CC||serval2...@yahoo.fr, ||xiscofa...@libreoffice.org --- Comment #2 from Xisco Faulí --- @Julien Nabet, Any opinion here? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120603] Misleading error messages resulting from fixes for bug #120353
https://bugs.documentfoundation.org/show_bug.cgi?id=120603 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||34694 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=34694 [Bug 34694] [META] Improve usability of error messages -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120603] Misleading error messages resulting from fixes for bug #120353
https://bugs.documentfoundation.org/show_bug.cgi?id=120603 Lionel Elie Mamane changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||1921 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120603] Misleading error messages resulting from fixes for bug #120353
https://bugs.documentfoundation.org/show_bug.cgi?id=120603 --- Comment #1 from Alex Thurgood --- See also : https://bugs.documentfoundation.org/show_bug.cgi?id=120712#c2 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120603] Misleading error messages resulting from fixes for bug #120353
https://bugs.documentfoundation.org/show_bug.cgi?id=120603 Alex Thurgood changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||1188 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120603] Misleading error messages resulting from fixes for bug #120353
https://bugs.documentfoundation.org/show_bug.cgi?id=120603 Adolfo Jayme changed: What|Removed |Added Summary|Misleading error messages |Misleading error messages |resulting from fixes for|resulting from fixes for |#120353 |bug #120353 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
