[Libreoffice-bugs] [Bug 121659] FILESAVE DOCX Manual Column Break is lost after exported
https://bugs.documentfoundation.org/show_bug.cgi?id=121659 --- Comment #17 from NISZ LibreOffice Team --- After a bit of extra investigation into the issue it looks like this is really a file open issue. In the original example the problem is with the image being anchored before the column break in the same paragraph as the very first run, then comes the column break and then some text. However adding a letter in front of the anchoring point in Word so that the image is not placed at the beginning of its paragraph as first run fixes all our woes that start with opening the file: the shape appears in the correct location (this is not detailed in the original report) and saving the file does not remove the column break. So the idea we consider is to create an extra empty paragraph in this situation before the break, so that the shape can be anchored to it. This should not hurt the visual appearance even after a roundtrip. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121659] FILESAVE DOCX Manual Column Break is lost after exported
https://bugs.documentfoundation.org/show_bug.cgi?id=121659 --- Comment #16 from Justin L --- Created attachment 164012 --> https://bugs.documentfoundation.org/attachment.cgi?id=164012=edit tdf121659_patch.diff: good enough for this specific example kind of fix This patch works for this particular example. But it doesn't work with tables, and might not work if a shape has an empty paragraph. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121659] FILESAVE DOCX Manual Column Break is lost after exported
https://bugs.documentfoundation.org/show_bug.cgi?id=121659 --- Comment #15 from Justin L --- Note that this is also a FILEOPEN bug. MS Word 2016 and 2003 both open up the round-tripped document just fine. In fact, it seems like that really is the ultimate problem here. It doesn't look illegal to me. In the round-trip it just moves to the position before the image anchor instead of after the image on the same paragraph. There is only one unit test that has a page/column break deferred onto it. (tdf81345.docx - ooxmlexport4) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121659] FILESAVE DOCX Manual Column Break is lost after exported
https://bugs.documentfoundation.org/show_bug.cgi?id=121659 Justin L changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=78 ||333 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121659] FILESAVE DOCX Manual Column Break is lost after exported
https://bugs.documentfoundation.org/show_bug.cgi?id=121659 --- Comment #14 from Justin L --- (In reply to Justin L from comment #7) > So this works, but not sure where the best place to put this is. > void DomainMapper::lcl_endParagraphGroup() > +m_pImpl->SetIsFirstRun(false); This doesn't seem to work anymore. Anyway, it looks like a false clue. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121659] FILESAVE DOCX Manual Column Break is lost after exported
https://bugs.documentfoundation.org/show_bug.cgi?id=121659 --- Comment #13 from Justin L --- (In reply to Justin L from comment #12) > P.S. Word 2016 doesn't like this old compatibility-format either and acts > very differently when it saves it in native mode. That's bug 135343. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121659] FILESAVE DOCX Manual Column Break is lost after exported
https://bugs.documentfoundation.org/show_bug.cgi?id=121659 --- Comment #12 from Justin L --- Created attachment 163807 --> https://bugs.documentfoundation.org/attachment.cgi?id=163807=edit n652364_A6.docx: modified in Word 2003. A strange "End of Section"... (In reply to Xisco Faulí from comment #8) > Also reproduced with file from sw/qa/extras/ooxmlexport/data/n652364.docx This one was also affected by MSWordExportBase: fix export of header/footer in case of multiple columns but I don't think it is related to this bug report at all. P.S. Word 2016 doesn't like this old compatibility-format either and acts very differently when it saves it in native mode - much like LO currently handles it. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121659] FILESAVE DOCX Manual Column Break is lost after exported
https://bugs.documentfoundation.org/show_bug.cgi?id=121659 --- Comment #11 from Justin L --- Created attachment 163806 --> https://bugs.documentfoundation.org/attachment.cgi?id=163806=edit alphabeticalIndex_MultipleColumns_minimal.pdf: how it looks in MSO 2016 (and 2003) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121659] FILESAVE DOCX Manual Column Break is lost after exported
https://bugs.documentfoundation.org/show_bug.cgi?id=121659 --- Comment #10 from Justin L --- Created attachment 163804 --> https://bugs.documentfoundation.org/attachment.cgi?id=163804=edit alphabeticalIndex_MultipleColumns_minimized.docx (In reply to Xisco Faulí from comment #9) > sw/qa/extras/ooxmlexport/data/alphabeticalIndex_MultipleColumns.docx Yes, this one could be a similar since it has a field in the column section. I don't see a column break though. There are just continuous section breaks before and after the column section. This one bibisects to bibisect commit aeea51a8818a5deb7b95ba0b758463ba1703e9c4 source-hash-c4a5f8c1afd42acb52d0ae9b4d6f42f3e87364d5 Author: Miklos Vajna on Tue Jul 8 15:35:47 2014 +0200 MSWordExportBase: fix export of header/footer in case of multiple columns -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121659] FILESAVE DOCX Manual Column Break is lost after exported
https://bugs.documentfoundation.org/show_bug.cgi?id=121659 --- Comment #9 from Xisco Faulí --- sw/qa/extras/ooxmlexport/data/alphabeticalIndex_MultipleColumns.docx is also affected by this issue -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121659] FILESAVE DOCX Manual Column Break is lost after exported
https://bugs.documentfoundation.org/show_bug.cgi?id=121659 Xisco Faulí changed: What|Removed |Added Blocks||132615 --- Comment #8 from Xisco Faulí --- Also reproduced with file from sw/qa/extras/ooxmlexport/data/n652364.docx Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=132615 [Bug 132615] [META] unittests with different pages at import and export time -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121659] FILESAVE DOCX Manual Column Break is lost after exported
https://bugs.documentfoundation.org/show_bug.cgi?id=121659 --- Comment #7 from Justin L --- So this works, but not sure where the best place to put this is. Anyway, although probably not an easy hack, this gives someone a good starting point. I think I'll leave this edge case open for a novice who wants to get into trouble... void DomainMapper::lcl_endParagraphGroup() +m_pImpl->SetIsFirstRun(false); -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121659] FILESAVE DOCX Manual Column Break is lost after exported
https://bugs.documentfoundation.org/show_bug.cgi?id=121659 Justin L changed: What|Removed |Added CC||jl...@mail.com --- Comment #6 from Justin L --- Created attachment 147740 --> https://bugs.documentfoundation.org/attachment.cgi?id=147740=edit columns2.docx: more paragraphs added so balanced and column break don't match (In reply to raal from comment #5) I get the same 4.4 bibisect result as you, but that specific commit just exposes several other things that happened in that time period from Feb till Jul. Although Word2003 still sees the manual break, the key problem to look for in bibisect4.4max is the loss of the column break, which actually happened from export commit 80fd9fb7209cfd5c0622ee99d59e42e6db32f021 Author: Umesh Kadam @synerzip.com CommitDate: Thu May 22 02:31:53 2014 -0500 fdo#78333 : SdtContent and a Shape overlapping causes corruption The following commit should be ENTIRELY unrelated - even though reverting it visually "fixes" the original columns.docx. commit d185204737031955c56a24356ed003d342548434 Author: Miklos Vajna Date: Thu Jul 17 14:59:19 2014 +0200 DOCX import: set DontBalanceTextColumns=true for the last section ... ... if it has multiple columns. See wwSectionManager::InsertSegments() for the related binary import code which already did this. There are two problems here. One is that the column break is being absorbed into the shape on import. Removing the shape also "fixes" the problem. The other problem is that the shape should be imported BEFORE the column break - probably requiring another fake/split paragraph. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121659] FILESAVE DOCX Manual Column Break is lost after exported
https://bugs.documentfoundation.org/show_bug.cgi?id=121659 Xisco Faulí changed: What|Removed |Added Version|6.2.0.0.alpha1+ |4.4 all versions -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121659] FILESAVE DOCX Manual Column Break is lost after exported
https://bugs.documentfoundation.org/show_bug.cgi?id=121659 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Keywords||filter:docx Blocks||107836 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107836 [Bug 107836] [META] Page and section column bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121659] FILESAVE DOCX Manual Column Break is lost after exported
https://bugs.documentfoundation.org/show_bug.cgi?id=121659 raal changed: What|Removed |Added Keywords||bibisected, bisected, ||regression CC||vmik...@collabora.com --- Comment #5 from raal --- This seems to have begun at the below commit. Adding Cc: to Miklos Vajna ; Could you possibly take a look at this one? Thanks commit aeea51a8818a5deb7b95ba0b758463ba1703e9c4 Author: Matthew Francis Date: Sat Mar 14 22:48:09 2015 +0800 source-hash-c4a5f8c1afd42acb52d0ae9b4d6f42f3e87364d5 commit c4a5f8c1afd42acb52d0ae9b4d6f42f3e87364d5 Author: Miklos Vajna AuthorDate: Tue Jul 8 14:41:10 2014 +0200 Commit: Miklos Vajna CommitDate: Tue Jul 8 15:35:47 2014 +0200 MSWordExportBase: fix export of header/footer in case of multiple columns Regression from 263938c4a8789d881f8e736d317b6bcc09c3bce5 (fdo#73596 [DOCX] Multiple Columns in Index, 2014-02-13), header / footer was lost in multi-column section. This fixes both DOC and DOCX export. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121659] FILESAVE DOCX Manual Column Break is lost after exported
https://bugs.documentfoundation.org/show_bug.cgi?id=121659 raal changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||r...@post.cz Ever confirmed|0 |1 --- Comment #4 from raal --- Confirm with Version: 6.2.0.0.beta1+ Build ID: 268364e35100b559f42d8c02b930c5cca1c84be7 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121659] FILESAVE DOCX Manual Column Break is lost after exported
https://bugs.documentfoundation.org/show_bug.cgi?id=121659 --- Comment #3 from NISZ LibreOffice Team --- Created attachment 146946 --> https://bugs.documentfoundation.org/attachment.cgi?id=146946=edit The original file saved by Writer -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121659] FILESAVE DOCX Manual Column Break is lost after exported
https://bugs.documentfoundation.org/show_bug.cgi?id=121659 --- Comment #1 from NISZ LibreOffice Team --- Created attachment 146944 --> https://bugs.documentfoundation.org/attachment.cgi?id=146944=edit Screenshot of the original and exported document side by side in Word and Writer. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121659] FILESAVE DOCX Manual Column Break is lost after exported
https://bugs.documentfoundation.org/show_bug.cgi?id=121659 --- Comment #2 from NISZ LibreOffice Team --- Created attachment 146945 --> https://bugs.documentfoundation.org/attachment.cgi?id=146945=edit Example file from Word -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
