[Libreoffice-bugs] [Bug 121925] Fix Java Jar dependency classpath to pass the ClassPathURLCheck

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=121925

BogdanB  changed:

   What|Removed |Added

 Blocks||103257
 CC||buzea.bog...@libreoffice.or
   ||g


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103257
[Bug 103257] [META] Java Runtime Environment (JRE) bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 121925] Fix Java Jar dependency classpath to pass the ClassPathURLCheck

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=121925

--- Comment #13 from Commit Notification 
 ---
Stephan Bergmann committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/52f16d1f1d3d2712313fb50014474f43a1528c32

Revert "tdf#121925 test for URLClassPath.ClassPathURLCheck"

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121925] Fix Java Jar dependency classpath to pass the ClassPathURLCheck

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=121925

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:6.3.0 target:6.2.0.1 |target:6.3.0 target:6.2.0.1
   ||target:6.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121925] Fix Java Jar dependency classpath to pass the ClassPathURLCheck

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=121925

--- Comment #12 from Stephan Bergmann  ---
(In reply to Stephan Bergmann from comment #11)
> It would have been useful to document exactly what failed.  At least with
> java-latest-openjdk-headless-13.0.0.33-1.rolling.fc31.x86_64, the
> testurlcheck program in configure.ac reports "false", but (when you convert
> the corresponding AC_MSG_ERROR into a AC_MSG_RESULT to not make configure
> fail) a full `make check screenshot` works fine for me.

As discussed on freenode #libreoffice-dev now:
> Sep 27 11:37:54  jmux, do you remember the exact failure you got in 
> tdf#121925?
> Sep 27 11:39:58  sberg: I think it simply reported missing classes. But 
> that is just a guess based on my original report.
> Sep 27 11:40:44  jmux, I'm pondering reverting your commit again, 
> given my findings with Java 13 on Fedora 31
> Sep 27 11:41:18  ...and wait for a fresh actual failure report
> Sep 27 11:44:35  sberg: no real objection. The configure test was just 
> an "extension" of commit 86f5f598a2bdd71f95921c20e0361dee54b266c1
> Sep 27 11:44:37  core - Drop juh.jar dependency from Java UNO tests - 
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=86f5f598a2bdd71f95921c20e0361dee54b266c1
> Sep 27 11:45:39  sberg: the whole thing was about these Java 
> dependencies. Maybe that was fixed somehow?
> Sep 27 11:47:20  sberg: and that was done, after I added juh.jar to the 
> Java tests in commit 84286ac443ea8978743d281efeaa7ddb46199558
> Sep 27 11:47:22  core - Simplify and fix Java UNO API test makefiles - 
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=84286ac443ea8978743d281efeaa7ddb46199558
> Sep 27 11:48:53  sberg: from https://gerrit.libreoffice.org/#/c/62203/ 
> commit message: java.lang.NoClassDefFoundError: 
> com/sun/star/comp/helper/Bootstrap
> Sep 27 11:48:53  gerrit: »add missing juh dependencies to JunitTests« 
> by Rene Engelhard for master [ABANDONED]

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121925] Fix Java Jar dependency classpath to pass the ClassPathURLCheck

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=121925

--- Comment #11 from Stephan Bergmann  ---
(In reply to Jan-Marek Glogowski from comment #0)
> When OpenJDK tried to enforce stricter class path URL checks without
> previous announcement, things started to break left and right. This included
> failing LibreOffice JUnitTest checks, since the dependency classpath in our
> generated Jars doesn't pass the stricter URL checks and therefore is ignored.

It would have been useful to document exactly what failed.  At least with
java-latest-openjdk-headless-13.0.0.33-1.rolling.fc31.x86_64, the testurlcheck
program in configure.ac reports "false", but (when you convert the
corresponding AC_MSG_ERROR into a AC_MSG_RESULT to not make configure fail) a
full `make check screenshot` works fine for me.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121925] Fix Java Jar dependency classpath to pass the ClassPathURLCheck

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=121925

--- Comment #10 from Alex Thurgood  ---
(In reply to Stephan Bergmann from comment #9)

> Hard to tell without further information about such failures.  If there is a
> bug about that, please give a link to it here, so we can discuss that issue
> there instead of speculating here.

Opened bug 125882 with regard to embedded hsqldb ODB files.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121925] Fix Java Jar dependency classpath to pass the ClassPathURLCheck

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=121925

Alex Thurgood  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||5882

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121925] Fix Java Jar dependency classpath to pass the ClassPathURLCheck

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=121925

--- Comment #9 from Stephan Bergmann  ---
(In reply to Alex Thurgood from comment #8)
> Would this bug also affect use of Oracle OpenJDK 12 when trying to call an
> external hsqldb.jar, e.g. when a user has what is known as a split database
> (no embedded hsqldb) ? If so, then it would be a regression for those users.

Hard to tell without further information about such failures.  If there is a
bug about that, please give a link to it here, so we can discuss that issue
there instead of speculating here.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121925] Fix Java Jar dependency classpath to pass the ClassPathURLCheck

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=121925

--- Comment #8 from Alex Thurgood  ---
Would this bug also affect use of Oracle OpenJDK 12 when trying to call an
external hsqldb.jar, e.g. when a user has what is known as a split database (no
embedded hsqldb) ? If so, then it would be a regression for those users.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121925] Fix Java Jar dependency classpath to pass the ClassPathURLCheck

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=121925

--- Comment #7 from Stephan Bergmann  ---
(In reply to Andreas Säger from comment #6)
> Is this the reason why
> https://adoptopenjdk.net is not recognized as a valid JDK?

That should work with  "Support
AdoptOpenJDK" (and its backports to the various release branches, see there). 
(And if you have further issues with that specific JDK, please file a new
issue.  It is most likely completely unrelated to this issue.)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121925] Fix Java Jar dependency classpath to pass the ClassPathURLCheck

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=121925

--- Comment #6 from Andreas Säger  ---
I don't understand the details of this issue. Is this the reason why
https://adoptopenjdk.net is not recognized as a valid JDK?
Is it true that someone works on it?
No need to file another issue?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121925] Fix Java Jar dependency classpath to pass the ClassPathURLCheck

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=121925

--- Comment #5 from Jan-Marek Glogowski  ---
These patches are no fixes, but will detect the failing JDK setup during
configure as an early warning! They should be reverted after a real fix is
merged.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121925] Fix Java Jar dependency classpath to pass the ClassPathURLCheck

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=121925

--- Comment #4 from Commit Notification 
 ---
Jan-Marek Glogowski committed a patch related to this issue.
It has been pushed to "libreoffice-6-2":

https://git.libreoffice.org/core/+/c9de94c65b8ab8bf6073400eda5ba848ba22af47%5E%21

tdf#121925 test for URLClassPath.ClassPathURLCheck

It will be available in 6.2.0.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121925] Fix Java Jar dependency classpath to pass the ClassPathURLCheck

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=121925

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:6.3.0|target:6.3.0 target:6.2.0.1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121925] Fix Java Jar dependency classpath to pass the ClassPathURLCheck

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=121925

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.3.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121925] Fix Java Jar dependency classpath to pass the ClassPathURLCheck

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=121925

--- Comment #3 from Commit Notification 
 ---
Jan-Marek Glogowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/905c107cde4a0a7059b1e11b5f23a0a59188cb0c%5E%21

tdf#121925 test for URLClassPath.ClassPathURLCheck

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121925] Fix Java Jar dependency classpath to pass the ClassPathURLCheck

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=121925

Rene Engelhard  changed:

   What|Removed |Added

   See Also||http://bugs.debian.org/9136
   ||41

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121925] Fix Java Jar dependency classpath to pass the ClassPathURLCheck

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=121925

Rene Engelhard  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121925] Fix Java Jar dependency classpath to pass the ClassPathURLCheck

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=121925

--- Comment #2 from Jan-Marek Glogowski  ---
>From reading the current URLClassPath.java code, it seem you can set
"jdk.net.URLClassPath.disableClassPathURLCheck" to "debug", and the loader will
print the ignored class path entries, which can help debugging.

But it doesn't look like there is a way to get the default value, which could
be checked by configure or even our jars to want people of failures.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121925] Fix Java Jar dependency classpath to pass the ClassPathURLCheck

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=121925

Stephan Bergmann  changed:

   What|Removed |Added

 CC||sberg...@redhat.com

--- Comment #1 from Stephan Bergmann  ---
quoting my 2018-11-12 10:34 comment at
 "Simplify and fix Java UNO API test
makefiles":

"With Java moving away from supporting absolute file URLs in jar manifest
Class-Paths, we need a new solution for what we currently do with
gb_Jar_add_manifest_classpath/gb_Helper_make_url.  We use that in
unotest/Jar_test.mk (which is the subject of this change), but also in
gb_Jar_use_system_jar as used in various places in RepositoryExternal.mk. 
(Note how we already have issues with file URLs in all of these places with
recent Java on Windows, see

'Re: make check fails in [build JCS]'.)

"However, from

and the details of
 '8195874:
Improve jar specification adherence', it looks like support for relative paths
starting with '..' in jar manifest Class-Paths is also going away.  We
currently use such at least in bridges/Jar_java_uno.mk,
connectivity/Jar_sdbc_hsqldb.mk, and javaunohelper/Jar_juh.mk."

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs