[Libreoffice-bugs] [Bug 123139] Reading XLSX format ignores horizontal alignment (generated with Apache POI Java library)

2021-12-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123139

Justin L  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |jl...@mail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 123139] Reading XLSX format ignores horizontal alignment (generated with Apache POI Java library)

2021-12-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123139

Justin L  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #10 from Justin L  ---
No intention to backport a trivial fix which goes against documentation just
because that matches Excel in testing.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 123139] Reading XLSX format ignores horizontal alignment (generated with Apache POI Java library)

2021-12-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123139

--- Comment #9 from Commit Notification 
 ---
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/ab99d16e21e56596803b7d9a28af0895b435ef3e

tdf#123139 sc oox: CellXf should default to applyAlignment

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 123139] Reading XLSX format ignores horizontal alignment (generated with Apache POI Java library)

2021-12-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123139

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 123139] Reading XLSX format ignores horizontal alignment (generated with Apache POI Java library)

2021-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123139

--- Comment #8 from Justin L  ---
Created attachment 176617
  --> https://bugs.documentfoundation.org/attachment.cgi?id=176617&action=edit
out_exaggerated.xlsx: includes applyProtection elements

In the current implementation, the first style that is applied affects all
cells. The alignment/protection settings are accepted regardless of whether it
is considered "used" or not.

Proposed patch at http://gerrit.libreoffice.org/c/core/+/126177

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 123139] Reading XLSX format ignores horizontal alignment (generated with Apache POI Java library)

2021-11-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123139

Justin L  changed:

   What|Removed |Added

   Hardware|x86 (IA32)  |All
Summary|Reading XLSX format ignores |Reading XLSX format ignores
   |horizontal alignment|horizontal alignment
   |(generated wit  Apache POI  |(generated with Apache POI
   |Java library)   |Java library)

--- Comment #7 from Justin L  ---
I wouldn't say that commit 3 is truly regressive - it seems to have just
exposed some kind of flaw or poor handling in the import process.

I note that some handling has been done in 2021 Apache POI v5.0 that takes into
account the adjustAlignment variable.


I'm not sure why commit 3 would be involved here.
I have narrowed it down to SheetDataBuffer::addColXfStyles, which tries to
consolidate styles using addIfNotInMyMap(). In that comparison, it only checks
if mbAlignUsed.
(stylesbuffer.cxx's bool operator==(rXf1, rXf2))

-- 
You are receiving this mail because:
You are the assignee for the bug.