[Libreoffice-bugs] [Bug 125288] wrong Bar color name in the Data bar dialog (#0000FF instead of Blue)
https://bugs.documentfoundation.org/show_bug.cgi?id=125288 László Kovács changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |kovacs.laszlo.zoltan98@gmai |desktop.org |l.com -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125288] wrong Bar color name in the Data bar dialog (#0000FF instead of Blue)
https://bugs.documentfoundation.org/show_bug.cgi?id=125288 Heiko Tietze changed: What|Removed |Added Keywords||difficultyBeginner, ||easyHack, skillDesign, ||topicDesign CC||markus.mohrhard@googlemail. ||com --- Comment #5 from Heiko Tietze --- Would prefer #1 since saturated colors are never a good design. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125288] wrong Bar color name in the Data bar dialog (#0000FF instead of Blue)
https://bugs.documentfoundation.org/show_bug.cgi?id=125288 --- Comment #4 from V Stuart Foote --- and dialog is hardcoded here as well... https://opengrok.libreoffice.org/xref/core/sc/source/ui/condformat/colorformat.cxx?r=e5c3d5f3#129 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125288] wrong Bar color name in the Data bar dialog (#0000FF instead of Blue)
https://bugs.documentfoundation.org/show_bug.cgi?id=125288 --- Comment #3 from V Stuart Foote --- (In reply to V Stuart Foote from comment #2) And, the actual hard coded color set for maPositiveColor [1] is the color constant COL_LIGHTBLUE -- ( 0x00, 0x00, 0xFF ) [2] Option #1 -- Could define a different constant to pick up the blue from standard.soc Option #2 -- shift UI use of conditional formatting from standard.soc to tonal.soc, i.e. perform a palette change and pick up labeling from tonal.soc Option #3 -- Could edit the COL_LIGHTBLUE to match the standard.soc (broader potential impact across UI and in unit tests). IMHO Option #2 seems a better way to correct this--not clear how many unit tests would have to also be tweaked with Option #1, and Option #3 would be kind of invasive. =ref-= [1] https://opengrok.libreoffice.org/xref/core/sc/source/ui/condformat/condformatdlgentry.cxx?r=00ae441b#1107 [2] https://opengrok.libreoffice.org/xref/core/include/tools/color.hxx?r=d14d1341#282 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125288] wrong Bar color name in the Data bar dialog (#0000FF instead of Blue)
https://bugs.documentfoundation.org/show_bug.cgi?id=125288 V Stuart Foote changed: What|Removed |Added Component|UI |Calc CC||er...@redhat.com, ||vstuart.fo...@utsa.edu Summary|wrong color name in Data|wrong Bar color name in the |bar dialog (#FF instead |Data bar dialog (#FF |Blue) |instead of Blue) Keywords|regression | Version|6.2.3.2 release |6.1.0.0.alpha0+ --- Comment #2 from V Stuart Foote --- Hmm, not really a regression. From the 6.1.0 release the color value for our RYB scheme named Blue is #2a6099; color value assigned from the standard .SOC (based on the Gossett & Chen ryb2rgb algorithm interpolating RGB vector values corresponding to a RYB inscribed in a tensor--see bug 114719). The hard coded #FF color used for the Data Bar colors is the fully saturated RGB scheme Blue. The Bar Colors for conditional formatting dialog/configs did not get adjusted to the RYB based standard.soc at 6.1 release, names of which are now localized. Red behaves, because it uses the #FF color assignment and its name is picked up from the standard.soc -- the Blue does not as its #FF does not match the RYB interpolated Hue for Blue of #2a6099--so it gets no name but its hex value. Probably could point the source used for the Data Bar colors [1] to Standard SOC, but that is likely to also impact the QA unit tests that would need tweaks. An, alternative, might be for conditional formatting Data Bars to use the RGB centric tonal.soc which assigns the fully saturated RGB. Otherwise an easy workaround is for user to just use the "tonal" palette (see bug 80196), color values there are meaningful--and visually consistent to handling of conditional formatting. =-ref-= [1] https://opengrok.libreoffice.org/xref/core/sc/source/ui/condformat/colorformat.cxx?r=e5c3d5f3#77 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
