[Libreoffice-bugs] [Bug 126202] Writer: Insert Hyperlink dialogue: can't enter or edit the URL (GTK3)
https://bugs.documentfoundation.org/show_bug.cgi?id=126202 Caolán McNamara changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |caol...@redhat.com |desktop.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126202] Writer: Insert Hyperlink dialogue: can't enter or edit the URL (GTK3)
https://bugs.documentfoundation.org/show_bug.cgi?id=126202 --- Comment #13 from Adalbert Hanßen --- (In reply to Xisco Faulí from comment #8) > Regression introduced by: > > https://cgit.freedesktop.org/libreoffice/core/commit/ > ?id=1942182a3d1817bc539229d7fda3af69f7e295b8 > > authorCaolán McNamara 2019-06-23 19:51:15 > +0100 > committer Caolán McNamara 2019-06-25 13:36:53 > +0200 > commit1942182a3d1817bc539229d7fda3af69f7e295b8 (patch) > tree 1c7291efb486d4789c580671ef0ea2133251c92c > parent2f00a7c61fff9c091f08b6aaa4f829cd34fb3745 (diff) > weld HyperLink Dialog > > Bisected with: bibisect-linux64-6.4 > > Adding Cc: to Caolán McNamara This bug was not present in Version: 6.1.4.2 Build-ID: 9d0f32d1f0b509096fd65e0d4bec26ddd1938fd3 CPU-Threads: 4; BS: Linux 4.4; UI-Render: Standard; VCL: gtk2; Gebietsschema: de-DE (de_DE.UTF-8); Calc: group threaded Probably it is the same finding as yours and that of David Gerard from comment #6, as can be conjectured from the keyword "gtk2" in the version description. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126202] Writer: Insert Hyperlink dialogue: can't enter or edit the URL (GTK3)
https://bugs.documentfoundation.org/show_bug.cgi?id=126202 --- Comment #12 from Adalbert Hanßen --- (In reply to David Gerard from comment #10) > I compile it myself. On this box, my --prefix=/home/fun/bin/libreoffice so I > start it from the command line with this command to get gtk2: > > SAL_USE_VCLPLUGIN=gtk > /home/fun/bin/libreoffice/lib/libreoffice/program/soffice David, this is a very valuable finding because it will let someone who really understands those basic functions from gtk, qt and the like direct to really trap the bug. The outcome of this might be "not my bug, it is in gtk". But this would not really eliminate it, because such bugs can trigger more severe results than just not being able to set the URL for a hyperlink! There would not be different versions of gtk unless there are differences between gtk2 and gtk3. Therefore there may be more than one applications affected by the bug. Let me guess, the possible root cause is probably is one of the following: 1. a calling interface has been changed, e.g. by introducing additional parameters and dealing with variable length calling interfaces is not properly implemented everywhere (going through the steps to edit a hyperlink in this case will lead to the one affected - unfortunately among many others!) or 2. by allowing different ranges for values of parameters. If defensive programming style limited the range of such a parameter before, it has worked before but does not work any longer, after the extended value range is used for different situations and the "limit to what is allowed" strategy has been removed to allow such extended use of existing parameters, but with different values. or 3. calling some function required some preconditions being met which are no longer guaranteed, e.g. 3a. in the old code no distinction was necessary between two different use cases of some code segment which existed in multiple similar instances which have been unified. The user of the old code did not have to care about a preconditions because it has been introduced in the unification those similar instances. Therefore one should look if any preconditions were introduced later (hopefully they are documented!). 3b. because some defensive programming code has been disabled which formerly coerced the precondition to be met by substituting what was missing before. But later someone wanted to speed up things and removed or disabled such "unnecessary stuff" because it was clearly said that the precondition must have been met before calling the function in question. Hopefully coercing the precondition has not been completely removed from the code but can be re-activated by setting proper compilation flags and hopefully they can be reactivated in such a way to eject debugging information that a superfluous safety measure really had to be taken because it was necessary in this case... or 4. some of the other rules in https://developer.gnome.org/gtk3/stable/gtk-migrating-2-to-3.html has not been observed Anyway, this bug which may (or may not) "live" in the gtk region of the software, is an interesting one as it might go unnoticed in many use cases and in the worst case it might be used to make malicious use of functions. It should be corrected and reasonable thought should be spent in checking if there are other similar cases which might trigger the same bug. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126202] Writer: Insert Hyperlink dialogue: can't enter or edit the URL (GTK3)
https://bugs.documentfoundation.org/show_bug.cgi?id=126202 --- Comment #11 from David Gerard --- obviously this isn't a *good* workaround, as you note. But it allowed me to continue progress with the complex, link-filled Writer document I was working on :-) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126202] Writer: Insert Hyperlink dialogue: can't enter or edit the URL (GTK3)
https://bugs.documentfoundation.org/show_bug.cgi?id=126202 --- Comment #10 from David Gerard --- I compile it myself. On this box, my --prefix=/home/fun/bin/libreoffice so I start it from the command line with this command to get gtk2: SAL_USE_VCLPLUGIN=gtk /home/fun/bin/libreoffice/lib/libreoffice/program/soffice -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126202] Writer: Insert Hyperlink dialogue: can't enter or edit the URL (GTK3)
https://bugs.documentfoundation.org/show_bug.cgi?id=126202 --- Comment #9 from Adalbert Hanßen --- (In reply to David Gerard from comment #6) > Just tried starting LO with: > > * SAL_USE_VCLPLUGIN=gen - gives VCL: x11 > * SAL_USE_VCLPLUGIN=gtk - gives VCL: gtk2 > > with either of these, the URL field is editable. > > So there's a workaround, at least. Please explain exactly how what the command line has to be to start LO with your solution. Would it be possible to set such an option to some preference file such that it becomes default for every start which does not explicitly ask for something else with respect to VCLPLUGIN? I tired to modify the starter for LibreOfficeWriter in menulibre to this: libreofficedev6.4 --writer SAL_USE_VCLPLUGIN=gtk %U but this did not work for me. I think, such a workaround (if it works) is only a temporary solution. Being able to produce documents which contain hyperlinks is a very basic thing and I use it very frequently and the same applies to all users who use LibreOfficeWriter for purposes beyond composing "a few pages letters" only. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126202] Writer: Insert Hyperlink dialogue: can't enter or edit the URL (GTK3)
https://bugs.documentfoundation.org/show_bug.cgi?id=126202 Xisco Faulí changed: What|Removed |Added Keywords|bibisectRequest |bibisected, bisected --- Comment #8 from Xisco Faulí --- Regression introduced by: https://cgit.freedesktop.org/libreoffice/core/commit/?id=1942182a3d1817bc539229d7fda3af69f7e295b8 author Caolán McNamara 2019-06-23 19:51:15 +0100 committer Caolán McNamara 2019-06-25 13:36:53 +0200 commit 1942182a3d1817bc539229d7fda3af69f7e295b8 (patch) tree1c7291efb486d4789c580671ef0ea2133251c92c parent 2f00a7c61fff9c091f08b6aaa4f829cd34fb3745 (diff) weld HyperLink Dialog Bisected with: bibisect-linux64-6.4 Adding Cc: to Caolán McNamara -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126202] Writer: Insert Hyperlink dialogue: can't enter or edit the URL (GTK3)
https://bugs.documentfoundation.org/show_bug.cgi?id=126202 Xisco Faulí changed: What|Removed |Added Summary|Writer: Insert Hyperlink|Writer: Insert Hyperlink |dialogue: can't enter or|dialogue: can't enter or |edit the URL|edit the URL (GTK3) CC||xiscofa...@libreoffice.org Priority|high|medium Blocks||103182 Severity|major |normal --- Comment #7 from Xisco Faulí --- only GTK3, don't think it's a high priority bug Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103182 [Bug 103182] [META] GTK3-specific bugs -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
