[Libreoffice-bugs] [Bug 126508] Crash and document recovery on option change of view -> icon style
https://bugs.documentfoundation.org/show_bug.cgi?id=126508 Samuel Mehrbrodt (CIB) changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |s.mehrbr...@gmail.com |desktop.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126508] Crash and document recovery on option change of view -> icon style
https://bugs.documentfoundation.org/show_bug.cgi?id=126508 --- Comment #12 from Samuel Mehrbrodt (CIB) --- (In reply to Xisco Faulí from comment #11) > (In reply to Samuel Mehrbrodt (CIB) from comment #10) > > There is already a patch from Julien in comment 7. > > @Julien: Would you please push that patch to gerrit for review? Or should I > > do that? > > Hi Samuel, > Considering LibreOffice 6.3 RC3 is going to be tagged this week, I was > wondering if you could submit the patch yourself ( I could do it as well if > needed ), I'd rather not to wait for someone else ( just in case he's on > vacation / absent ) otherwise we wouldn't make it in time Done: https://gerrit.libreoffice.org/#/c/76589/ and https://gerrit.libreoffice.org/#/c/76590/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126508] Crash and document recovery on option change of view -> icon style
https://bugs.documentfoundation.org/show_bug.cgi?id=126508 --- Comment #11 from Xisco Faulí --- (In reply to Samuel Mehrbrodt (CIB) from comment #10) > There is already a patch from Julien in comment 7. > @Julien: Would you please push that patch to gerrit for review? Or should I > do that? Hi Samuel, Considering LibreOffice 6.3 RC3 is going to be tagged this week, I was wondering if you could submit the patch yourself ( I could do it as well if needed ), I'd rather not to wait for someone else ( just in case he's on vacation / absent ) otherwise we wouldn't make it in time -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126508] Crash and document recovery on option change of view -> icon style
https://bugs.documentfoundation.org/show_bug.cgi?id=126508 --- Comment #10 from Samuel Mehrbrodt (CIB) --- There is already a patch from Julien in comment 7. @Julien: Would you please push that patch to gerrit for review? Or should I do that? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126508] Crash and document recovery on option change of view -> icon style
https://bugs.documentfoundation.org/show_bug.cgi?id=126508 Xisco Faulí changed: What|Removed |Added Severity|major |critical Version|6.4.0.0.alpha0+ Master |6.3.0.2 rc Keywords|bibisectRequest |bibisected, bisected --- Comment #9 from Xisco Faulí --- Regression introduced by: author Samuel Mehrbrodt 2019-07-16 17:41:48 +0200 committer Samuel Mehrbrodt 2019-07-18 10:27:25 +0200 commit b58aa94f1f365c746135470bceb97cc182c289bc (patch) tree2f4b915889695ac214988d66312498864ead62ed parent 2b4efc32e822bf41c4b729137718f3c70f692a89 (diff) tdf#126424 Don't dispose decks before saving their state Bisected with: bibisect-linux64-6.4 Adding Cc: to Samuel Mehrbrodt The patch is present in 6.3.0.2. IMHO, this should block the 6.3 until it's fixed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126508] Crash and document recovery on option change of view -> icon style
https://bugs.documentfoundation.org/show_bug.cgi?id=126508 --- Comment #8 from Ashod Nakashian --- The backtrace doesn't hint at a change I had done, though valgrind might show something not visible in the bt. If the partial revert to Samuel's commit resolves it, then great. Let me know if need anything from me please. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126508] Crash and document recovery on option change of view -> icon style
https://bugs.documentfoundation.org/show_bug.cgi?id=126508
--- Comment #7 from Julien Nabet ---
By reverting partially the quote commit, so with this patch:
diff --git a/sfx2/source/sidebar/SidebarController.cxx
b/sfx2/source/sidebar/SidebarController.cxx
index 22b022bf09ee..5af03faa08ea 100644
--- a/sfx2/source/sidebar/SidebarController.cxx
+++ b/sfx2/source/sidebar/SidebarController.cxx
@@ -733,6 +733,7 @@ void SidebarController::SwitchToDeck (
const DeckDescriptor& rDeckDescriptor,
const Context& rContext)
{
+maFocusManager.Clear();
const bool bForceNewDeck
((mnRequestedForceFlags&SwitchFlag_ForceNewDeck)!=0);
const bool bForceNewPanels
((mnRequestedForceFlags&SwitchFlag_ForceNewPanels)!=0);
mnRequestedForceFlags = SwitchFlag_NoForce;
I don't reproduce the crash.
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126508] Crash and document recovery on option change of view -> icon style
https://bugs.documentfoundation.org/show_bug.cgi?id=126508 --- Comment #6 from Julien Nabet --- Created attachment 153012 --> https://bugs.documentfoundation.org/attachment.cgi?id=153012&action=edit bt with debug symbols On pc Debian x86-64 with master sources updated yesterday, I could reproduce this. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126508] Crash and document recovery on option change of view -> icon style
https://bugs.documentfoundation.org/show_bug.cgi?id=126508 V Stuart Foote changed: What|Removed |Added Priority|medium |highest Severity|normal |major --- Comment #5 from V Stuart Foote --- Adjusting importance per QA guide, still needs a bibisect... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126508] Crash and document recovery on option change of view -> icon style
https://bugs.documentfoundation.org/show_bug.cgi?id=126508 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||110746 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=110746 [Bug 110746] [META] Options dialog's View settings bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126508] Crash and document recovery on option change of view -> icon style
https://bugs.documentfoundation.org/show_bug.cgi?id=126508 V Stuart Foote changed: What|Removed |Added CC||s.mehrbr...@gmail.com --- Comment #4 from V Stuart Foote --- None of Ashod's stuff has posted yet. @Samuel? Assume change to selected icon theme would be tracked in Sidebar state https://gerrit.libreoffice.org/#/c/75719/ looks suspect... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126508] Crash and document recovery on option change of view -> icon style
https://bugs.documentfoundation.org/show_bug.cgi?id=126508 V Stuart Foote changed: What|Removed |Added CC||ashodnakash...@yahoo.com --- Comment #3 from V Stuart Foote --- @Ashod, this may be your recent work on the Sidebar... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126508] Crash and document recovery on option change of view -> icon style
https://bugs.documentfoundation.org/show_bug.cgi?id=126508 --- Comment #2 from V Stuart Foote --- Created attachment 152945 --> https://bugs.documentfoundation.org/attachment.cgi?id=152945&action=edit windbg32 ST for non-OpenGL Just to be sure, checked and also crash/recover mergedlo!vcl::Window::RemoveEventListener with Default rendering. ST attached. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126508] Crash and document recovery on option change of view -> icon style
https://bugs.documentfoundation.org/show_bug.cgi?id=126508 V Stuart Foote changed: What|Removed |Added Keywords||haveBacktrace CC||xiscofa...@libreoffice.org -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126508] Crash and document recovery on option change of view -> icon style
https://bugs.documentfoundation.org/show_bug.cgi?id=126508 --- Comment #1 from V Stuart Foote --- Created attachment 152944 --> https://bugs.documentfoundation.org/attachment.cgi?id=152944&action=edit WinDbg32 stack trace of TB39 build with symbols -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126508] Crash and document recovery on option change of view -> icon style
https://bugs.documentfoundation.org/show_bug.cgi?id=126508 V Stuart Foote changed: What|Removed |Added Status|UNCONFIRMED |NEW Keywords||bibisectRequest, regression Ever confirmed|0 |1 CC||thorsten.wagne...@gmail.com ||, vstuart.fo...@utsa.edu -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
