[Libreoffice-bugs] [Bug 127033] Font in Spelling and Grammar Check of Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=127033 --- Comment #1 from am_dxer --- I just bisected a bug relating to accessibility in the spell check dialog. Since the spell check dialog was welded, accessibility regressed and maybe this commit caused the same problem. There are small issues like this that crop up but having the modern dialogs provides so many benefits and working through the issues is a minor difficulty for a good cause. Can someone check if this commit causes the regression? I am totally blind so can't do it. commit 243b5b392906042ab03800e0b5765e6f3513372c Author: Caolán McNamara Date: Fri Jun 14 21:56:44 2019 +0100 weld SpellDialog a) use EditEngine instead of TextEngine as the former can be hosted in a foreign widget b) use a SfxGrabBagItem to hold the custom spellchecking info inside the EditEngine c) in longer paragraphs the current word is now auto-scrolled into view d) rename Invalidate to InvalidateDialog -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127033] Font in Spelling and Grammar Check of Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=127033 Dieter Praas changed: What|Removed |Added Blocks||96000 Ever confirmed|0 |1 Keywords||regression Status|UNCONFIRMED |NEW CC||dgp-m...@gmx.de --- Comment #2 from Dieter Praas --- I confirm it with Version: 6.4.0.0.alpha0+ (x64) Build ID: 3e64065612acec2eb29aa21e2b515953422256d7 CPU threads: 4; OS: Windows 10.0; UI render: GL; VCL: win; TinderBox: Win-x86_64@62-TDF, Branch:master, Time: 2019-08-15_22:57:26 Locale: de-DE (de_DE); UI-Language: en-US Calc: threaded cc: Caolán McNamara Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=96000 [Bug 96000] [META] Spelling and grammar checking bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127033] Font in Spelling and Grammar Check of Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=127033 Telesto changed: What|Removed |Added Keywords||bibisectRequest CC||tele...@surfxs.nl -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127033] Font in Spelling and Grammar Check of Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=127033 --- Comment #3 from Caolán McNamara --- Its the default editengine font which is the same default font used for documents. Not sure that it constitutes a bug vs a change. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127033] Font in Spelling and Grammar Check of Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=127033 --- Comment #4 from Caolán McNamara --- calc format->page->header->edit uses the same underlying widget for its three "areas" and also uses the default document font there in, e.g., 6.1 so presumably changing all of those editengine in widget case fonts to the ui font would be seen as a regression so the change looked for here should presumably be restricted to the spell checking one -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127033] Font in Spelling and Grammar Check of Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=127033 Caolán McNamara changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #5 from Caolán McNamara --- https://gerrit.libreoffice.org/#/c/78632/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127033] Font in Spelling and Grammar Check of Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=127033 Commit Notification changed: What|Removed |Added Whiteboard||target:6.4.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127033] Font in Spelling and Grammar Check of Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=127033 --- Comment #6 from Commit Notification --- Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/aae9f2765036569901ec0924ac16ac1f6d91ef48%5E%21 Resolves: tdf#127033 use UI font for spell checking widget It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127033] Font in Spelling and Grammar Check of Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=127033 Caolán McNamara changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |caol...@redhat.com |desktop.org | Resolution|--- |FIXED Status|ASSIGNED|RESOLVED --- Comment #7 from Caolán McNamara --- fixed in master, backport to 6-3 in gerrit -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
