[Libreoffice-bugs] [Bug 128498] OPTIONS DIALOG: "Update Links when Loading" doesn't work for sections

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128498

Heiko Tietze  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||9153

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 128498] OPTIONS DIALOG: "Update Links when Loading" doesn't work for sections

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128498

--- Comment #15 from Stephan Bergmann  ---
(In reply to vatairethibault from comment #14)
> Ok, I understand now how link update works :
> Global settings take precedence over document settings (so LibreOffice
> always ignore the "LinkUpdateMode" document setting), and when "Always" is
> selected in global settings, links are only updated if the document is in a
> trusted file location (see Security > Macros security > Trusted sources >
> Trusted file locations).

The relevant commit

"LinkUpdateMode is a global setting" was a mitigation for

"CVE-2015-4551 Arbitrary file disclosure in Calc and Writer".  From my
private/security notes from back then:

"I have available a fix for LibreOffice that treats a document's 'always
update links' setting as if it rather were 'ask to update links' in Calc
and Writer unless

"(1) 'Tools - Options... - LibreOffice - Security - Macro Security... -
Security Level - Low (not recommended)' is selected; or

"(2) the document matches any of the 'Tools - Options... - LibreOffice -
Security - Macro Security... - Trusted Sources - Trusted File Locations.'

"That is probably a good compromise to make the new behavior actually
kick in for users, but without hampering considered-to-be-secure
scenarios with additional dialogs."

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 128498] OPTIONS DIALOG: "Update Links when Loading" doesn't work for sections

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128498

--- Comment #14 from vatairethiba...@no-log.org ---
Ok, I understand now how link update works :
Global settings take precedence over document settings (so LibreOffice always
ignore the "LinkUpdateMode" document setting), and when "Always" is selected in
global settings, links are only updated if the document is in a trusted file
location (see Security > Macros security > Trusted sources > Trusted file
locations).

Is this bug is related to this behavior ?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 128498] OPTIONS DIALOG: "Update Links when Loading" doesn't work for sections

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128498

--- Comment #13 from vatairethiba...@no-log.org ---
(In reply to Buovjaga from comment #12)
> (In reply to vatairethibault from comment #11)
> > The bug is present since commit 59f9a0de39e4356220705bb6c4be66c956dc9c6d.
> 
> That is
> https://git.libreoffice.org/core/commit/
> 59f9a0de39e4356220705bb6c4be66c956dc9c6d
> LinkUpdateMode is a global setting
> 
> That change is only about making the option global, so I don't think it
> caused the bug. Let's ask Stephan anyway.

Sorry I did not provide you all the information.

If I build libreoffice from the previous commit
(3782eb93ffb68a1291c95467176a703b1dad9b6d) the bug is not present.
If I build libreoffice from commit 59f9a0de39e4356220705bb6c4be66c956dc9c6d the
bug is present.

Since this commit neither the "LinkUpdateMode" document setting, nor the
"Update links when loading" option work.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 128498] OPTIONS DIALOG: "Update Links when Loading" doesn't work for sections

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128498

Buovjaga  changed:

   What|Removed |Added

 CC||sberg...@redhat.com

--- Comment #12 from Buovjaga  ---
(In reply to vatairethibault from comment #11)
> The bug is present since commit 59f9a0de39e4356220705bb6c4be66c956dc9c6d.

That is
https://git.libreoffice.org/core/commit/59f9a0de39e4356220705bb6c4be66c956dc9c6d
LinkUpdateMode is a global setting

That change is only about making the option global, so I don't think it caused
the bug. Let's ask Stephan anyway.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 128498] OPTIONS DIALOG: "Update Links when Loading" doesn't work for sections

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128498

--- Comment #11 from vatairethiba...@no-log.org ---
The bug is present since commit 59f9a0de39e4356220705bb6c4be66c956dc9c6d.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 128498] OPTIONS DIALOG: "Update Links when Loading" doesn't work for sections

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128498

--- Comment #10 from vatairethiba...@no-log.org ---
Hello,

On Debian Buster I can reproduce this bug since LibreOffice 4.4.4.3 (Version:
4.4.4.3 / Build ID: 2c39ebcf046445232b798108aa8a7e7d89552ea8 / Locale:
fr_FR.UTF-8)

LibreOffice 4.4.4.2 (Version: 4.4.4.2 / Build ID:
f784c932ccfd756d01b70b6bb5e09ff62e1b3285 / Locale: fr_FR.UTF-8) and earlier are
not affected.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 128498] OPTIONS DIALOG: "Update Links when Loading" doesn't work for sections

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128498

--- Comment #9 from Dieter  ---
Still present in

Version: 7.3.0.0.alpha1+ (x64) / LibreOffice Community
Build ID: 7b8f630db30ee0066a9f4b6e540368d2fcad7fa8
CPU threads: 4; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL

Steps to reproduce
1. Open attchment 155125
2. Tools -> Options -> LibreOffice Writer -> General
3. Enable "Always" as option for "Update Links when Loading"
4. Add some text to first section.
5. Save document, close and reopen it

Actual result:
Message appears: "The document sections.odt contains one or more links to
external data. Would you like to change the document, and update all links to
get the most recent data? [Yes] [No]

Expected result:
No message or information about automatic update.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 128498] OPTIONS DIALOG: "Update Links when Loading" doesn't work for sections

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128498

sdc.bla...@youmail.dk changed:

   What|Removed |Added

 CC||sdc.bla...@youmail.dk

--- Comment #8 from sdc.bla...@youmail.dk ---
I recognize that you are searching "back" in time-but this seemed the right
place to note that in trying to reproduce this bug in 6.5.0.0.alpha, the link
to the "source" file (and its section) is always lost in the mirror file. 

1.  Insert section (in mirror document), make link to "source" file (and its
section).  (is loaded just fine).  
2.  Save "mirror document" (and check that link is still in section).
3.  Reload "mirror document"  (no query appears about external files) 

Result:  link (and file name) is gone from the section.
(with all 3 option settings (Always, On request, Never).

Version: 6.5.0.0.alpha0+ (x64)
Build ID: 035c7717c135c66c0ec025500b73ae9c13b7c586
CPU threads: 8; OS: Windows 10.0 Build 18363; UI render: GL; VCL: win; 
Locale: da-DK (en_DK); UI-Language: en-US
Calc: threaded
(7. jan. 2020 build)

Filed bug #129883 recently in relation to write protection and losing links in
sections, but now believe that the general problem is that 6.5.0.0.alpha does
not preserve "links" in reloaded documents (nothing to do with write
protection.)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128498] OPTIONS DIALOG: "Update Links when Loading" doesn't work for sections

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128498

--- Comment #7 from Buovjaga  ---
Tried on Win, but seems impossible to bibisect: problem is not seen in the last
commit of 5.1 repo, but is already in the first commit of 5.2 repo!

Tried git checkout HEAD~100 a couple of times with 5.1 repo starting from
master in case it was some "fixed, broken again" type of story, but it kept
working.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128498] OPTIONS DIALOG: "Update Links when Loading" doesn't work for sections

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128498

Xisco Faulí  changed:

   What|Removed |Added

 OS|Windows (All)   |All
Version|6.2.7.1 release |5.2 all versions
   Keywords||bibisectRequest, regression
 CC||r...@post.cz,
   ||todven...@suomi24.fi
   Hardware|x86 (IA32)  |All

--- Comment #6 from Xisco Faulí  ---
Reproduced in

Version: 5.2.0.0.alpha0+
Build ID: 3ca42d8d51174010d5e8a32b96e9b4c0b3730a53
Threads 4; Ver: 4.15; Render: default; 

but not in

Version: 5.0.0.0.alpha1+
Build ID: 0db96caf0fcce09b87621c11b584a6d81cc7df86
Locale: ca-ES (ca_ES.UTF-8)

must be bisected with 5.1 repo

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128498] OPTIONS DIALOG: "Update Links when Loading" doesn't work for sections

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128498

--- Comment #5 from John  ---
(In reply to Xisco Faulí from comment #3)

Thank you for interest. Test document is now attached to the initial post.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128498] OPTIONS DIALOG: "Update Links when Loading" doesn't work for sections

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128498

--- Comment #4 from John  ---
Created attachment 155525
  --> https://bugs.documentfoundation.org/attachment.cgi?id=155525&action=edit
test document

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128498] OPTIONS DIALOG: "Update Links when Loading" doesn't work for sections

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128498

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org

--- Comment #3 from Xisco Faulí  ---
Hello John, Dieter,
Would it be possible to attach a document for easier reproduction ?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128498] OPTIONS DIALOG: "Update Links when Loading" doesn't work for sections

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128498

Dieter Praas  changed:

   What|Removed |Added

 Blocks||113944, 107738
Summary|FILEOPEN: "Update Links |OPTIONS DIALOG: "Update
   |when Loading" doesn't work  |Links when Loading" doesn't
   ||work for sections
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
 CC||dgp-m...@gmx.de

--- Comment #2 from Dieter Praas  ---
I confirm it with

Version: 6.4.0.0.alpha1 (x64)
Build ID: cc57df8f942f239d29cb575ea5a7cb01405db787
CPU threads: 4; OS: Windows 10.0 Build 18362; UI render: GL; VCL: win; 
Locale: de-DE (de_DE); UI-Language: en-US
Calc: threaded


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107738
[Bug 107738] [META] Section bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=113944
[Bug 113944] [META] Options dialog's Writer settings bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs