[Libreoffice-bugs] [Bug 128540] EPUB tool: some Error and Warning discovered after conversion with a validator
https://bugs.documentfoundation.org/show_bug.cgi?id=128540
--- Comment #14 from David Tardon ---
(In reply to Julien Nabet from comment #13)
> Mark: would it be possible to push this straightforward patch for
> "direction" part?
> diff --git a/src/lib/EPUBBodyStyleManager.cpp
> b/src/lib/EPUBBodyStyleManager.cpp
> index 93d9a5d..bedeb43 100644
> --- a/src/lib/EPUBBodyStyleManager.cpp
> +++ b/src/lib/EPUBBodyStyleManager.cpp
> @@ -26,7 +26,6 @@ void
> EPUBBodyStyleManager::extractProperties(RVNGPropertyList const , EPUB
> else // For the rest: lr, lr-tb, rl, rl-tb
> {
>mode = "horizontal-tb";
> - cssProps["direction"] = (mode == "rl-tb" || mode == "rl")?"rtl":"ltr";
> }
>
> cssProps["-epub-writing-mode"] = mode;
No. That just removes the symptom without fixing the problem. The CSS property
*should* be removed, but new code should be added that emits (X)HTML dir
attribute. See https://www.w3.org/International/questions/qa-bidi-css-markup
and https://github.com/w3c/epub-specs/issues/335 for more info.
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128540] EPUB tool: some Error and Warning discovered after conversion with a validator
https://bugs.documentfoundation.org/show_bug.cgi?id=128540
Julien Nabet changed:
What|Removed |Added
CC||mark...@gmail.com
--- Comment #13 from Julien Nabet ---
Mark: would it be possible to push this straightforward patch for "direction"
part?
diff --git a/src/lib/EPUBBodyStyleManager.cpp
b/src/lib/EPUBBodyStyleManager.cpp
index 93d9a5d..bedeb43 100644
--- a/src/lib/EPUBBodyStyleManager.cpp
+++ b/src/lib/EPUBBodyStyleManager.cpp
@@ -26,7 +26,6 @@ void EPUBBodyStyleManager::extractProperties(RVNGPropertyList
const , EPUB
else // For the rest: lr, lr-tb, rl, rl-tb
{
mode = "horizontal-tb";
- cssProps["direction"] = (mode == "rl-tb" || mode == "rl")?"rtl":"ltr";
}
cssProps["-epub-writing-mode"] = mode;
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128540] EPUB tool: some Error and Warning discovered after conversion with a validator
https://bugs.documentfoundation.org/show_bug.cgi?id=128540
--- Comment #12 from stragu ---
Exporting with LO 7.2 alpha1+, and checking with epubcheck 4.2.5, I get the
same warnings and error as Julien:
Validating using EPUB version 3.2 rules.
WARNING(RSC-017):
/home/stragu/Downloads/epub-libreoffice.epub/OEBPS/sections/section0001.xhtml(2,50):
Warning while parsing file: The "head" element should have a "title" child
element.
WARNING(RSC-017):
/home/stragu/Downloads/epub-libreoffice.epub/OEBPS/toc.xhtml(2,93): Warning
while parsing file: The "head" element should have a "title" child element.
ERROR(CSS-001):
/home/stragu/Downloads/epub-libreoffice.epub/OEBPS/styles/stylesheet.css(148,3):
The "direction" property must not be included in an EPUB Style Sheet.
The part of the stylesheet that causes the ERROR(CSS-001) is this one:
.body0 {
-epub-writing-mode: horizontal-tb;
-webkit-writing-mode: horizontal-tb;
direction: ltr;
writing-mode: horizontal-tb;
}
LibreOffice version:
Version: 7.2.0.0.alpha1+ / LibreOffice Community
Build ID: b1c0734ffe0f395757b6e0cea7830d820231afeb
CPU threads: 8; OS: Linux 4.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time:
2021-05-18_03:16:20
Calc: threaded
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128540] EPUB tool: some Error and Warning discovered after conversion with a validator
https://bugs.documentfoundation.org/show_bug.cgi?id=128540 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||114162 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=114162 [Bug 114162] [META] EPUB export bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128540] EPUB tool: some Error and Warning discovered after conversion with a validator
https://bugs.documentfoundation.org/show_bug.cgi?id=128540 --- Comment #11 from f.carbon...@libero.it --- (In reply to Julien Nabet from comment #9) Yes, Julien, these are the same mistakes that I found. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128540] EPUB tool: some Error and Warning discovered after conversion with a validator
https://bugs.documentfoundation.org/show_bug.cgi?id=128540 Julien Nabet changed: What|Removed |Added CC||dtar...@redhat.com --- Comment #10 from Julien Nabet --- David: thought you might be interested in this one since it concerns epub -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128540] EPUB tool: some Error and Warning discovered after conversion with a validator
https://bugs.documentfoundation.org/show_bug.cgi?id=128540 Julien Nabet changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #9 from Julien Nabet --- On pc Debian x86-64 with master sources updated today, I converted your odt file into epub. Then with epubcheck 4.1 from LO Debian testing package repo, I got: Validating using EPUB version 3.2 rules. WARNING(RSC-017): /tmp/epub-libreoffice.epub/OEBPS/sections/section0001.xhtml(2,50): Warning while parsing file: The 'head' element should have a 'title' child element. WARNING(RSC-017): /tmp/epub-libreoffice.epub/OEBPS/toc.xhtml(2,93): Warning while parsing file: The 'head' element should have a 'title' child element. ERROR(CSS-001): /tmp/epub-libreoffice.epub/OEBPS/styles/stylesheet.css(148,3): The 'direction' property must not be included in an EPUB Style Sheet. Check finished with errors Messages: 0 fatals / 1 error / 2 warnings / 0 infos Let's put this one to NEW since there's at least 1 error. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128540] EPUB tool: some Error and Warning discovered after conversion with a validator
https://bugs.documentfoundation.org/show_bug.cgi?id=128540 Julien Nabet changed: What|Removed |Added OS|Windows (All) |All -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128540] EPUB tool: some Error and Warning discovered after conversion with a validator
https://bugs.documentfoundation.org/show_bug.cgi?id=128540 Julien Nabet changed: What|Removed |Added Version|6.3.3.2 release |6.3.2.2 release --- Comment #8 from Julien Nabet --- Version must correspond to the earliest affected one. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128540] EPUB tool: some Error and Warning discovered after conversion with a validator
https://bugs.documentfoundation.org/show_bug.cgi?id=128540 f.carbon...@libero.it changed: What|Removed |Added Version|6.3.2.2 release |6.3.3.2 release -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128540] EPUB tool: some Error and Warning discovered after conversion with a validator
https://bugs.documentfoundation.org/show_bug.cgi?id=128540 --- Comment #7 from f.carbon...@libero.it --- Created attachment 155990 --> https://bugs.documentfoundation.org/attachment.cgi?id=155990=edit The .odt file from which I derived the EPUB file. Hello here the .odt file from which I derived the EPUB file. Sorry for delay. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128540] EPUB tool: some Error and Warning discovered after conversion with a validator
https://bugs.documentfoundation.org/show_bug.cgi?id=128540 Julien Nabet changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #6 from Julien Nabet --- To reproduce the problem, we need the original ODT file not the resulting EPUB file. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128540] EPUB tool: some Error and Warning discovered after conversion with a validator
https://bugs.documentfoundation.org/show_bug.cgi?id=128540 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128540] EPUB tool: some Error and Warning discovered after conversion with a validator
https://bugs.documentfoundation.org/show_bug.cgi?id=128540 --- Comment #5 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128540] EPUB tool: some Error and Warning discovered after conversion with a validator
https://bugs.documentfoundation.org/show_bug.cgi?id=128540 --- Comment #4 from f.carbon...@libero.it --- Created attachment 155507 --> https://bugs.documentfoundation.org/attachment.cgi?id=155507=edit The EPUB that I have tested The .epub is the test book that I have tested. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128540] EPUB tool: some Error and Warning discovered after conversion with a validator
https://bugs.documentfoundation.org/show_bug.cgi?id=128540 f.carbon...@libero.it changed: What|Removed |Added Version|3.3.2 release |6.3.2.2 release --- Comment #3 from f.carbon...@libero.it --- Sorry It's 6.3.2.2. Now Version corrected. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128540] EPUB tool: some Error and Warning discovered after conversion with a validator
https://bugs.documentfoundation.org/show_bug.cgi?id=128540 Julien Nabet changed: What|Removed |Added CC||serval2...@yahoo.fr Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #2 from Julien Nabet --- 3.3.2 is a very old version. Could you give a try to 6.2.8 or brand new 6.3.3? Also, if you still reproduce this, could you attach the file so we can try to reproduce this? Of course, think about sanitizing it (see https://wiki.documentfoundation.org/QA/Bugzilla/Sanitizing_Files_Before_Submission) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128540] EPUB tool: some Error and Warning discovered after conversion with a validator
https://bugs.documentfoundation.org/show_bug.cgi?id=128540 --- Comment #1 from f.carbon...@libero.it --- Created attachment 155455 --> https://bugs.documentfoundation.org/attachment.cgi?id=155455=edit The warning and error that I discovered -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
