[Libreoffice-bugs] [Bug 131199] TIFF import filters missing
https://bugs.documentfoundation.org/show_bug.cgi?id=131199 Caolán McNamara changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |caol...@redhat.com |desktop.org | --- Comment #15 from Caolán McNamara --- I got something now which seems to basically work for the last case: https://gerrit.libreoffice.org/c/core/+/134734 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 131199] TIFF import filters missing
https://bugs.documentfoundation.org/show_bug.cgi?id=131199
--- Comment #14 from Julien Nabet ---
Ok digging a bit more in libtiff/tif_getimage.c TIFFRGBAImageOK method
precisely and here's the pb:
Thread 1 "soffice.bin" hit Breakpoint 1, TIFFRGBAImageOK (tif=0x943a3d0,
emsg=0x7ffdc958f5b0 "") at tif_getimage.c:197
197 if ( td->td_samplesperpixel != 3 ||
colorchannels != 3 || td->td_bitspersample != 8 ) {
(gdb) p td->td_samplesperpixel
$1 = 3
(gdb) p colorchannels
$2 = 3
(gdb) p td->td_bitspersample
$3 = 16
emsg is empty but here's the whole block:
197 if ( td->td_samplesperpixel != 3 || colorchannels != 3 ||
td->td_bitspersample != 8 ) {
198 sprintf(emsg,
199 "Sorry, can not handle image with %s=%"PRIu16", %s=%d and %s=%"PRIu16,
200 "Samples/pixel", td->td_samplesperpixel,
201 "colorchannels", colorchannels,
202 "Bits/sample", td->td_bitspersample);
203 return 0;
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-bugs] [Bug 131199] TIFF import filters missing
https://bugs.documentfoundation.org/show_bug.cgi?id=131199 --- Comment #13 from Julien Nabet --- Searching in libtiff, I see functions like: TIFFCIELabToRGBInit TIFFCIELabToXYZ TIFFXYZToRGB so perhaps there's not much to do since libtiff seems to deal with CIELab -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 131199] TIFF import filters missing
https://bugs.documentfoundation.org/show_bug.cgi?id=131199 --- Comment #12 from Julien Nabet --- I gave a try on gdb, at this line: 204 if (TIFFRGBAImageOK(tif, emsg) && TIFFRGBAImageBegin(, tif, 1, emsg)) it doesn't enter the if block. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 131199] TIFF import filters missing
https://bugs.documentfoundation.org/show_bug.cgi?id=131199 --- Comment #11 from Caolán McNamara --- that 6th one also doesn't open with "eog" for me (well it appears blank), but does seem to work with imagemagicks "display" -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 131199] TIFF import filters missing
https://bugs.documentfoundation.org/show_bug.cgi?id=131199 Julien Nabet changed: What|Removed |Added CC||caol...@redhat.com --- Comment #10 from Julien Nabet --- Caolán: with master sources updated today (11e4235930f05906311f7b70444b0a6487d59a47, tiff: enable webp), I could open 5 on the 6 files. For the 5 OK, I just noticed this log: TIFFReadDirectory: Warning, Unknown field with tag 51168 (0xc7e0) encountered but no big deal I suppose. For the 6th, it's clavijo16bitlab.tiff tiffinfo gives: Image Width: 2601 Image Length: 3503 Resolution: 96, 96 pixels/inch Bits/Sample: 16 Compression Scheme: AdobeDeflate Photometric Interpretation: CIE L*a*b* Orientation: row 0 top, col 0 lhs Samples/Pixel: 3 Rows/Strip: 1 Planar Configuration: single image plane ... so CIE lab. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 131199] TIFF import filters missing
https://bugs.documentfoundation.org/show_bug.cgi?id=131199
Julien Nabet changed:
What|Removed |Added
Severity|normal |enhancement
--- Comment #9 from Julien Nabet ---
I read more about tiff recently and there are 2 things to consider here:
1) in LO, Adobe deflate (compression = 8) isn't taken into account in tiff
import mechanism
2) different photometric interpretation in the 6 files:
Photometric Interpretation: min-is-black
Photometric Interpretation: CIE L*a*b*
Photometric Interpretation: RGB color
Photometric Interpretation: min-is-black
Photometric Interpretation: RGB color
Photometric Interpretation: separated
If I just do "git grep -n nPhotometricInterpretation itiff.cxx"
(see
https://opengrok.libreoffice.org/xref/core/vcl/source/filter/itiff/itiff.cxx?r=891ff133),
I got:
itiff.cxx:77:sal_uInt32 nPhotometricInterpretation;
itiff.cxx:150:, nPhotometricInterpretation(0)
itiff.cxx:377:nPhotometricInterpretation = ReadIntData();
itiff.cxx:378:SAL_INFO("filter.tiff","PhotometricInterpretation: "
<< nPhotometricInterpretation);
itiff.cxx:865: nPlanes == 1 && nPhotometricInterpretation == 2 )
itiff.cxx:906: ( nPhotometricInterpretation == 2 &&
nSamplesPerPixel >= 3 ) ||
itiff.cxx:907: ( nPhotometricInterpretation == 5 &&
nSamplesPerPixel == 3 )
itiff.cxx:927:if (nPhotometricInterpretation == 2)
itiff.cxx:934:else if( nPhotometricInterpretation == 5 &&
nSamplesPerPixel == 4 )
itiff.cxx:977:else if ( nSamplesPerPixel == 1 && (
nPhotometricInterpretation <= 1 || nPhotometricInterpretation == 3 ) )
itiff.cxx:1190:if ( nPhotometricInterpretation <= 1 )
itiff.cxx:1206:if ( nPhotometricInterpretation == 1 )
itiff.cxx:1263: nPhotometricInterpretation == 2;
itiff.cxx:1396:nPhotometricInterpretation = 0;
itiff.cxx:1474:if ( nPhotometricInterpretation == 2 ||
nPhotometricInterpretation == 5 || nPhotometricInterpretation == 6 )
So "CIE L*a*b*" (which has code 8, see
https://www.itu.int/itudoc/itu-t/com16/tiff-fx/docs/tiff6.pdf), isn't
implemented at all.
Quoting again Wikipedia:
"
TIFF is a complex format, defining many tags of which typically only a few are
used in each file. This led to implementations supporting very varying subsets
of the format, a situation that gave rise to the joke that TIFF stands for
Thousands of Incompatible File Formats.[8] This problem was addressed in
revision 6.0[7] of the TIFF specification (June 1992) by introducing a
distinction between Baseline TIFF (which all implementations were required to
support) and TIFF Extensions (which are optional). Additional extensions are
defined in two supplements to the specification, published September 1995[9]
and March 2002,[citation needed] respectively."
I think we should consider this one more than an enhancement and seeing the
number of different combinations in tiff.
The best thing to do would be to use libtiff lib to delegate the tiff
management but Tomaž indicated it required a lot of work.
Now about Irfanview, as an image viewer, we can expect it tries to respond
about its very core feature.
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-bugs] [Bug 131199] TIFF import filters missing
https://bugs.documentfoundation.org/show_bug.cgi?id=131199 --- Comment #8 from Timur --- (In reply to Julien Nabet from comment #7) > If the tiff file is not valid (see > https://bugs.documentfoundation.org/show_bug.cgi?id=131199#c2), we can > expect LO doesn't recognize properly, can't we? I don't know. But image viewer IrfanView opens all 6 of them, so LO should also. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 131199] TIFF import filters missing
https://bugs.documentfoundation.org/show_bug.cgi?id=131199 --- Comment #7 from Julien Nabet --- If the tiff file is not valid (see https://bugs.documentfoundation.org/show_bug.cgi?id=131199#c2), we can expect LO doesn't recognize properly, can't we? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 131199] TIFF import filters missing
https://bugs.documentfoundation.org/show_bug.cgi?id=131199 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||79045_79...@mail.ru --- Comment #6 from Roman Kuznetsov <79045_79...@mail.ru> --- Still rerpo in Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 3ccc4c123f5e78e0204d11abeab2d1a74278ca3e CPU threads: 4; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win Locale: ru-RU (ru_RU); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 131199] TIFF import filters missing
https://bugs.documentfoundation.org/show_bug.cgi?id=131199 m.a.riosv changed: What|Removed |Added Version|6.3.3.2 release |Inherited From OOo --- Comment #4 from m.a.riosv --- It happens with Aoo 4.1.7, so inherited. Not all files open with Photos in win10 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131199] TIFF import filters missing
https://bugs.documentfoundation.org/show_bug.cgi?id=131199 m.a.riosv changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW OS|Windows (All) |All CC||miguelangelrv@libreoffice.o ||rg --- Comment #3 from m.a.riosv --- Repro also Version: 7.0.0.0.alpha0+ (x64) Build ID: cf96cb11e2a46c452a273ded1c66c556118983cf CPU threads: 4; OS: Windows 10.0 Build 19577; UI render: Skia/Raster; VCL: win; Locale: es-ES (es_ES); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131199] TIFF import filters missing
https://bugs.documentfoundation.org/show_bug.cgi?id=131199 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||126152 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=126152 [Bug 126152] [META] Images-TIFF -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131199] TIFF import filters missing
https://bugs.documentfoundation.org/show_bug.cgi?id=131199 Julien Nabet changed: What|Removed |Added CC||serval2...@yahoo.fr --- Comment #2 from Julien Nabet --- On pc Debian x86-64 with master sources updated today, I could reproduce this. But using "tiffinfo" program showed some pb with all the tiffs, eg: tiffinfo -D clavijo8bit.tiff TIFFReadDirectory: Warning, Unknown field with tag 51168 (0xc7e0) encountered. TIFFFetchNormalTag: Warning, Incompatible type for "RichTIFFIPTC"; tag ignored. TIFF Directory at offset 0x4d3dec (5062124) Image Width: 2601 Image Length: 3503 Resolution: 96, 96 pixels/inch Bits/Sample: 8 Compression Scheme: AdobeDeflate Photometric Interpretation: RGB color Orientation: row 0 top, col 0 lhs Samples/Pixel: 3 Rows/Strip: 1 Planar Configuration: single image plane DateTime: 2020:03:07 10:19:17 XMLPacket (XMP Metadata): ... TIFFReadCustomDirectory: Warning, Wrong data type 3 for "PixelXDimension"; tag ignored. TIFFReadCustomDirectory: Warning, Wrong data type 3 for "PixelYDimension"; tag ignored. ... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131199] TIFF import filters missing
https://bugs.documentfoundation.org/show_bug.cgi?id=131199 lbartolome changed: What|Removed |Added CC||lbartol...@gmail.com --- Comment #1 from lbartolome --- Created attachment 158464 --> https://bugs.documentfoundation.org/attachment.cgi?id=158464=edit Samples of different tiff files There are six samples, each with a different filter applied. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
