[Libreoffice-bugs] [Bug 133835] Calc autofilter freeze after deselecting an item (in a column containing many unique string values) and pressing OK

2022-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133835

stragu  changed:

   What|Removed |Added

 Whiteboard|target:7.3.0|target:7.3.0
   |target:7.3.0.0.beta2|target:7.3.0.0.beta2
   ||inReleaseNotes:7.3

--- Comment #31 from stragu  ---
Also verified in:

Version: 7.3.0.2 / LibreOffice Community
Build ID: f1c9017ac60ecca268da7b1cf147b10e244b9b21
CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 133835] Calc autofilter freeze after deselecting an item (in a column containing many unique string values) and pressing OK

2021-12-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133835

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||6382

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 133835] Calc autofilter freeze after deselecting an item (in a column containing many unique string values) and pressing OK

2021-12-03 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133835

Kevin Suo  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||6037

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 133835] Calc autofilter freeze after deselecting an item (in a column containing many unique string values) and pressing OK

2021-11-26 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133835

--- Comment #30 from Commit Notification 
 ---
Noel Grandin committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/216be5dcd987b5d4a9802791a8f78a8e85eb6a79

tdf#133835 speedup calc autofilter (10)

It will be available in 7.3.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 133835] Calc autofilter freeze after deselecting an item (in a column containing many unique string values) and pressing OK

2021-11-26 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133835

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:7.3.0|target:7.3.0
   ||target:7.3.0.0.beta2

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 133835] Calc autofilter freeze after deselecting an item (in a column containing many unique string values) and pressing OK

2021-11-26 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133835

--- Comment #29 from Commit Notification 
 ---
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/0600affd91ca799c75354a8c63d2b40373b08996

tdf#133835 speedup calc autofilter (10)

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 133835] Calc autofilter freeze after deselecting an item (in a column containing many unique string values) and pressing OK

2021-11-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133835

Xisco Faulí  changed:

   What|Removed |Added

   Keywords||perf

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 133835] Calc autofilter freeze after deselecting an item (in a column containing many unique string values) and pressing OK

2021-11-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133835

Kevin Suo  changed:

   What|Removed |Added

 CC||lagoda.n...@gmail.com

--- Comment #28 from Kevin Suo  ---
*** Bug 145765 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 133835] Calc autofilter freeze after deselecting an item (in a column containing many unique string values) and pressing OK

2021-11-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133835

Kevin Suo  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||3828

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 133835] Calc autofilter freeze after deselecting an item (in a column containing many unique string values) and pressing OK

2021-11-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133835

--- Comment #27 from Kevin Suo  ---
This is very nice fix. Autofilter is not instance for all the columns I have
tested. This is now much quicker than MSO in my opinion.

Thank you everyone who have worked on this, especially Noel Grandin and  Luboš
Luňák! Also thanks to Colan who have worked on the autofilter dropdown/submenu
UI related issues.

Next step is to test every corner cases to make sure any regression is captured
and fixed in time. Everyone effected by this (and the duplicated bugs) are
encouraged to use a daily build to test.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 133835] Calc autofilter freeze after deselecting an item (in a column containing many unique string values) and pressing OK

2021-11-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133835

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED
 CC||79045_79...@mail.ru

--- Comment #26 from Roman Kuznetsov <79045_79...@mail.ru> ---
Verified. Around 1-2 sec in

Version: 7.3.0.0.alpha1+ (x64) / LibreOffice Community
Build ID: 515682539623c9d61921c4f89302ffa0a4cb8d24
CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: ru-RU (ru_RU); UI: ru-RU
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 133835] Calc autofilter freeze after deselecting an item (in a column containing many unique string values) and pressing OK

2021-11-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133835

Luboš Luňák  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 133835] Calc autofilter freeze after deselecting an item (in a column containing many unique string values) and pressing OK

2021-11-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133835

--- Comment #25 from Luboš Luňák  ---
https://gerrit.libreoffice.org/c/core/+/125735 (and the preceding changes)
should take care of this.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 133835] Calc autofilter freeze after deselecting an item (in a column containing many unique string values) and pressing OK

2021-11-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133835

--- Comment #24 from Luboš Luňák  ---
*** Bug 133804 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 133835] Calc autofilter freeze after deselecting an item (in a column containing many unique string values) and pressing OK

2021-11-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133835

--- Comment #23 from Commit Notification 
 ---
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/7566479a7a049d0e65d7506bc563e4d1c664b16d

tdf#133835 speedup calc autofilter (11)

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 133835] Calc autofilter freeze after deselecting an item (in a column containing many unique string values) and pressing OK

2021-11-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133835

--- Comment #22 from Noel Grandin  ---
So the SfxPoolItem problem is that we create a SvxFieldItem to represent each
URL, and since there are tons of URLs, we create tons of pool items.

I don't think there is any easy fix for this - IMO we should not be
representing a URL as a pool item at all.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 133835] Calc autofilter freeze after deselecting an item (in a column containing many unique string values) and pressing OK

2021-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133835

--- Comment #21 from Commit Notification 
 ---
Luboš Luňák committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/1a32af4192291ea5cfe7c4c143144a5dab1f156e

cache error strings for ScTable::validQuery()  (tdf#133835)

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 133835] Calc autofilter freeze after deselecting an item (in a column containing many unique string values) and pressing OK

2021-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133835

--- Comment #20 from Luboš Luňák  ---
(In reply to Noel Grandin from comment #16)
> There are several different sources of slowness here.

Yes, this bugreport mixes several different problems :(.

> (2) the QueryEvaluator::compareByStringComparator stuff for which I have no
> suggestion.

I have some ideas there, the problem is not with QueryEvaluator but rather with
ScTable::ValidQuery() being dumb and doing things backwards (comment #2 will
result in a query with thousands of items and they'll be all compared against
the cell instead of searching the items for whether one of them matches the
cell).

> (3) Some intermittent issue with millions of SfxPoolItem, which I suspect is
> a bug because I have seen it only once in about 30 runs.

I can reproduce it reliably with attachment #147829.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 133835] Calc autofilter freeze after deselecting an item (in a column containing many unique string values) and pressing OK

2021-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133835

--- Comment #19 from Commit Notification 
 ---
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/1b327e4a33a2a2c575c247ea90365652d6549852

tdf#133835 speedup calc autofilter (9)

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 133835] Calc autofilter freeze after deselecting an item (in a column containing many unique string values) and pressing OK

2021-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133835

--- Comment #18 from Commit Notification 
 ---
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/a70bd820da49401e7c233ae254ce954954344d33

tdf#133835 speedup calc autofilter (8)

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 133835] Calc autofilter freeze after deselecting an item (in a column containing many unique string values) and pressing OK

2021-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133835

--- Comment #17 from Commit Notification 
 ---
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/a6ed7588114c643a4d4821201e81b149e3429f2c

tdf#133835 speedup calc autofilter (7)

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 133835] Calc autofilter freeze after deselecting an item (in a column containing many unique string values) and pressing OK

2021-11-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133835

--- Comment #16 from Noel Grandin  ---

There are several different sources of slowness here.

(1) The INetURLObject stuff, which I am working on

(2) the QueryEvaluator::compareByStringComparator stuff for which I have no
suggestion.

(3) Some intermittent issue with millions of SfxPoolItem, which I suspect is a
bug because I have seen it only once in about 30 runs.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 133835] Calc autofilter freeze after deselecting an item (in a column containing many unique string values) and pressing OK

2021-11-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133835

--- Comment #15 from Commit Notification 
 ---
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/7805a224b96897807e49fd49dd5276d6089b0b5c

tdf#133835 speedup calc autofilter (6)

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 133835] Calc autofilter freeze after deselecting an item (in a column containing many unique string values) and pressing OK

2021-11-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133835

--- Comment #14 from Kevin Suo  ---
I provided another test ods file in
https://bugs.documentfoundation.org/show_bug.cgi?id=136838#c2

just for your reference.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 133835] Calc autofilter freeze after deselecting an item (in a column containing many unique string values) and pressing OK

2021-11-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133835

--- Comment #13 from Kevin Suo  ---
Thank you Noel Grandin for your hard work on fixing the autofilter slowness.

I see most of your merged patches are on the INetURLObject, and I see the test
document in attachment 147829 does contain URLs. However, I suggest you also
take a look at attachment 165612 as included in bug 136838 (which was marked as
a duplicate of *this* one), that attachment does not contain urls in the cell
content.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 133835] Calc autofilter freeze after deselecting an item (in a column containing many unique string values) and pressing OK

2021-11-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133835

--- Comment #12 from Commit Notification 
 ---
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/dc2010964fb8d18d5c4fe96172ee082276a1e587

tdf#133835 speedup calc autofilter (5)

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 133835] Calc autofilter freeze after deselecting an item (in a column containing many unique string values) and pressing OK

2021-11-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133835

--- Comment #11 from Commit Notification 
 ---
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/0b46361ef84a61100a0274a007062317607d097a

tdf#133835 speedup calc autofilter (4)

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 133835] Calc autofilter freeze after deselecting an item (in a column containing many unique string values) and pressing OK

2021-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133835

--- Comment #10 from BogdanB  ---
Noel, you work hard on autofilter speed. I just wait to test the improvements.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 133835] Calc autofilter freeze after deselecting an item (in a column containing many unique string values) and pressing OK

2021-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133835

--- Comment #9 from Commit Notification 
 ---
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/2aa7aa564f8c8f7d1cd520b3e2d198a17e423a37

tdf#133835 speedup calc autofilter (3)

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 133835] Calc autofilter freeze after deselecting an item (in a column containing many unique string values) and pressing OK

2021-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133835

--- Comment #8 from Commit Notification 
 ---
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/23886b0e023bc27e9ba89f9ab6d1bdf36da022ab

tdf#133835 speedup calc autofilter (2)

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 133835] Calc autofilter freeze after deselecting an item (in a column containing many unique string values) and pressing OK

2021-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133835

--- Comment #7 from Commit Notification 
 ---
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/66317d3aa5ada5b7c5ea317590730f563bebb77c

tdf#133835 speedup calc autofilter (1)

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 133835] Calc autofilter freeze after deselecting an item (in a column containing many unique string values) and pressing OK

2021-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133835

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.3.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 133835] Calc autofilter freeze after deselecting an item (in a column containing many unique string values) and pressing OK

2021-11-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133835

Luboš Luňák  changed:

   What|Removed |Added

 CC||noelgran...@gmail.com

--- Comment #6 from Luboš Luňák  ---
Most of the time spent repeatedly inserting items into SfxPoolItemArray_Impl's
sorted_vector containing a million of items.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 133835] Calc autofilter freeze after deselecting an item (in a column containing many unique string values) and pressing OK

2020-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133835

Kevin Suo  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||3804

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 133835] Calc autofilter freeze after deselecting an item (in a column containing many unique string values) and pressing OK

2020-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133835

Kevin Suo  changed:

   What|Removed |Added

Summary|Calc autofilter freeze  |Calc autofilter freeze
   |after deselecting an item   |after deselecting an item
   |and pressing OK (number 2)  |(in a column containing
   ||many unique string values)
   ||and pressing OK

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs