[Libreoffice-bugs] [Bug 138883] [rfe] Template Manager should give feedback message when it cannot rename a template to an existing name

2020-12-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=138883

--- Comment #13 from sdc.bla...@youmail.dk ---
(In reply to Heiko Tietze from comment #11)
> New and All are the same unless I pick some other which makes All empty.
I think you repro'ed, plus found another?

> Totally broken. IMHO, we should wait for the Refresh patch.
Agreed.

NB - this bug report is only about need for feedback when a template could not
be renamed.  

afaik, there is no "generic" bug report about "need to review refresh in
template manager" (or something like that) -- your recent report and BogdanB's
about deleting categories only reported specific symptoms of the problem, with
my "refresh" query added on in each case to localize the problem. 


(In reply to Heiko Tietze from comment #12)
> added my Download folder
> All sub folders are shown as categories (makes sense) 
I did the same once from Document root. In Windows, it takes a long time to
load.

> but Delete Category asks whether the folder should be deleted. 
Good point!  In such situations, "Rename Category" will also have less than
optimal effect.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 138883] [rfe] Template Manager should give feedback message when it cannot rename a template to an existing name

2020-12-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=138883

--- Comment #12 from Heiko Tietze  ---
Actually I'm much afraid of all these functions. I added my Download folder
(use it as a temp directory) to the templates path. All sub folders are shown
as categories (makes sense) but Delete Category asks whether the folder should
be deleted. I'm not going to say yes here and strongly disagree with the
mixture of internal and file system operations.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 138883] [rfe] Template Manager should give feedback message when it cannot rename a template to an existing name

2020-12-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=138883

--- Comment #11 from Heiko Tietze  ---
(In reply to sdc.blanco from comment #10)
> 5.  Change to "All Categories" and back to "New Category"
>   (shows "alpha")

New and All are the same unless I pick some other which makes All empty.
Totally broken. IMHO, we should wait for the Refresh patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 138883] [rfe] Template Manager should give feedback message when it cannot rename a template to an existing name

2020-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=138883

--- Comment #10 from sdc.bla...@youmail.dk ---
(In reply to Heiko Tietze from comment #9)
> If renaming the templates effects the actual file name
afaict, no.

The change is to File-Properties-Description-Title.

Is this the relevant piece of code?
https://opengrok.libreoffice.org/xref/core/sfx2/source/control/templatelocalview.cxx?r=b541cd9a#189

Possibly we are getting "cheated" by the (lack of) "refresh" problem.

If you can reproduce the following, then I am going to stop trying to figure
out "empirically" what is going on.

1.  "New Category" with one user-defined template in it. 
2.  Rename template to "alpha" (shows "alpha")
3.  Change Category to "All Categories", then back to "New Category" 
 (shows previous template name)
4.  Settings>Refresh (in "New Category")  (still shows previous name)
5.  Change to "All Categories" and back to "New Category"
  (shows "alpha")

But I think/hope this example reveals to a developer where "refresh" and
"canvas" update has to take place.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 138883] [rfe] Template Manager should give feedback message when it cannot rename a template to an existing name

2020-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=138883

Heiko Tietze  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org
   Keywords|needsUXEval |

--- Comment #9 from Heiko Tietze  ---
If renaming the templates effects the actual file name we should definitely
give a warning or better avoid by setting the warning text type.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 138883] [rfe] Template Manager should give feedback message when it cannot rename a template to an existing name

2020-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=138883

--- Comment #8 from sdc.bla...@youmail.dk ---
(In reply to Heiko Tietze from comment #7)
> Screencast
Critical difference:  Your Screencast example uses "All Categories"
Presumably CV is in "share" directory while "test" is in "userprofile"
directory.

See screenshot in attachment 168194 -- all in the same Category (directory).

I predict that will resolve the "mystery" -- and then the original report will
make sense.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 138883] [rfe] Template Manager should give feedback message when it cannot rename a template to an existing name

2020-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=138883

--- Comment #7 from Heiko Tietze  ---
Created attachment 168195
  --> https://bugs.documentfoundation.org/attachment.cgi?id=168195=edit
Screencast

Testing with 6.4 on Linux/kf5

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 138883] [rfe] Template Manager should give feedback message when it cannot rename a template to an existing name

2020-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=138883

--- Comment #6 from sdc.bla...@youmail.dk ---
Created attachment 168194
  --> https://bugs.documentfoundation.org/attachment.cgi?id=168194=edit
Illustration of problem situation

Please see attached screenshot of a Template Manager.
It should be clear that in that image that Template1 is
selected, rename dialog is open, and just about to
(attempt) to rename Template1 to "temp"  (which already
exists in the same category).

When I click OK in that scenario - nothing happens - and
no warning/failure message is given.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 138883] [rfe] Template Manager should give feedback message when it cannot rename a template to an existing name

2020-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=138883

--- Comment #5 from Heiko Tietze  ---
CV is among the shipped templates. I start from Writer and use Documents for
filter and "All Categories".

Version: 6.4.7.2
Build ID: 6.4.7-6
CPU threads: 8; OS: Linux 5.9; UI render: default; VCL: kf5; 
Locale: de-DE (en_US.UTF-8); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 138883] [rfe] Template Manager should give feedback message when it cannot rename a template to an existing name

2020-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=138883

--- Comment #4 from sdc.bla...@youmail.dk ---
(In reply to Heiko Tietze from comment #3)
> I can rename the user-defined template to "CV", for example.
Was there already a CV template in the same directory?  See Step 3: "...enter a
name of another already existing template".

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 138883] [rfe] Template Manager should give feedback message when it cannot rename a template to an existing name

2020-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=138883

--- Comment #3 from Heiko Tietze  ---
I can rename the user-defined template to "CV", for example.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 138883] [rfe] Template Manager should give feedback message when it cannot rename a template to an existing name

2020-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=138883

sdc.bla...@youmail.dk changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

--- Comment #2 from sdc.bla...@youmail.dk ---
(In reply to Heiko Tietze from comment #1)
> What is a non-predefined template?
User-defined.  Stored in {user profile}, not in {install}/share/template/common

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 138883] [rfe] Template Manager should give feedback message when it cannot rename a template to an existing name

2020-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=138883

Heiko Tietze  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO

--- Comment #1 from Heiko Tietze  ---
What is a non-predefined template?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 138883] [rfe] Template Manager should give feedback message when it cannot rename a template to an existing name

2020-12-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=138883

sdc.bla...@youmail.dk changed:

   What|Removed |Added

   Severity|normal  |enhancement
 Blocks||101435
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org
   Keywords||needsUXEval


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=101435
[Bug 101435] [META] Template manager bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs