[Libreoffice-bugs] [Bug 139205] Translated Calc styles lose hirearchical structure
https://bugs.documentfoundation.org/show_bug.cgi?id=139205 Kevin Suo changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |suokunl...@126.com |desktop.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139205] Translated Calc styles lose hirearchical structure
https://bugs.documentfoundation.org/show_bug.cgi?id=139205 Kevin Suo changed: What|Removed |Added Status|ASSIGNED|NEW Assignee|suokunl...@126.com |libreoffice-b...@lists.free ||desktop.org --- Comment #14 from Kevin Suo --- I self-abandoned the patch. This issue need more investigation. Although my patch fixes this bug, the current programmatic <-> display name conversion logic seems to be improved a little bit. For instance, currently in https://opengrok.libreoffice.org/xref/core/sc/source/core/tool/stylehelper.cxx?r=3b6dd549#61 there are duplicated entries in the aCellMap. Also the SC_STYLE_PROG_RESULT1 = u"Result2" seems never used in our code base. In addition, we have already defined the style names in https://opengrok.libreoffice.org/xref/core/sc/inc/globstr.hrc?r=14cfff50#272 so why not use that directly but define additional "programmic names"? Further, in bug 132137 someone tried to improve the Calc style names, but caused regression and thus the patch was reverted. One reason was that they found there should be hard-coded style names someone, without identifying the exact place. So let me think about all these further but it may take time. Set back to NEW in case someone else want to work on this. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139205] Translated Calc styles lose hirearchical structure
https://bugs.documentfoundation.org/show_bug.cgi?id=139205 Kevin Suo changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |suokunl...@126.com |desktop.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139205] Translated Calc styles lose hirearchical structure
https://bugs.documentfoundation.org/show_bug.cgi?id=139205 himajin100...@gmail.com changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||6470 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139205] Translated Calc styles lose hirearchical structure
https://bugs.documentfoundation.org/show_bug.cgi?id=139205 --- Comment #8 from Kevin Suo --- https://opengrok.libreoffice.org/xref/core/sc/source/filter/orcus/interface.cxx?r=20f064c1#2161 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139205] Translated Calc styles lose hirearchical structure
https://bugs.documentfoundation.org/show_bug.cgi?id=139205 --- Comment #7 from Kevin Suo --- Just for those who are interest to debug this, the code realted to the styles.xml processing seams to be in: sc/source/core/tool/stylehelper.cxx -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139205] Translated Calc styles lose hirearchical structure
https://bugs.documentfoundation.org/show_bug.cgi?id=139205 Kevin Suo changed: What|Removed |Added OS|Windows (All) |All -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139205] Translated Calc styles lose hirearchical structure
https://bugs.documentfoundation.org/show_bug.cgi?id=139205 Kevin Suo changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||8475 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139205] Translated Calc styles lose hirearchical structure
https://bugs.documentfoundation.org/show_bug.cgi?id=139205 Kevin Suo changed: What|Removed |Added CC||suokunl...@126.com --- Comment #6 from Kevin Suo --- As Minghua has pointed out in https://bugs.documentfoundation.org/show_bug.cgi?id=138475#c4 The default Calc styles are defined in sc/res/xml/styles.xml. I see in this file that the English hirearchical structure is correctly defined and thus with the English UI this structure is correct: ... ... ... However, for any localized UI, the name Heading is translated thus the style:parent-style-name for the localized "Heading 1" and "Heading 2" should also be the localized "Heading", otherwise they will not find their parent and thus is forced to inherent from the "Default". -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139205] Translated Calc styles lose hirearchical structure
https://bugs.documentfoundation.org/show_bug.cgi?id=139205 Ming Hua changed: What|Removed |Added CC||tima...@gmail.com --- Comment #5 from Ming Hua --- *** Bug 144871 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139205] Translated Calc styles lose hirearchical structure
https://bugs.documentfoundation.org/show_bug.cgi?id=139205
--- Comment #4 from Ming Hua ---
(In reply to Kevin Suo from comment #1)
> I do see the headings styles are inherited from Default, but I also see the
> same with a English UI.
A little more experimentation:
Create a minimal ODS spreadsheet document with Chinese UI, see flat style
structure (all inherit from "默认" (translation for "Default")), save file. Open
file again in English UI, the style names are all back to English, but still
flat (all inherit from "Default").
Create a minimal ODS with English UI, see proper hierarchical style structure,
save file. Open file again in Chinese UI, the style names are now in Chinese
but keep the hierarchy, for example style "好" (translation for "Good") inherits
from "状态" ("Status") which in turn inherits from "默认" ("Default").
All tests are done with 7.2/master daily build:
Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 18e5e948dd66e41f17b0a63bf631d98aee84a03b
CPU threads: 2; OS: Windows 10.0 Build 19041; UI render: Skia/Raster; VCL: win
Locale: zh-CN (zh_CN); UI: en-US/zh-CN
Calc: threaded
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139205] Translated Calc styles lose hirearchical structure
https://bugs.documentfoundation.org/show_bug.cgi?id=139205 Regina Henschel changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW CC||rb.hensc...@t-online.de --- Comment #3 from Regina Henschel --- I see the lost hierarchy in German too. "Heading 1"->"Überschrift 1" has no inheritance. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139205] Translated Calc styles lose hirearchical structure
https://bugs.documentfoundation.org/show_bug.cgi?id=139205 --- Comment #2 from Ming Hua --- Created attachment 168463 --> https://bugs.documentfoundation.org/attachment.cgi?id=168463&action=edit Screenshot with English (USA) UI (In reply to Kevin Suo from comment #1) > Are you sure the inheritance is OK in a English UI (i.e., un-translated > style names)? English (USA) UI works fine for me. Comparable screenshot with Styles sidebar and Modify Styles dialog attached. Are you using en-US (USA) or en-GB (UK) English UI? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139205] Translated Calc styles lose hirearchical structure
https://bugs.documentfoundation.org/show_bug.cgi?id=139205 --- Comment #1 from Kevin Suo --- Are you sure the inheritance is OK in a English UI (i.e., un-translated style names)? I do see the headings styles are inherited from Default, but I also see the same with a English UI. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139205] Translated Calc styles lose hirearchical structure
https://bugs.documentfoundation.org/show_bug.cgi?id=139205 Ming Hua changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||7370 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
