[Libreoffice-bugs] [Bug 139426] Update of Contents is freezing LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=139426 Armin Le Grand changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |armin.le.gr...@me.com |desktop.org | Status|NEW |ASSIGNED --- Comment #15 from Armin Le Grand --- Solution on gerrit (https://gerrit.libreoffice.org/c/core/+/119324), also checked that CppunitTest_sw_mailmerge still works with this. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139426] Update of Contents is freezing LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=139426 --- Comment #14 from Armin Le Grand --- Experimenting with suppressing AssertFlyPages when layout is executed from SwEditShell::UpdateTableOf. Looks good, but needs checking... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139426] Update of Contents is freezing LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=139426 --- Comment #13 from Armin Le Grand --- Tried other solutions, e.g. take out m_pRoot->AssertFlyPages() in SwLayAction::InternalAction - that triggers the adaption from the original fix. It shows that I cannot really do that, loading the testdoc already loops. This shows that orig fix is needed/essential, so need to find a way to fix the special layout action that gets triggered by that menu command... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139426] Update of Contents is freezing LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=139426 --- Comment #12 from Armin Le Grand --- Argh - error in CppunitTest_sw_mailmerge. That's exactly what the original fix fixed - AFAIR. Thus, need to check deeper. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139426] Update of Contents is freezing LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=139426 --- Comment #11 from Armin Le Grand --- I confirm the bibisect too. The problem is that the current implementation tries to not create at a new SwPageFrame a contained SwBodyFrame immediately, but tries to do that on-demand e.g. when PageFormat changed (case RES_FMT_CHG: in SwPageFrame::UpdateAttr_). So the fix 0b53f794ffb2550288610b9488f11fd21ab85aae tries to do this correction when needed. I experimented with removing the block in case RES_FMT_CHG: in SwPageFrame::UpdateAttr_ which solves the loop. It is just unfortunate to create this on-demand while in layout - that restarts the layout and we get the loop. It may also be feasible to add a loop-deathwach-counter to SwLayAction::Action so that when between 392InternalAction(pRenderContext); 393if (RemoveEmptyBrowserPages()) m_bAgain is reset to true to hard break this after a defined number of tries, but better would be if that would not be needed. It *may* be needed/be safer anyways one day... So next I tried to patch the on-demand creation of a SwBodyFrame to a tooling method at SwPageFrame, move the constructor and SwPageFrame::UpdateAttr_ to use this. This leads to surprisingly many places where loops and accesses to data create nullptr-exceptions -> it is just at many places not accepted to not have a Lower() frame in any form (e.g. an instance of SwBodyFrame). After fixing quite some places/exceptions of that kind I gave up and tried next to just always create a SwBodyFrame as Lower() in SwPageFrame constructor. This should make the adaption in SwPageFrame::UpdateAttr_ case RES_FMT_CHG obsolete and solve the problem. Only cost I can see is that maybe in some situations not needed temporary instances of a SwBodyFrame get created and replaced/destroyed again when something is added to the page. Due to so many places not checking for nullptr and thus relying on Lower() to exist this seems a good solution. Need to check what the UnitTest would say to that, preparing possible fix... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139426] Update of Contents is freezing LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=139426 Justin L changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||3098 CC||jl...@mail.com --- Comment #10 from Justin L --- Confirmed the bibisect. Also saw 2019 bug 123098 which also freezes (on fileopen) from the same commit. Unfortunately, simply reverting won't work since I get a SIGSEGV, Segmentation fault unit test failure in CppunitTest_sw_layoutwriter. #0 0x7fffe5b1703a in std::__cxx1998::vector >::size() const (this=0x18) at /usr/include/c++/9/bits/stl_vector.h:916 #1 0x7fffe5da9acc in SwSortedObjs::size() const (this=0x0) at sw/source/core/layout/sortedobjs.cxx:45 #2 0x7fffebb7ae5e in lcl_getVisibleFlyObjRect(SwWrtShell*) (pWrtShell=0x5bb9e460) at sw/qa/extras/layout/layout.cxx:3485 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139426] Update of Contents is freezing LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=139426 --- Comment #9 from Armin Le Grand --- Very strange - I wish I knew more about SW layouting :-( Findings: - taking out the block in sw/source/core/layout/pagechg.cxx lines 572 to 591 makes the problem not happen - is active, that block is triggered again and again, with always new this ptr - if block is in, local var m_bAgain at SwLayAction in sw/source/core/layout/layact.cxx is set back to true between 392InternalAction(pRenderContext); 393if (RemoveEmptyBrowserPages()) - It seems as if that menu command layouting removes that added lower SwBodyFrame again and it gets added again...? - This does not happen at initial layout after loading - why? The code at sw/source/core/layout/pagechg.cxx lines 572 to 591 is AFAIR intended for correcting once after loading...? Not sure what to do here - maybe check if that happened already directly with my older fix added? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139426] Update of Contents is freezing LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=139426
--- Comment #8 from Armin Le Grand ---
Not sure if I am involved, but checking shows that loop is in
void SwLayAction::Action(OutputDevice* pRenderContext)
in sw/source/core/layout/layact.cxx in the loop
while ( IsAgain() )
{
SetAgain(false);
m_bNextCycle = false;
InternalAction(pRenderContext);
if (RemoveEmptyBrowserPages())
SetAgain(true);
}
where local m_bAgain gets re-set to true in InternalAction call and never ends
-> death loop. Checking if removal of that quite long-time done stuff removes
this...
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139426] Update of Contents is freezing LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=139426 Timur changed: What|Removed |Added CC||armin.le.gr...@me.com --- Comment #7 from Timur --- Hello Armin. Here is a regression from your "Make used Pages alive in AssertFlyPages". Please write if you'll work, when possible. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139426] Update of Contents is freezing LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=139426 Timur changed: What|Removed |Added Keywords||bibisected, bisected --- Comment #6 from Timur --- 6.1: commit aa3056a64b992812f01674ab72c99db0d73fa022 Date: Fri Dec 22 05:41:30 2017 +0100 source sha:0b53f794ffb2550288610b9488f11fd21ab85aae previous sha:fadbccc3176044b3642716f5b388a793165da05a author Armin Le Grand 2017-12-20 committer Armin Le Grand 2017-12-20 commit 0b53f794ffb2550288610b9488f11fd21ab85aae (patch) Make used Pages alive in AssertFlyPages There is a case where docs are created/exist that have an empty 2nd page with a single, page-anchored Frame (e.g. graphic), not using a PageBreak. Persistence works in this case due to method AssertFlyPages adding the missing page at end, but when multiple of these docs get serialized (e.g. MailMerge) the problem exists for in-between pages, too, and needs to be corrected. Also need to correct the Pages for the Frames when Pages in that situation were corrected. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139426] Update of Contents is freezing LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=139426 Timur changed: What|Removed |Added Hardware|x86-64 (AMD64) |All Priority|medium |high Severity|normal |major Version|7.0.2.2 release |6.1.6.3 release OS|Linux (All) |All Keywords||regression --- Comment #5 from Timur --- Confirming bug is of little value, it's lost in thousand of other bugs. Key step is tedious determining if regression, and here it is. And finding it. No repro 6.0, repro 6.1 and 7.2+. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139426] Update of Contents is freezing LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=139426 --- Comment #4 from BogdanB --- Created attachment 168707 --> https://bugs.documentfoundation.org/attachment.cgi?id=168707=edit screenshot of the CPU being at 100% -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139426] Update of Contents is freezing LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=139426 BogdanB changed: What|Removed |Added Summary|Update of Contents crash|Update of Contents is ||freezing LibreOffice Version|7.0.4.2 release |7.0.2.2 release Status|NEEDINFO|NEW --- Comment #3 from BogdanB --- Tested in Version: 7.0.4.2 Build ID: dcf040e67528d9187c66b2379df5ea4407429775 CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded I have 4 cores on my computer, one of them is going to 100% and LibreOffice is freezing. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
