[Libreoffice-bugs] [Bug 139723] Tabbed UI buttons have black text which go invisible or lack contrast in OS-level dark mode

2022-09-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139723

--- Comment #14 from stragu  ---
(In reply to Thorsten Wagner from comment #13)
> For tdf#137341 GTK has been fixed only. Screenshots attached to this issue
> look like QT. Probably QT has to be fixed too. Currently I am not building
> for QT, so I am not able to check this further.

Thorsten, all screenshots so far have been shared by users reporting using the
gtk3 VCL (see Description and comments 7 and 8).

I just tested using kf5 and qt5 VCLs (with the tweak for propagating GTK themes
to QT5 apps, described here:
https://askubuntu.com/questions/706528/qt-apps-stopped-inheriting-gtk-themes/748186#748186)
and I couldn't reproduce the bug. So I believe the issue was always GTK-only
and the fix for bug 137341 was enough.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 139723] Tabbed UI buttons have black text which go invisible or lack contrast in OS-level dark mode

2022-09-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139723

--- Comment #13 from Thorsten Wagner  ---
(In reply to Timur from comment #10)
> Bibisect 7.0 Linux.. so not just MacOS commit. 
> 
> authorThorsten Wagner2020-02-23 
> committer Tomaž Vajngerl2020-03-06 
> commit 8d11b953c0a69f4f5eb5ca42dec3812a62d0cd0f (patch)
> tree 4061d4c9cd64871154a1fc843eae5cfbb6d22788
> parent 4ba09be7e260ce2a79a23465db7b2837422cde30 (diff)
> tdf#125532: White text on default/action buttons and selected tabs on macOS
> 
> CC Thorsten please check.

By commit above, additional colors had to be defined. Obviously there is
another part of code which has to be supplemented with definitions for the
additional colors in dark mode. This has been done to fix tdf#137341.

For tdf#137341 GTK has been fixed only. Screenshots attached to this issue look
like QT. Probably QT has to be fixed too. Currently I am not building for QT,
so I am not able to check this further.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 139723] Tabbed UI buttons have black text which go invisible or lack contrast in OS-level dark mode

2022-09-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139723

Xisco Faulí  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||xiscofa...@libreoffice.org
 Resolution|--- |DUPLICATE

--- Comment #12 from Xisco Faulí  ---
This looks like a duplicate of bug 137341

*** This bug has been marked as a duplicate of bug 137341 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 139723] Tabbed UI buttons have black text which go invisible or lack contrast in OS-level dark mode

2022-09-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139723

Timur  changed:

   What|Removed |Added

 CC||quanticcpu2...@gmail.com

--- Comment #11 from Timur  ---
*** Bug 141733 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 139723] Tabbed UI buttons have black text which go invisible or lack contrast in OS-level dark mode

2022-09-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139723

Timur  changed:

   What|Removed |Added

 CC||thorsten.wagne...@gmail.com
   Priority|medium  |high
   Keywords|bibisectRequest |bibisected, bisected

--- Comment #10 from Timur  ---
Bibisect 7.0 Linux.. so not just MacOS commit. 

author  Thorsten Wagner2020-02-23 
committer   Tomaž Vajngerl2020-03-06 
commit  8d11b953c0a69f4f5eb5ca42dec3812a62d0cd0f (patch)
tree4061d4c9cd64871154a1fc843eae5cfbb6d22788
parent  4ba09be7e260ce2a79a23465db7b2837422cde30 (diff)
tdf#125532: White text on default/action buttons and selected tabs on macOS

CC Thorsten please check.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 139723] Tabbed UI buttons have black text which go invisible or lack contrast in OS-level dark mode

2022-04-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139723

stragu  changed:

   What|Removed |Added

   Keywords||bibisectRequest, regression

--- Comment #9 from stragu  ---
This is a regression as I can't reproduce on:

Version: 6.4.7.2
Build ID: 1:6.4.7-0ubuntu0.20.04.4
CPU threads: 8; OS: Linux 5.13; UI render: default; VCL: gtk3; 
Locale: en-AU (en_AU.UTF-8); UI-Language: en-US
Calc: threaded

I suspect the commit identified by a bibisect will be the same as for Bug
137341.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 139723] Tabbed UI buttons have black text which go invisible or lack contrast in OS-level dark mode

2022-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139723

--- Comment #8 from stragu  ---
Created attachment 179446
  --> https://bugs.documentfoundation.org/attachment.cgi?id=179446=edit
Screenshot in LO 7.3, Write vs Calc

Interestingly, the "Insert" drop-down button (in the "Insert" and "References"
tabs) has white text in Writer whereas it has black text in Calc. Also notice
the different font (size?) used in the problematic dropdown buttons: it looks
bigger.

Could this be a hint at where the issue is? Could someone give pointers to
these UI elements, for both Writer and Calc?

Tested with:

Version: 7.3.2.2 / LibreOffice Community
Build ID: 49f2b1bff42cfccbd8f788c8dc32c1c309559be0
CPU threads: 8; OS: Linux 5.13; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 139723] Tabbed UI buttons have black text which go invisible or lack contrast in OS-level dark mode

2021-10-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139723

stragu  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||7341
Crash report or|https://bugs.documentfounda |
crash signature|tion.org/show_bug.cgi?id=13 |
   |7341|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 139723] Tabbed UI buttons have black text which go invisible or lack contrast in OS-level dark mode

2021-10-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139723

stragu  changed:

   What|Removed |Added

 Blocks||143344
Crash report or||https://bugs.documentfounda
crash signature||tion.org/show_bug.cgi?id=13
   ||7341


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=143344
[Bug 143344] [META] Linux Dark Mode bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 139723] Tabbed UI buttons have black text which go invisible or lack contrast in OS-level dark mode

2021-08-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139723

stragu  changed:

   What|Removed |Added

 Blocks|103184, 142074  |107191
 Status|NEEDINFO|NEW
Summary|these buttons are black in  |Tabbed UI buttons have
   |dark mode going invisible   |black text which go
   ||invisible or lack contrast
   ||in OS-level dark mode

--- Comment #7 from stragu  ---
Thank you for clarifying, Stuart!

Confirmed by using the dark mode in GNOME 3.36. Even though the GNOME dark mode
uses a dark grey as a base, it is evident that the button text in question has
either a poor contrast (in the case of GNOME dark mode) or disappears entirely
(for dark modes that use black as a background, as in this bug report's
description).

The buttons in question are the right-hand side menus in the tabbed user
interface, in all ribbons. The File ribbon happens to have two (File and Help),
as well as an extra menu button exhibiting the same issue: Recent Documents.
All other ribbons only have this issue with the right-hand side button of the
same name as the ribbon.

To reproduce:

1. Set the OS's appearance to a dark mode
2. In LibreOffice, set the user interface to Tabbed: View > User Interface... >
Tabbed

Note that this issue also exist for some dropdowns in at least two other user
interfaces: Tabbed Compact and Groupedbar compact.

Changing Blocks to more specific meta bug, and changing the title to more
accurately describe the issue.

Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: 1dd4a80fa076bedb3a82821517036bad8dd79857
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time:
2021-07-26_22:41:19
Calc: threaded


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103184
[Bug 103184] [META] UI theming bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107191
[Bug 107191] [META] Notebookbar theming issues
https://bugs.documentfoundation.org/show_bug.cgi?id=142074
[Bug 142074] [META] Options dialog's Color settings bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.