[Libreoffice-bugs] [Bug 140846] "Contains" in Paragraph Style should identify "Outline" as "Chapter Numbering" and have "Level" before the level number

2021-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=140846

--- Comment #18 from Mike Kaganski  ---
(In reply to sdc.blanco from comment #17)

Exactly :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 140846] "Contains" in Paragraph Style should identify "Outline" as "Chapter Numbering" and have "Level" before the level number

2021-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=140846

--- Comment #17 from sdc.bla...@youmail.dk ---
(In reply to Mike Kaganski from comment #16)
> No. I explicitly mentioned that "That it is different from normal list style
> text is OK".
Just checking to be sure -- given that length was an initial concern.

So it seems then that everything is in place now for "normal" list styles.

And all that is missing is a modification so that "Outline" becomes "Chapter
Numbering" and is not displayed through STR_NUMRULE_ON.  Is that correct?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 140846] "Contains" in Paragraph Style should identify "Outline" as "Chapter Numbering" and have "Level" before the level number

2021-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=140846

--- Comment #16 from Mike Kaganski  ---
(In reply to sdc.blanco from comment #15)
> then shouldn't "Heading" (with a list style) be:
> 
>Western text: Liberation Sans + 14 pt + Numbering 123 + ...
> 
> and if Outline Level 4 was added to that modified Heading, then
> 
>Western text: Liberation Sans + 14 pt + Numbering 123 + 4 

No. I explicitly mentioned that "That it is different from normal list style
text is OK", so it is intended that Heading with your proposed edits should be

  "Western text: Liberation Sans + 14 pt + List style (Numbering 123) + 4 ..."

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 140846] "Contains" in Paragraph Style should identify "Outline" as "Chapter Numbering" and have "Level" before the level number

2021-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=140846

--- Comment #15 from sdc.bla...@youmail.dk ---
(In reply to Mike Kaganski from comment #14)
> "Heading 1" should be:
Ok --just to follow the implications...no provocation intended.  

then shouldn't "Heading" (with a list style) be:

   Western text: Liberation Sans + 14 pt + Numbering 123 + ...

and if Outline Level 4 was added to that modified Heading, then

   Western text: Liberation Sans + 14 pt + Numbering 123 + 4 

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 140846] "Contains" in Paragraph Style should identify "Outline" as "Chapter Numbering" and have "Level" before the level number

2021-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=140846

--- Comment #14 from Mike Kaganski  ---
(In reply to sdc.blanco from comment #13)
"Heading 1" should be:

  "Western text: 130% + bold + Chapter Numbering + 1 + Indent left"

That it is different from normal list style text is OK, since the feature is
quite distinct, and having it displayed differently would even help.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 140846] "Contains" in Paragraph Style should identify "Outline" as "Chapter Numbering" and have "Level" before the level number

2021-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=140846

--- Comment #13 from sdc.bla...@youmail.dk ---
@Mike, let me start from the beginning, to avoid ambiguity, and to point out
what you already know.

1.  We agree that the "Contains" value for unmodified "Heading 1" PS starts
with:

Western text: 130% + bold + Numbering(Outline) + 1 + Indent left

2. And an unmodified "Heading" that gets edited so that a Numbering 123 list
style is applied (in its Outline & Numbering tab) then its "Contains" value
starts with: 

Western text: Liberation Sans + 14 pt + Numbering(Numbering 123) + From

3.  The first appearance of the string "Numbering" in both "Contains" line
comes sw/inc/strings.hrc (and was just changed with bug 140845) so that it will
now appear like this:
List Style: (Outline)(for Heading 1)
List Style: (Numbering 123)  (for modified Heading)

4. One part of the OP here was that "Outline" should be "Chapter Numbering" 
(because that is what appears in the "List Style" property in the Outline
tab)

No new designs.  No additions.  Just using existing interface, but seeking
consistency/clarity in labelling.

If you are unhappy about the length, then it is coming from the already
existing design, not from my proposal. HTH.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 140846] "Contains" in Paragraph Style should identify "Outline" as "Chapter Numbering" and have "Level" before the level number

2021-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=140846

--- Comment #12 from Mike Kaganski  ---
(In reply to sdc.blanco from comment #11)

I read your proposal to have this:

> List Style (Chapter Numbering)

for the case where current style takes part in Chapter Numbering. Am I reading
it wrong?

I argued to that my perception, telling that "List Style (Chapter Numbering)"
is too long, and it should only be "Chapter Numbering".

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 140846] "Contains" in Paragraph Style should identify "Outline" as "Chapter Numbering" and have "Level" before the level number

2021-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=140846

--- Comment #11 from sdc.bla...@youmail.dk ---
(In reply to Mike Kaganski from comment #10)
> No. Exactly "Chapter Numbering", without anything else - to keep it short.
Let me restate/disambiguate like this:

MK proposes (in comment 8):  replace "Numbering^1(Outline)" with "Chapter
Numbering^2"

My response (from comment 9):

"Numbering^1" should be (is now with bug 140845) "List Style"
"Outline" should be "Chapter Numbering^2"  

where ^1 and ^2 are only for identification, not to be included anywhere.

I don't see any disagreement about this change. Do you?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 140846] "Contains" in Paragraph Style should identify "Outline" as "Chapter Numbering" and have "Level" before the level number

2021-03-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=140846

--- Comment #10 from Mike Kaganski  ---
(In reply to sdc.blanco from comment #9)
> I believe it should be:  "Outline" -> "Chapter Numbering".

No. Exactly "Chapter Numbering", without anything else - to keep it short. You
see yourself that when you set simply Outline level for a paragraph style, it
is shown just as "1", without any decoration.

> "Numbering" (in this case) should be "List Style" (per comment 6)
> https://gerrit.libreoffice.org/c/core/+/112213

No. If we have *this* feature named "Chapter Numbering", then here we should
use "Chapter Numbering" - as a special case, to refer to specific thing. Please
no more inconsistencies.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 140846] "Contains" in Paragraph Style should identify "Outline" as "Chapter Numbering" and have "Level" before the level number

2021-03-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=140846

--- Comment #9 from sdc.bla...@youmail.dk ---
(In reply to Mike Kaganski from comment #8)
> replace "Numbering(Outline)" with "Chapter Numbering"
I believe it should be:  "Outline" -> "Chapter Numbering".

"Numbering" (in this case) should be "List Style" (per comment 6)
https://gerrit.libreoffice.org/c/core/+/112213

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 140846] "Contains" in Paragraph Style should identify "Outline" as "Chapter Numbering" and have "Level" before the level number

2021-03-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=140846

--- Comment #8 from Mike Kaganski  ---
(In reply to sdc.blanco from comment #7)
> But the "outline" in Contains, mentioned
> in comment 0, has nothing to do with "Outline Level" -- if that was supposed
> to be the explanation of its meaning.

It is "Numbering based on Outline level". This is how it was created
originally; "Outline numbering" was strongly connected with "Outline level".

But current inconsistent state (chapter numbering in one place, outline in
another, and no connection between those now) is indeed confusing. I am
strongly disagreeing with the "good reason" in comment 5. But whatever...

Maybe changing it in organizer could make sense, but only as a whole: replace
"Numbering(Outline)" with "Chapter Numbering" (having a special case code in
the function managing this).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 140846] "Contains" in Paragraph Style should identify "Outline" as "Chapter Numbering" and have "Level" before the level number

2021-03-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=140846

sdc.bla...@youmail.dk changed:

   What|Removed |Added

 Resolution|WONTFIX |FIXED

--- Comment #7 from sdc.bla...@youmail.dk ---
(In reply to Mike Kaganski from comment #4)
> But have you checked the tabs of the paragraph style dialog? Namely, the one
> named "*Outline* & Numbering"? And the entry there under "*Outline*"
> heading, specifically "*Outline* level"?
Yes, I am familiar with this tab. But the "outline" in Contains, mentioned in
comment 0, has nothing to do with "Outline Level" -- if that was supposed to be
the explanation of its meaning.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 140846] "Contains" in Paragraph Style should identify "Outline" as "Chapter Numbering" and have "Level" before the level number

2021-03-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=140846

--- Comment #6 from Mike Kaganski  ---
(In reply to Heiko Tietze from comment #5)

Generally I like renaming "Numbering" to "List" (or "List Style" where
appropriate) - that's a more correct term.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 140846] "Contains" in Paragraph Style should identify "Outline" as "Chapter Numbering" and have "Level" before the level number

2021-03-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=140846

--- Comment #5 from Heiko Tietze  ---
(In reply to Mike Kaganski from comment #4)
> ... renaming ... brought inconsistency everywhere

Point is that hard-coding strings is never a good idea. Renaming the function
had good reason. But anyway, what do you think in light of "Numbering(Outline)
1" (which is broken despite from the "Outline" part) about changing "Numbering"
to "List Style" (discussed in bug 140845)?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 140846] "Contains" in Paragraph Style should identify "Outline" as "Chapter Numbering" and have "Level" before the level number

2021-03-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=140846

sdc.bla...@youmail.dk changed:

   What|Removed |Added

 Resolution|--- |WONTFIX
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 140846] "Contains" in Paragraph Style should identify "Outline" as "Chapter Numbering" and have "Level" before the level number

2021-03-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=140846

--- Comment #4 from Mike Kaganski  ---
But have you checked the tabs of the paragraph style dialog? Namely, the one
named "*Outline* & Numbering"? And the entry there under "*Outline*" heading,
specifically "*Outline* level"?

The feature *is* called Outline; it was also called then way in the menu,
before renaming into "Chapter Numbering" in tdf#107573, which brought
inconsistency everywhere. Look at bug 107573 comment 3 and bug 107573 comment 5
(especially the latter, which explicitly told "The intent is to only change the
menu label ..." - see how that good intention backfired here).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 140846] "Contains" in Paragraph Style should identify "Outline" as "Chapter Numbering" and have "Level" before the level number

2021-03-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=140846

--- Comment #3 from sdc.bla...@youmail.dk ---
(In reply to Mike Kaganski from comment #2)
> I don't see a problem at the moment.
Look at Contains for Heading 1.

What is the meaning of "Outline" ?

What is the meaning of + 1  (or + n)?

Or try this:

1. Right-click on Heading in Style sidebar and choose "New"
2. Change Outline Level to "Level 3"
3. Press "Apply"
4. Select Organizer tab.

Result:  

Contains:
  3

What does 3 mean?

The issue here is to "give accurate information that can be interpreted
meaningfully". Has nothing to do with "thought it would be nice".

I trust that your objection based on length  is not independent of consequences
for understanding.

> "I had some problem myself
I did have those problems initially when I encountered them (at least in the
sense of being uncertain about their meaning at first glance, and having to try
to work out an interpretation - aided by pretty good knowledge about the
relevant their likely meaning.)

If a user did not know that "Outline" is what "Chapter Numbering" used to be
called, the meaning would be impossible to guess/interpret (and impossible to
find in the dialog).   Same problem with "3".

The Contains information is needed to know what will happen if the Standard
(Set to Parent) button is pressed.  The present information would not be useful
in that situation.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 140846] "Contains" in Paragraph Style should identify "Outline" as "Chapter Numbering" and have "Level" before the level number

2021-03-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=140846

--- Comment #2 from Mike Kaganski  ---
I definitely would dislike any changes that make any strings in the Organizer
description longer. The text there may become long itself because of large
number of properties; to do so, it doesn't need help from us making short
strings longer.

I don't see a problem at the moment, and this request seems to be "I look at
this, and thought it would be nice", not "I had some problem myself, or here
are links from forums with actual user confusion". A change for the change's
sake IMO.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 140846] "Contains" in Paragraph Style should identify "Outline" as "Chapter Numbering" and have "Level" before the level number

2021-03-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=140846

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |needsDevAdvice
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org,
   ||mikekagan...@hotmail.com

--- Comment #1 from Heiko Tietze  ---
If I use New on some existing PS and set an outline level I just get the
number. For example, select Heading, click New at the top-right context menu,
change outline level to Level 1. 

The code pointer for this is CntUInt16Item::GetPresentation() in
svl/source/items/cintitem.cxx, but I'm not sure about the scope of this
function.

The complete string is "Numbering(Outline) + 1" with "Numbering" coming from
STR_NUMRULE_ON (see also bug 140845) and, I guess, "Outline" as defined and
hard-coded with the style. Doubt we can change it.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 140846] "Contains" in Paragraph Style should identify "Outline" as "Chapter Numbering" and have "Level" before the level number

2021-03-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=140846

sdc.bla...@youmail.dk changed:

   What|Removed |Added

 Blocks||108456
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org
   Keywords||needsUXEval
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||0845


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108456
[Bug 108456] [META] Style modify dialog bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs