[Libreoffice-bugs] [Bug 141652] FILESAVE: DOCX: Image distorted after RT
https://bugs.documentfoundation.org/show_bug.cgi?id=141652 Stéphane Guillou (stragu) changed: What|Removed |Added Resolution|--- |WORKSFORME Status|REOPENED|RESOLVED See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||2199 --- Comment #15 from Stéphane Guillou (stragu) --- (In reply to Aron Budea from comment #14) > Created attachment 183620 [details] > Screenshot in LO 7.5 > > I can still see distortion, but it isn't as extreme, please check the > attached screenshot, and compare to what you see. > > This is with LO 7.5.0.0.alpha0+ (cfc8a8f5d841b3f84d207196153be67da7f60652) / > Ubuntu. > I also checked the state right after the revert, and it gave the same > result, perhaps the difference in the distortion comes from a different, > preceding commit. Yes, I confirm Aron's less dramatic stretch. Version: 7.4.3.2 / LibreOffice Community Build ID: 1048a8393ae2eeec98dff31b5c133c5f1d08b890 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: de-DE (en_AU.UTF-8); UI: en-US Calc: threaded However, with a master build from today, I see the issue fixed. Wondering if it's the same fix as for Bug 152199, by Kendy: https://git.libreoffice.org/core/commit/ab080ab1ab3100d9702a745287566b78b8d59e54 Version: 7.5.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 24d7431876e87eba700a9f141dc8e030143a92ad CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141652] FILESAVE: DOCX: Image distorted after RT
https://bugs.documentfoundation.org/show_bug.cgi?id=141652 --- Comment #14 from Aron Budea --- Created attachment 183620 --> https://bugs.documentfoundation.org/attachment.cgi?id=183620=edit Screenshot in LO 7.5 I can still see distortion, but it isn't as extreme, please check the attached screenshot, and compare to what you see. This is with LO 7.5.0.0.alpha0+ (cfc8a8f5d841b3f84d207196153be67da7f60652) / Ubuntu. I also checked the state right after the revert, and it gave the same result, perhaps the difference in the distortion comes from a different, preceding commit. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141652] FILESAVE: DOCX: Image distorted after RT
https://bugs.documentfoundation.org/show_bug.cgi?id=141652 --- Comment #13 from Rajasekaran Karunanithi --- Can't reproduce in L.O 7.4.2.3 under Windows 10(x64).The generated docx file looks fine. No distorted sunflower image. Version: 7.4.2.3 (x64) / LibreOffice Community Build ID: 382eef1f22670f7f4118c8c2dd222ec7ad009daf CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: ta-IN (en_IN); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141652] FILESAVE: DOCX: Image distorted after RT
https://bugs.documentfoundation.org/show_bug.cgi?id=141652 Justin L changed: What|Removed |Added Whiteboard|target:7.4.0 target:7.3.1 |fixed:7.3.1 reverted:7.3.6 |target:7.5.0 target:7.4.1 | |target:7.3.6| Regression By||gulsah.k...@collabora.com --- Comment #12 from Justin L --- The bug was re-opened because the (now reverted) fix caused regression bug 150061. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141652] FILESAVE: DOCX: Image distorted after RT
https://bugs.documentfoundation.org/show_bug.cgi?id=141652 --- Comment #11 from Commit Notification --- Justin Luth committed a patch related to this issue. It has been pushed to "libreoffice-7-3": https://git.libreoffice.org/core/commit/5397ff649deadc301d9c3f1187814c91f8e7f77b Revert "tdf#141652 partial revert "Reset ShapeProperty priority..." It will be available in 7.3.6. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141652] FILESAVE: DOCX: Image distorted after RT
https://bugs.documentfoundation.org/show_bug.cgi?id=141652 Commit Notification changed: What|Removed |Added Whiteboard|target:7.4.0 target:7.3.1 |target:7.4.0 target:7.3.1 |target:7.5.0 target:7.4.1 |target:7.5.0 target:7.4.1 ||target:7.3.6 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141652] FILESAVE: DOCX: Image distorted after RT
https://bugs.documentfoundation.org/show_bug.cgi?id=141652 Justin L changed: What|Removed |Added Assignee|jl...@mail.com |libreoffice-b...@lists.free ||desktop.org -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141652] FILESAVE: DOCX: Image distorted after RT
https://bugs.documentfoundation.org/show_bug.cgi?id=141652 Justin L changed: What|Removed |Added Status|NEW |RESOLVED Assignee|libreoffice-b...@lists.free |jl...@mail.com |desktop.org | Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141652] FILESAVE: DOCX: Image distorted after RT
https://bugs.documentfoundation.org/show_bug.cgi?id=141652 --- Comment #6 from Commit Notification --- Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/18cc1240565e697859dd7d17058f91d5e01df929 tdf#141652 partial revert "Reset ShapeProperty priority... It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141652] FILESAVE: DOCX: Image distorted after RT
https://bugs.documentfoundation.org/show_bug.cgi?id=141652 Commit Notification changed: What|Removed |Added Whiteboard||target:7.4.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141652] FILESAVE: DOCX: Image distorted after RT
https://bugs.documentfoundation.org/show_bug.cgi?id=141652 --- Comment #5 from Justin L --- At export time, the difference is oox/source/export/drawingml.cxx:1763: ::WriteXGraphicStretch [600x401] crop right[-769] instead of oox/source/export/drawingml.cxx:1763: ::WriteXGraphicStretch [10160x6790] crop right[-769] The function calls ::SetFillBitmap and ::SetFillBitmapName are very similar, except the prior having the clause if (!maShapePropInfo.mbNamedFillBitmap) return setAnyProperty(nPropId, rValue); which is followed in this case. Proposed partial revert at http://gerrit.libreoffice.org/c/core/+/128260 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141652] FILESAVE: DOCX: Image distorted after RT
https://bugs.documentfoundation.org/show_bug.cgi?id=141652 Justin L changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||4210 --- Comment #4 from Justin L --- All of these import-only changes started with LO 7.1.1 in order to fix bug 134210. Since this is an export bug, probably it has just exposed something else. The order was initial addition of the entire problematic "if(bIsCustomShape)" clause in commit 2c96bd26ec488d865370fe9d394e7c4e228e05ab on 2021-01-21 10:52:46. Then it changed to if(bIsCustomShape && ( aGraphCrop.Left != 0 || aGraphCrop.Right != 0 || aGraphCrop.Top != 0 || aGraphCrop.Bottom != 0)) in commit 7400372efb3d279225a966a355644d2a3e7d42c3 on Feb 23 16:41:15 2021 and finally to "if(bIsCustomShape && bHasCropValues && bNeedCrop)" in comment 1's commit on 2021-03-03 13:19:08. Export seems to be multiplying the crop component in the case of exporting a FillBitmapName, but not if just FillBitmap as indicated in comment 2. The addition of FillBitmapName looks like a copy/paste from elsewhere in this file (based on review history). I personally have no idea about shapes, so I don't know why one version should be chosen over another. The easy fix here seems to only use FillBitmap as was done in earlier versions of the patch series. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141652] FILESAVE: DOCX: Image distorted after RT
https://bugs.documentfoundation.org/show_bug.cgi?id=141652 --- Comment #3 from Justin L --- Xisco backported the fix to 7.1. Not sure exactly which point release it was, but the time was Mar 10, 2021 10:14. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141652] FILESAVE: DOCX: Image distorted after RT
https://bugs.documentfoundation.org/show_bug.cgi?id=141652 --- Comment #2 from Justin L --- I thought it was a FILEOPEN problem because if I revert, then all previously round-tripped files opened OK. But in Word 2016 they looked stretched out. So it must be a file-save problem after all. - rPropMap.setProperty(ShapeProperty::FillBitmap, xGraphic); + if (rPropMap.supportsProperty(ShapeProperty::FillBitmapName)) + rPropMap.setProperty(ShapeProperty::FillBitmapName, xGraphic); + else + rPropMap.setProperty(ShapeProperty::FillBitmap, xGraphic); -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141652] FILESAVE: DOCX: Image distorted after RT
https://bugs.documentfoundation.org/show_bug.cgi?id=141652 BogdanB changed: What|Removed |Added CC||buzea.bog...@libreoffice.or ||g Blocks||104468 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=104468 [Bug 104468] [META] DOCX (OOXML) image-related issues -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141652] FILESAVE: DOCX: Image distorted after RT
https://bugs.documentfoundation.org/show_bug.cgi?id=141652 Xisco Faulí changed: What|Removed |Added Keywords||bibisected, bisected, ||regression Ever confirmed|0 |1 Status|UNCONFIRMED |NEW CC||gulsah.k...@collabora.com, ||xiscofa...@libreoffice.org --- Comment #1 from Xisco Faulí --- Regression introduced by: https://cgit.freedesktop.org/libreoffice/core/commit/?id=b90a67838e189f3aee6a50724c78c0a50d416970 author Gülşah Köse 2021-02-24 15:05:01 +0300 committer Gülşah Köse 2021-03-03 13:19:08 +0100 commit b90a67838e189f3aee6a50724c78c0a50d416970 (patch) treeb8a993e271d5467bde23a3fd046d2be8e9129b0c parent ca98e505cd69bf95d8ddb9387cf3f8e03ae4577d (diff) Reset ShapeProperty priority and handle only crop case. Bisected with: bibisect-linux64-7.2 Adding Cc: to Gülşah Köse -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
