[Libreoffice-bugs] [Bug 144915] "The dictionary is already full" when adding new word to dictionary

2023-01-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=144915

Caolán McNamara  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |caol...@redhat.com
   |desktop.org |
 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144915] "The dictionary is already full" when adding new word to dictionary

2023-01-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=144915

--- Comment #6 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/bd0b3aac25b5163ae21fff613131cb3ff068e816

tdf#144915 effectively remove limit on number of words in dictionary

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144915] "The dictionary is already full" when adding new word to dictionary

2023-01-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=144915

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.6.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144915] "The dictionary is already full" when adding new word to dictionary

2023-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=144915

--- Comment #5 from Shantanu  ---
A workaround is to create a new custom dictionary that will allow another set
of 30,000 words! I think there is no need of such restriction.

I can reproduce using Marathi(IN) Dictionary.

Version: 7.4.3.2 (x64) / LibreOffice Community
Build ID: 1048a8393ae2eeec98dff31b5c133c5f1d08b890
CPU threads: 1; OS: Windows 10.0 Build 14393; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144915] "The dictionary is already full" when adding new word to dictionary

2023-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=144915

Caolán McNamara  changed:

   What|Removed |Added

 CC||caol...@redhat.com

--- Comment #4 from Caolán McNamara  ---
If the issue is the 30,000 limit we could just remove the limit. Its unclear
why there is a limit there. https://gerrit.libreoffice.org/c/core/+/145916
would do that, and presumably let us find out why there is a limit :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144915] "The dictionary is already full" when adding new word to dictionary

2023-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=144915

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Status|NEEDINFO|NEW
 Blocks||108728
 CC||stephane.guillou@libreoffic
   ||e.org
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||2110
Summary|problem with vocabulary |"The dictionary is already
   |replenishment   |full" when adding new word
   ||to dictionary

--- Comment #3 from Stéphane Guillou (stragu) 
 ---
I assume the string is "The dictionary is already full" in English.

It is defined here:
https://opengrok.libreoffice.org/xref/core/include/editeng/editrids.hrc?r=f7f0f399#308
And it is only used here:
https://opengrok.libreoffice.org/xref/core/editeng/source/misc/unolingu.cxx?r=91fef4a4#738

This is triggered if the dictionary has 30,000 or more entries.
Size is checked in DictionaryNeo::isFull() here:
https://opengrok.libreoffice.org/xref/core/linguistic/source/dicimp.cxx?r=3d236177#920

DIC_MAX_ENTRIES limit of 30,000 is defined here:
https://opengrok.libreoffice.org/xref/core/linguistic/source/dicimp.hxx?r=fd3888c6&fi=DIC_MAX_ENTRIES#33

Not sure why this hard limit. I don't see it documented:
https://help.libreoffice.org/7.4/en-US/text/shared/optionen/01010400.html

Any reason for this hard 30,000 limit?
Should this report be changed into a documentation issue?


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108728
[Bug 108728] [META] Dictionaries bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.