[Libreoffice-bugs] [Bug 145614] Convert #define to enum or constexpr
https://bugs.documentfoundation.org/show_bug.cgi?id=145614 Commit Notification changed: What|Removed |Added Whiteboard|target:7.4.0 target:7.5.0 |target:7.4.0 target:7.5.0 |target:7.6.0|target:7.6.0 target:24.2.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145614] Convert #define to enum or constexpr
https://bugs.documentfoundation.org/show_bug.cgi?id=145614 --- Comment #15 from Commit Notification --- Jani Saranpää committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/cccfc2e705b3708854dc2de8bcc602fa45fdb5a8 tdf#145614 Convert #define to enum in propctrlr/fontitemids.hxx It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145614] Convert #define to enum or constexpr
https://bugs.documentfoundation.org/show_bug.cgi?id=145614 --- Comment #14 from Commit Notification --- MoazAlaa committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/9b631efd012c94d099b0181c5d85aed321d031f5 tdf#145614 convert all #define into enum in hwpfilter/source/grammar.h It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145614] Convert #define to enum or constexpr
https://bugs.documentfoundation.org/show_bug.cgi?id=145614 --- Comment #13 from Commit Notification --- Rasenkai committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/0e09fff5f89b38245b108edb67d5e75e57774874 tdf#145614 chart2: controller: Convert #define to enum It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145614] Convert #define to enum or constexpr
https://bugs.documentfoundation.org/show_bug.cgi?id=145614 Commit Notification changed: What|Removed |Added Whiteboard|target:7.4.0 target:7.5.0 |target:7.4.0 target:7.5.0 ||target:7.6.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145614] Convert #define to enum or constexpr
https://bugs.documentfoundation.org/show_bug.cgi?id=145614 --- Comment #12 from Commit Notification --- Liu Hao committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/aea89831f93b501738e62db9787a1085fd483193 tdf#145614 Convert #define to enum or constexpr It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145614] Convert #define to enum or constexpr
https://bugs.documentfoundation.org/show_bug.cgi?id=145614 --- Comment #11 from Commit Notification --- ehsan committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/9b5f0234da27a674a939941d89975bc5a365f7ae tdf#145614 Convert #define to constexpr It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145614] Convert #define to enum or constexpr
https://bugs.documentfoundation.org/show_bug.cgi?id=145614 Commit Notification changed: What|Removed |Added Whiteboard|target:7.4.0|target:7.4.0 target:7.5.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145614] Convert #define to enum or constexpr
https://bugs.documentfoundation.org/show_bug.cgi?id=145614 Xisco Faulí changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||8359 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145614] Convert #define to enum or constexpr
https://bugs.documentfoundation.org/show_bug.cgi?id=145614 --- Comment #10 from Commit Notification --- offtkp committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/64888968b30fb387d8c2536664117915e5423b0c tdf#145614 Convert #define to constexpr It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145614] Convert #define to enum or constexpr
https://bugs.documentfoundation.org/show_bug.cgi?id=145614 --- Comment #9 from Commit Notification --- Deep17 committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/d84ea3c8744aa5a125cec56574c1b943e768b70a tdf#145614 Convert #define to enum or constexpr It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145614] Convert #define to enum or constexpr
https://bugs.documentfoundation.org/show_bug.cgi?id=145614 --- Comment #8 from Commit Notification --- Deep17 committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/b3bd864f7c05c3c794b431dea2ec91ad459812e7 tdf#145614 Convert #define to enum or constexpr It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145614] Convert #define to enum or constexpr
https://bugs.documentfoundation.org/show_bug.cgi?id=145614 --- Comment #7 from Commit Notification --- Hossein committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/3e7dd04dd8ca1baea4b7918eb7a7080c595c4625 tdf#145614 Convert #define to enum and constexpr It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145614] Convert #define to enum or constexpr
https://bugs.documentfoundation.org/show_bug.cgi?id=145614 --- Comment #6 from Commit Notification --- Ramreiso Kashung committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/124059f64a87d8074a0be32d6cc5f74c71bf836e tdf#145614: Convert #define to enum It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145614] Convert #define to enum or constexpr
https://bugs.documentfoundation.org/show_bug.cgi?id=145614 --- Comment #5 from Commit Notification --- VaibhavMalik4187 committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/40bab1e31c7865f8c45883b8e4b684c0134b9191 tdf#145614 Convert #define to enum or constexpr It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145614] Convert #define to enum or constexpr
https://bugs.documentfoundation.org/show_bug.cgi?id=145614 Michael Warner changed: What|Removed |Added Blocks||143781 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=143781 [Bug 143781] [META] Development- and code-related bug reports -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145614] Convert #define to enum or constexpr
https://bugs.documentfoundation.org/show_bug.cgi?id=145614 --- Comment #4 from Commit Notification --- Pesi Taototo committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/47503fce3ebc0874534175c0d9ea40d3a5bbffde tdf#145614 Convert #define to 'enum class' It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145614] Convert #define to enum or constexpr
https://bugs.documentfoundation.org/show_bug.cgi?id=145614 Commit Notification changed: What|Removed |Added Whiteboard||target:7.4.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145614] Convert #define to enum or constexpr
https://bugs.documentfoundation.org/show_bug.cgi?id=145614 Kevin Suo changed: What|Removed |Added CC||suokunl...@126.com Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #3 from Kevin Suo --- Set to New as this is an easy hack. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145614] Convert #define to enum or constexpr
https://bugs.documentfoundation.org/show_bug.cgi?id=145614
--- Comment #2 from Hossein ---
(In reply to Stephan Bergmann from comment #1)
> (In reply to Hossein from comment #0)
> > /* Mapping modes */
> > enum MappingMode
> > {
> > MM_TEXT= 0x01,
> > MM_LOMETRIC= 0x02,
> > MM_HIMETRIC= 0x03,
> > MM_LOENGLISH = 0x04,
> > MM_HIENGLISH = 0x05,
> > MM_TWIPS = 0x06,
> > MM_ISOTROPIC = 0x07,
> > MM_ANISOTROPIC = 0x08
> > };
>
> Why change the values from decimal to hexadecimal?
That's the way they are defined in [MS-WMF] documentation:
https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-wmf/97b31821-a0db-4113-a210-fffbcedcec4a
In some enumerations in the same file, I had to add some values that were
missing. So, when the source of the enum definition is known, I think using the
same definitions can help avoid mistakes. If possible, using the same name
would also be good.
> > constexpr sal_Int32 LF_FACESIZE = 32;
>
> I guess some explanation is needed what type to use (`sal_Int32` will not be
> the best choice in general; even `auto` may be an appropriate choice).
Correct. I will add some explanation for this.
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145614] Convert #define to enum or constexpr
https://bugs.documentfoundation.org/show_bug.cgi?id=145614
Stephan Bergmann changed:
What|Removed |Added
CC||sberg...@redhat.com
--- Comment #1 from Stephan Bergmann ---
(In reply to Hossein from comment #0)
> /* Mapping modes */
> enum MappingMode
> {
> MM_TEXT= 0x01,
> MM_LOMETRIC= 0x02,
> MM_HIMETRIC= 0x03,
> MM_LOENGLISH = 0x04,
> MM_HIENGLISH = 0x05,
> MM_TWIPS = 0x06,
> MM_ISOTROPIC = 0x07,
> MM_ANISOTROPIC = 0x08
> };
Why change the values from decimal to hexadecimal?
> constexpr sal_Int32 LF_FACESIZE = 32;
I guess some explanation is needed what type to use (`sal_Int32` will not be
the best choice in general; even `auto` may be an appropriate choice).
--
You are receiving this mail because:
You are the assignee for the bug.
