[Libreoffice-bugs] [Bug 145759] Use symbolic constants instead of magic numerical constants
https://bugs.documentfoundation.org/show_bug.cgi?id=145759 --- Comment #13 from Commit Notification --- OmkarAcharekar committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/4cec1ec1d575ff0328f014de57abb591e3c7ae11 tdf#145759 Use symbolic constants instead of magic numerical constants It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145759] Use symbolic constants instead of magic numerical constants
https://bugs.documentfoundation.org/show_bug.cgi?id=145759 Commit Notification changed: What|Removed |Added Whiteboard|target:7.4.0 reviewed:2022 |target:7.4.0 reviewed:2022 ||target:7.5.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145759] Use symbolic constants instead of magic numerical constants
https://bugs.documentfoundation.org/show_bug.cgi?id=145759 Hossein changed: What|Removed |Added Whiteboard|target:7.4.0|target:7.4.0 reviewed:2022 --- Comment #12 from Hossein --- Re-evaluating the EasyHack in 2022 This enhancement to the code is still relevant. One may find more places in the code where symbolic constants can be used instead of magic numerical constants. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145759] Use symbolic constants instead of magic numerical constants
https://bugs.documentfoundation.org/show_bug.cgi?id=145759 Hossein changed: What|Removed |Added Assignee|m.ehsan.movahed...@gmail.co |libreoffice-b...@lists.free |m |desktop.org --- Comment #11 from Hossein --- @Ehsan: This is a multi-hacker EasyHack. You can work on it without assigning it to yourself. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145759] Use symbolic constants instead of magic numerical constants
https://bugs.documentfoundation.org/show_bug.cgi?id=145759 ehsan changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |m.ehsan.movahed...@gmail.co |desktop.org |m -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145759] Use symbolic constants instead of magic numerical constants
https://bugs.documentfoundation.org/show_bug.cgi?id=145759 --- Comment #10 from Commit Notification --- Hossein committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/0308e48e46cee2f56a6239c8479d26185146d74a tdf#145759 30.6001 -> monthDaysWithoutJanFeb It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145759] Use symbolic constants instead of magic numerical constants
https://bugs.documentfoundation.org/show_bug.cgi?id=145759 --- Comment #9 from Commit Notification --- Kunal Pawar committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/49746f40b06eaf1f61bb54454408a06a49d73c5e tdf#145759 Use symbolic constants instead of magic numerical constants It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145759] Use symbolic constants instead of magic numerical constants
https://bugs.documentfoundation.org/show_bug.cgi?id=145759 --- Comment #8 from Commit Notification --- pragat-pandya committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/5f21eaa0e6b68926cacc949b9a55d545088f tdf#145759 Using M_PI from cmath instead of magic constants. It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145759] Use symbolic constants instead of magic numerical constants
https://bugs.documentfoundation.org/show_bug.cgi?id=145759 Commit Notification changed: What|Removed |Added Whiteboard||target:7.4.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145759] Use symbolic constants instead of magic numerical constants
https://bugs.documentfoundation.org/show_bug.cgi?id=145759 --- Comment #7 from Kunal Pawar --- I have tried updating some of the constants. https://gerrit.libreoffice.org/c/core/+/129745 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145759] Use symbolic constants instead of magic numerical constants
https://bugs.documentfoundation.org/show_bug.cgi?id=145759 Michael Warner changed: What|Removed |Added Blocks||143781 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=143781 [Bug 143781] [META] Development- and code-related bug reports -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145759] Use symbolic constants instead of magic numerical constants
https://bugs.documentfoundation.org/show_bug.cgi?id=145759 --- Comment #6 from Kunal Pawar --- Where should be define the variables, especially in case of multiple values in same file? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145759] Use symbolic constants instead of magic numerical constants
https://bugs.documentfoundation.org/show_bug.cgi?id=145759 Buovjaga changed: What|Removed |Added CC||pragat.pan...@gmail.com --- Comment #5 from Buovjaga --- (In reply to Libreoffice user SSO from comment #4) > I tried suggested approach in the description. but the command "git grep -n > -Ff constants.txt *.cxx *.hxx" or "git grep -Ff constants.txt *.cxx *.hxx" > is not generating any output. So, my conclusion is that no constants from > given wikipedia article are used in any c++ files. > > My constants.txt contains constants in following pattern: > const-name > . > . > . Don't use such a pattern, just have one value per line :) 3.14159 1.41421 and so forth -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145759] Use symbolic constants instead of magic numerical constants
https://bugs.documentfoundation.org/show_bug.cgi?id=145759 --- Comment #4 from Libreoffice user SSO --- I tried suggested approach in the description. but the command "git grep -n -Ff constants.txt *.cxx *.hxx" or "git grep -Ff constants.txt *.cxx *.hxx" is not generating any output. So, my conclusion is that no constants from given wikipedia article are used in any c++ files. My constants.txt contains constants in following pattern: const-name . . . -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145759] Use symbolic constants instead of magic numerical constants
https://bugs.documentfoundation.org/show_bug.cgi?id=145759 Hossein changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||6479 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145759] Use symbolic constants instead of magic numerical constants
https://bugs.documentfoundation.org/show_bug.cgi?id=145759 Buovjaga changed: What|Removed |Added Status|ASSIGNED|NEW Assignee|somyasrivastava...@gmail.co |libreoffice-b...@lists.free |m |desktop.org --- Comment #3 from Buovjaga --- Multi-hack, no need to assign -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145759] Use symbolic constants instead of magic numerical constants
https://bugs.documentfoundation.org/show_bug.cgi?id=145759 Somya Srivastava changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |somyasrivastava...@gmail.co |desktop.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145759] Use symbolic constants instead of magic numerical constants
https://bugs.documentfoundation.org/show_bug.cgi?id=145759 --- Comment #2 from Somya Srivastava --- Hi! I would like to work on this issue. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145759] Use symbolic constants instead of magic numerical constants
https://bugs.documentfoundation.org/show_bug.cgi?id=145759 Xisco Faulí changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||xiscofa...@libreoffice.org Ever confirmed|0 |1 --- Comment #1 from Xisco Faulí --- Moving to NEW -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145759] Use symbolic constants instead of magic numerical constants
https://bugs.documentfoundation.org/show_bug.cgi?id=145759 Hossein changed: What|Removed |Added Summary|Convert magic numerical |Use symbolic constants |constants to symbolic |instead of magic numerical |constants |constants -- You are receiving this mail because: You are the assignee for the bug.
