[Libreoffice-bugs] [Bug 146007] FilePicker dialog execute method hangs LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=146007 Mike Kaganski changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |mikekagan...@hotmail.com |desktop.org | Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146007] FilePicker dialog execute method hangs LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=146007 --- Comment #9 from Matt K --- I looked further and I'm seeing that the latest version hangs when clicking on the macro, but when I look at it in the debugger it doesn't hang and works as expected. Must be some kind of timing issue or something related to how UNO works in dispatching. It's also worth noting that the macro causes the file picker to be opened on a background thread, but surprisingly it doesn't crash when cancelling a long running search operation as it was before bug 106282 was fixed. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146007] FilePicker dialog execute method hangs LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=146007 --- Comment #8 from Matt K --- I've attached a file with the callstacks for normal file open scenarios. It looks like we could change the "macro in app" path to use reflection just as is done in the IDE callstack which also happens on the main thread. There may be a easier solution but I can't seem to get a build of LO with symbols with the old behavior to see what we were doing before and see what changed. I tried checking out a tag on git and downloading an archived version, but can't get any symbols working yet. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146007] FilePicker dialog execute method hangs LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=146007 --- Comment #7 from Matt K --- Created attachment 179869 --> https://bugs.documentfoundation.org/attachment.cgi?id=179869&action=edit Callstacks for recent LO build in file open scenarios (including macro in IDE) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146007] FilePicker dialog execute method hangs LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=146007 --- Comment #6 from Matt K --- (In reply to Andreas Heinisch from comment #5) > Adding Cc: to Matt K and Mike Kaganski; Could you possibly take a look at > this one? Thank you! I took a quick look and it seems like the main thread is blocked waiting for something to happen. I'm not familiar with how macros use (or don't) the main thread, but if the main thread is blocked before the file picker opens it could just be an endless wait situation/deadlock. Haven't debugged enough to say more or suggest a solution. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146007] FilePicker dialog execute method hangs LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=146007 Andreas Heinisch changed: What|Removed |Added CC||matt...@gmail.com, ||mikekagan...@hotmail.com Keywords|bibisectRequest |bibisected, bisected, ||regression --- Comment #5 from Andreas Heinisch --- This seems to have begun at the below commit. Adding Cc: to Matt K and Mike Kaganski; Could you possibly take a look at this one? Thank you! commit 1c1226709c6be39c5462f5e6e1262ca630b30b34 author Matt K Wed Apr 21 17:34:16 2021 -0500 committer Mike Kaganski Thu Apr 22 22:20:55 2021 +0200 tree14dc0f683da5bc6c8e08ea7db516da174960679f parent 04bd21d483c33c5011e31ac12d02c9e00dc410ce tdf#106282 Change Windows File Dialog to run on the main thread | https://gerrit.libreoffice.org/c/core/+/114482 c2e223873620c4d44247c835aff279053f574dc6 is the first bad commit commit c2e223873620c4d44247c835aff279053f574dc6 Author: Norbert Thiebaud Date: Thu Apr 22 13:29:23 2021 -0700 source sha:1c1226709c6be39c5462f5e6e1262ca630b30b34 source sha:1c1226709c6be39c5462f5e6e1262ca630b30b34 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146007] FilePicker dialog execute method hangs LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=146007 --- Comment #4 from Felix Koehler --- Another workaround is using the OfficeFilePicker directly in your code or as a preference: Extras/Options -> Libreoffice: Dialogs for Open/Save [x] Use office dialogs This is a blocker for version update for us, as we need the preview from the Windows FilePicker in some automation use cases. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146007] FilePicker dialog execute method hangs LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=146007 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146007] FilePicker dialog execute method hangs LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=146007 Andreas Heinisch changed: What|Removed |Added Keywords||bibisectRequest -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146007] FilePicker dialog execute method hangs LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=146007 --- Comment #3 from Andreas Heinisch --- Remark: If the macro is executed directly in the Basic IDE, the macro never hangs. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146007] FilePicker dialog execute method hangs LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=146007 Andreas Heinisch changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #2 from Andreas Heinisch --- Confirmed in: Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community Build ID: cfbcbb605dbaaea45dc9ac5ea792d72cb2f2c1bb CPU threads: 6; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-US Calc: CL Does not hang in: Version: 7.1.0.3 (x64) / LibreOffice Community Build ID: f6099ecf3d29644b5008cc8f48f42f4a40986e4c CPU threads: 6; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146007] FilePicker dialog execute method hangs LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=146007 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146007] FilePicker dialog execute method hangs LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=146007 --- Comment #1 from Julian Ragan --- Created attachment 176649 --> https://bugs.documentfoundation.org/attachment.cgi?id=176649&action=edit Writer version -- You are receiving this mail because: You are the assignee for the bug.
