[Libreoffice-bugs] [Bug 147576] SLIDESHOW: Shapes get stretched in slideshow
https://bugs.documentfoundation.org/show_bug.cgi?id=147576 Aron Budea changed: What|Removed |Added See Also|https://bugs.documentfounda | |tion.org/show_bug.cgi?id=13 | |2557, | |https://bugs.documentfounda | |tion.org/show_bug.cgi?id=15 | |0402, | |https://bugs.documentfounda | |tion.org/show_bug.cgi?id=15 | |0102| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147576] SLIDESHOW: Shapes get stretched in slideshow
https://bugs.documentfoundation.org/show_bug.cgi?id=147576 Gabor Kelemen (allotropia) changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #15 from Gabor Kelemen (allotropia) --- This is looking good after https://git.libreoffice.org/core/+/1b0ff1c166211b34370f53995ae9fb3f8eed182e%5E%21 author Armin Le Grand (allotropia) Mon Sep 19 11:48:20 2022 +0200 committer Armin Le Grand Mon Sep 19 16:24:46 2022 +0200 tdf#150402 Correct wrong Bound of Shape in Slideshow *** This bug has been marked as a duplicate of bug 150402 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147576] SLIDESHOW: Shapes get stretched in slideshow
https://bugs.documentfoundation.org/show_bug.cgi?id=147576 Aron Budea changed: What|Removed |Added Blocks||103610 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103610 [Bug 103610] [META] Slide show (presentation mode) bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147576] SLIDESHOW: Shapes get stretched in slideshow
https://bugs.documentfoundation.org/show_bug.cgi?id=147576 Mike Kaganski changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||0102 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147576] SLIDESHOW: Shapes get stretched in slideshow
https://bugs.documentfoundation.org/show_bug.cgi?id=147576 Mike Kaganski changed: What|Removed |Added See Also|https://bugs.documentfounda | |tion.org/show_bug.cgi?id=15 | |0840| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147576] SLIDESHOW: Shapes get stretched in slideshow
https://bugs.documentfoundation.org/show_bug.cgi?id=147576 Mike Kaganski changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||0840 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147576] SLIDESHOW: Shapes get stretched in slideshow
https://bugs.documentfoundation.org/show_bug.cgi?id=147576 --- Comment #14 from Gerald Pfeifer --- (In reply to Armin Le Grand from comment #8) > Thus my change is not a regression, but uncovers another error. Bug #150402 was bisected to the same commit and appears quite different from the outside? Maybe that's worth pursuing, Armin? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147576] SLIDESHOW: Shapes get stretched in slideshow
https://bugs.documentfoundation.org/show_bug.cgi?id=147576 Gabor Kelemen (allotropia) changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||0402 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147576] SLIDESHOW: Shapes get stretched in slideshow
https://bugs.documentfoundation.org/show_bug.cgi?id=147576 --- Comment #13 from Timur --- (In reply to Gabor Kelemen (allotropia) from comment #12) > this is not a new issue by any means. I read this aa "not a regression" but it's marked so, please clarify. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147576] SLIDESHOW: Shapes get stretched in slideshow
https://bugs.documentfoundation.org/show_bug.cgi?id=147576 --- Comment #12 from Gabor Kelemen (allotropia) --- (In reply to Armin Le Grand from comment #11) > Created a version without the change in discussion. The context menu > convert/to metafile creates the same error, so the BoundRect is already > wrong in that version. But he Presentation works - have to check why, AFAIK > GraphicExporter::GetGraphic (where the change is) is not used by > Presentation preparations...? I just checked the error with the convert/to metafile case, can confirm that is changing the shapes from square to rectangle shape at least since 3.5.0 - this is not a new issue by any means. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147576] SLIDESHOW: Shapes get stretched in slideshow
https://bugs.documentfoundation.org/show_bug.cgi?id=147576 Gabor Kelemen (allotropia) changed: What|Removed |Added Regression By||Armin Le Grand CC||kelem...@ubuntu.com -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147576] SLIDESHOW: Shapes get stretched in slideshow
https://bugs.documentfoundation.org/show_bug.cgi?id=147576 --- Comment #11 from Armin Le Grand --- Created a version without the change in discussion. The context menu convert/to metafile creates the same error, so the BoundRect is already wrong in that version. But he Presentation works - have to check why, AFAIK GraphicExporter::GetGraphic (where the change is) is not used by Presentation preparations...? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147576] SLIDESHOW: Shapes get stretched in slideshow
https://bugs.documentfoundation.org/show_bug.cgi?id=147576 --- Comment #10 from Armin Le Grand --- There are re-calculations of RecalcBoundRect() after lock is freed. Nonetheless, the correction form comment 8 works for context menu convert/to metafile as correction, so these seem to be initially wrong calculated (?) A slideshow start we can check at DrawShape::DrawShape in slideshow/source/engine/shapes/drawshape.cxx. In member initilaization there is maBounds( getAPIShapeBounds( xShape ) ), which uses GetCurrentBoundRect() over UNO API and there is mpCurrMtf = getMetaFile(uno::Reference(xShape, uno::UNO_QUERY), xContainingPage, mnCurrMtfLoadFlags, mxComponentContext ); below that. The mpCurrMtf PrefSize (created using the corected GraphicExporter::GetGraphic mentioned as regression commit) is correct, while maBounds (from GetCurrentBoundRect()) is not. Trying to make a useful conclusion from this... -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147576] SLIDESHOW: Shapes get stretched in slideshow
https://bugs.documentfoundation.org/show_bug.cgi?id=147576 --- Comment #9 from Armin Le Grand --- There definitely *was* a mechanism to do some cleanups/refreshes after import/load, I checked SdrModel::setLock that does ReformatAllEdgeObjects. Releasing the lock at the SdrModel is used to act at end of import. I am not sure how that was formally done for invalidating the BoundRects of SdrObjects, but it seems definitely no longer to be done. Trying to find how that was done formally (probably some broadcast...) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147576] SLIDESHOW: Shapes get stretched in slideshow
https://bugs.documentfoundation.org/show_bug.cgi?id=147576 --- Comment #8 from Armin Le Grand --- Indeed, adding ::std::vector< SdrObject* > aSdrObjects(GetMarkedObjects()); for(auto* pCand : aSdrObjects) pCand->SetBoundRectDirty(); to SdrExchangeView::GetMarkedObjMetaFile and thus forcing update of he BoundRects corrects that error when 1st converting to Metafile. This is proof that the BoundRects are *wrong* after import. Thus my change is not a regression, but uncovers another error. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147576] SLIDESHOW: Shapes get stretched in slideshow
https://bugs.documentfoundation.org/show_bug.cgi?id=147576 --- Comment #7 from Armin Le Grand --- Looks like SdrExchangeView::GetMarkedObjMetaFile gets that wrong stretched BoundRect from 1st call to GetMarkedObjBoundRect() - very strange. Together with that no longer happening after doing once & UNDO it smells more like BoundRect being wrong after import. Indeed, after having all converted once & then slideshow display is correct. Weren't there some 'optimizations' recently to not broadcast too much after import - to avoid too much recalculations & broadcastings...? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147576] SLIDESHOW: Shapes get stretched in slideshow
https://bugs.documentfoundation.org/show_bug.cgi?id=147576 --- Comment #6 from Armin Le Grand --- Tried to check what ConvertToMetafile does for that objects, but 2nd time converting them does not create that too big metafile again - after undo. Very strange & makes things difficult... -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147576] SLIDESHOW: Shapes get stretched in slideshow
https://bugs.documentfoundation.org/show_bug.cgi?id=147576 --- Comment #5 from Armin Le Grand --- Seems as if something is wrong with the size of the Metafile that gets created in-between. Selecting one of the objects and using convert/to_metafile in the context menu creates a correct metafile, bit it's frame is too big - same too big as the shape is later, stretched vertically. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147576] SLIDESHOW: Shapes get stretched in slideshow
https://bugs.documentfoundation.org/show_bug.cgi?id=147576 Gerald Pfeifer changed: What|Removed |Added CC||ger...@pfeifer.com See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||2557 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147576] SLIDESHOW: Shapes get stretched in slideshow
https://bugs.documentfoundation.org/show_bug.cgi?id=147576 raal changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||r...@post.cz Ever confirmed|0 |1 --- Comment #4 from raal --- Confirm with Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: 0723b41bed9bb4ad50d2993744a60177966d1a21 CPU threads: 4; OS: Linux 5.13; UI render: default; VCL: gtk3 Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US Calc: threaded Jumbo -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147576] SLIDESHOW: Shapes get stretched in slideshow
https://bugs.documentfoundation.org/show_bug.cgi?id=147576 Aron Budea changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||6319 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147576] SLIDESHOW: Shapes get stretched in slideshow
https://bugs.documentfoundation.org/show_bug.cgi?id=147576 Sarper Akdemir changed: What|Removed |Added CC||armin.le.gr...@me.com, ||sarper.akde...@collabora.co ||m Keywords||bibisected, bisected, ||regression --- Comment #3 from Sarper Akdemir --- Regression introduced by: https://cgit.freedesktop.org/libreoffice/core/commit/?id=4d535c4f867d86d40786788e5e5c9fd061a65673 author Armin Le Grand (Allotropia) 2022-01-31 19:44:19 +0100 committer Armin Le Grand 2022-02-02 09:43:10 +0100 commit 4d535c4f867d86d40786788e5e5c9fd061a65673 (patch) tree9611377bf20a0d9ac46ffc1101f769ae0e1f7ac3 parent 60a1f07049a817d4d3d7beb6c9b9da2571e2463b (diff) tdf#126319 Corrected bitmap creation from metafile Bisected with: bibisect-linux64-7.4 Adding cc: to Armin Le Grand -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147576] SLIDESHOW: Shapes get stretched in slideshow
https://bugs.documentfoundation.org/show_bug.cgi?id=147576 --- Comment #2 from Sarper Akdemir --- Created attachment 178436 --> https://bugs.documentfoundation.org/attachment.cgi?id=178436=edit After regression LO slideshow -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147576] SLIDESHOW: Shapes get stretched in slideshow
https://bugs.documentfoundation.org/show_bug.cgi?id=147576 --- Comment #1 from Sarper Akdemir --- Created attachment 178435 --> https://bugs.documentfoundation.org/attachment.cgi?id=178435=edit Before regression LO slideshow -- You are receiving this mail because: You are the assignee for the bug.
