[Libreoffice-bugs] [Bug 147614] LibreOffice icons theme autodetect does not respect system theme

2022-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147614

--- Comment #7 from Heiko Tietze  ---
(In reply to Rizal Muttaqin from comment #6)
> But to be honest, current dark detection implementation is broken...

Bug 127138 "Breeze dark system theme should enable Breeze dark icons" is about
this. Works for me (and as commented before, the icons follow the theme _name_
otherwise the desktop default with Plasma5 = Breeze).

Then we have bug 124966 "svg icon theme color scheme support" with the idea to
invert the icon colors (or identify the color to invert) so a theme works on
both bright and dark themes.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147614] LibreOffice icons theme autodetect does not respect system theme

2022-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147614

--- Comment #6 from Rizal Muttaqin  ---

(In reply to Heiko Tietze from comment #5)
> We don't check whether the system theme is dark. And even in this case we
> only have Breeze and Sifr in dark variants.
> 
> Rizal, what's your take on this?

I support the idea of system wide dark detection, but currently there are many
hindrances here since LibreOffice is a multiplatform/multi-OS application. How
LibreOffice with its VCL library could integrate with
Windows/macOS/Linux/FreeDesktop system wide dark mode? If the solution has been
already there so we can talk further about supporting icon theme dark/light
variant in many OSes.
That's why some icon themes does not have dark variant.

But to be honest, current dark detection implementation is broken (or at least
in my setup). The icon theme does not change automatically when I choose dark
theme in my KDE desktop with Breeze, the icon then did not change to Breeze
dark, even after restarting the application. Even under Safe Mode. User expect
seamless experience.

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: c993d9e7538ffad8b31b26774d7062ee85572e48
CPU threads: 8; OS: Linux 5.13; UI render: default; VCL: kf5 (cairo+xcb)
Locale: id-ID (id_ID.UTF-8); UI: id-ID
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147614] LibreOffice icons theme autodetect does not respect system theme

2022-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147614

--- Comment #5 from Heiko Tietze  ---
We don't check whether the system theme is dark. And even in this case we only
have Breeze and Sifr in dark variants.

Rizal, what's your take on this?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147614] LibreOffice icons theme autodetect does not respect system theme

2022-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147614

--- Comment #4 from Martin  ---
In that case, if the system theme is dark, and the icon theme is
unsupported(Papirus), shouldn't LO default to a dark icon theme?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147614] LibreOffice icons theme autodetect does not respect system theme

2022-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147614

--- Comment #3 from Heiko Tietze  ---
True, "Breeze dark" is chosen as matching to the icon not the desktop theme. If
you rename it to Papirus is would be the default in your case. 

In other words: if an installed LibreOffice icon theme name matches the system
icon theme this will be used. Otherwise the desktop theme decides about the
default.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147614] LibreOffice icons theme autodetect does not respect system theme

2022-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147614

--- Comment #2 from Martin  ---
Created attachment 178500
  --> https://bugs.documentfoundation.org/attachment.cgi?id=178500&action=edit
breeze (dark)

I do not think that is the case, the icons are there and work fine, even when
Papirus is selected by the system, the autodetect just does not work.

Here is a screenshot of Breeze (dark) when manually selected.

Icons work fine, it's just the autodetect that is broken.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147614] LibreOffice icons theme autodetect does not respect system theme

2022-02-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147614

Heiko Tietze  changed:

   What|Removed |Added

URL||https://store.kde.org/p/116
   ||6289/
 Resolution|--- |NOTABUG
 Blocks||106228
 Status|UNCONFIRMED |RESOLVED
 CC||riz...@libreoffice.org

--- Comment #1 from Heiko Tietze  ---
We do follow the system theme (and operating system) for the automatic icon
theme selection. On Windows it is "Colibre", for Plasma5 (KDE) and LXQt
"Breeze", Gnome, Mate, Unity use "Elementary", and macOS "Sukapura". We also
correctly detect whether Breeze (light) or Breeze dark is configured and pick
the default icon theme accordingly.

However, the LibreOffice icon themes define some thousands of additional icons
that are not part of the system's icon theme. All icons are hand-crafted by
volunteers to match the system theme as best as possible but are not officially
part of it. And we just do not have Papirus available.

=> NAB

By the way, some icon themes are not shipped by default but can be installed
per extension, for example Yaru matches well Ubuntu. Take a look at
https://extensions.libreoffice.org/?Tags%5B%5D=109. 

And of course you are very welcome to create and share a Papirus theme for
LibreOffice.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=106228
[Bug 106228] [META] Icon theme issues
-- 
You are receiving this mail because:
You are the assignee for the bug.