[Libreoffice-bugs] [Bug 148810] EDITING: Undo doesn't restore the bullet ( PPTX/PPT )
https://bugs.documentfoundation.org/show_bug.cgi?id=148810 Justin L changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |jl...@mail.com |desktop.org | Status|NEW |ASSIGNED --- Comment #12 from Justin L --- The issue does not at all seem to be with numbering visibility: EE_PARA_BULLETSTATE[4017], aka NumberingIsNumber which has a SfxItemKind::StaticDefault of true (and so the numbering is hidden only if there is a property specifically hiding it.) The issue is always the mismatch of Para.GetDepth() and EE_PARA_OUTLLEVEL. Functions are setting Para Depth without providing a corresponding paragraph property. When the depth is -1 (the default), then no bullet is displayed. (In reply to Justin L from comment #10) > I figured that explicitly setting OUTLLEVEL when importing a NUMBULLET would > work Well, I was correct except that when I thought I was setting the property, the helper function only set the depth. So the PPTX fix is to change the helper to also fall back to the normal method of setting a property. This involved using the REAL EE_PARA_OUTLLEVEL instead of the fake WID_NUMLEVEL. http://gerrit.libreoffice.org/c/core/+/137569 For PPT, it is more easily done. http://gerrit.libreoffice.org/c/core/+/137543 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148810] EDITING: Undo doesn't restore the bullet ( PPTX/PPT )
https://bugs.documentfoundation.org/show_bug.cgi?id=148810 --- Comment #11 from Justin L --- Oh great. It appears the reason "zero" doesn't work is because the depth is already zero - so it doesn't create a RES_PARA_OUTLLEVEL. I think the reason it loses the property is because WID_NUMLEVEL (PROP_NumberingLevel) is not considered a bParaAttrib because it is less than EE_PARA_START, and thus is easily thrown out. This stuff is ridiculously complex. I can "fix" it by forcing a full setDepth in Outliner::SetDepth() -if ( nNewDepth == pPara->GetDepth() ) - return; -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148810] EDITING: Undo doesn't restore the bullet ( PPTX/PPT )
https://bugs.documentfoundation.org/show_bug.cgi?id=148810 --- Comment #10 from Justin L --- Based on my debugging, I figured that explicitly setting OUTLLEVEL when importing a NUMBULLET would work (oox/source/drawingml/textparagraphproperties.cxx). I was a bit surprised that it didn't work with a zero. However, it DOES work with a higher number. Zero should not be special. Either a void or a -1 is "special". -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148810] EDITING: Undo doesn't restore the bullet ( PPTX/PPT )
https://bugs.documentfoundation.org/show_bug.cgi?id=148810 --- Comment #9 from Justin L --- I noticed that "when it worked" it required TWO undo steps to get the bullet back, while only one undo is possible now. In debugging this, I see that ODP deletes two paragraph attributes (EE_PARA_OUTLLEVEL and EE_PARA_BULLETSTATE) while PPT deletes 8 attributes (including EE_PARA_NUMBULLET and EE_PARA_BULLETSTATE) Problem likely caused by commit 88c1c1fa45b6d25694ac805be5258ee7190d6dd6 Author: Rüdiger Timm on Fri Jun 6 11:29:34 2008 + where in editeng/source/editeng/editeng.cxx on a KEY_BACKSPACE we "hide" the BULLETSTATE before starting an undo. But it also is related to Outliner::ParaAttribsChanged. For some reason the level (despite being at para depth of 0) is never specified as an OUTLLEVEL property and thus is lost in this Outliner reset. And there is also an undo-related OutlinerUndoChangeDepth - so depth really has some funkiness to it... -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148810] EDITING: Undo doesn't restore the bullet ( PPTX/PPT )
https://bugs.documentfoundation.org/show_bug.cgi?id=148810 Justin L changed: What|Removed |Added Keywords|regression | Summary|EDITING: Undo doesn't |EDITING: Undo doesn't |restore the bullet ( PPTX ) |restore the bullet ( ||PPTX/PPT ) Version|6.1 all versions|Inherited From OOo --- Comment #8 from Justin L --- The same problem occurs with PPT - already in LO 3.5 so assuming OOo inherited. -- You are receiving this mail because: You are the assignee for the bug.
