[Libreoffice-bugs] [Bug 150286] Wrong justification of Persian/Arabic text

2023-05-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150286

Hossein  changed:

   What|Removed |Added

 Blocks||43808


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=43808
[Bug 43808] [META] Right-To-Left and Complex Text Layout language issues
(RTL/CTL)
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150286] Wrong justification of Persian/Arabic text

2022-09-03 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150286

--- Comment #14 from Hossein  ---
(In reply to خالد حسني from comment #13)
> (In reply to Hossein from comment #12)
> > Created attachment 182191 [details]
> > Correct output after forcing re-layout of the text
> > 
> > I just set the Persian language for the whole text, and then created the
> > output. Please note that setting the language seems to be unrelated to the
> > bug itself, because you can use any other means of forcing LibreOffice
> > re-layout the text to achieve the correct output.
> 
> Did you try to re-open the file, for me re-opening the file shows the issue
> again.

Yes, this is true. The changes are temporary. I think we need to dump and
compare the data structures for one of the paragraphs. I wish this could be
possible using the UNO object inspector tool, but it is not (bug 142373)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150286] Wrong justification of Persian/Arabic text

2022-09-03 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150286

--- Comment #13 from خالد حسني  ---
(In reply to Hossein from comment #12)
> Created attachment 182191 [details]
> Correct output after forcing re-layout of the text
> 
> I just set the Persian language for the whole text, and then created the
> output. Please note that setting the language seems to be unrelated to the
> bug itself, because you can use any other means of forcing LibreOffice
> re-layout the text to achieve the correct output.

Did you try to re-open the file, for me re-opening the file shows the issue
again.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150286] Wrong justification of Persian/Arabic text

2022-09-03 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150286

--- Comment #12 from Hossein  ---
Created attachment 182191
  --> https://bugs.documentfoundation.org/attachment.cgi?id=182191&action=edit
Correct output after forcing re-layout of the text

I just set the Persian language for the whole text, and then created the
output. Please note that setting the language seems to be unrelated to the bug
itself, because you can use any other means of forcing LibreOffice re-layout
the text to achieve the correct output.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150286] Wrong justification of Persian/Arabic text

2022-09-03 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150286

--- Comment #11 from Hossein  ---
(In reply to خالد حسني from comment #10)
> I spent some time debugging this, but went no where. I have no idea what is
> going on here or even where to start.
We can call this a glitch, because upon requesting re-layout of the text (or
even the paragraph), the problem goes away.

For example, set Persian language for all text, change the numeral style, or
use any other means to force LibreOffice re-layout the text. Then, the problem
goes away, even in the output. But after save and reload, the problem is still
there.

Something is creating invalid data in the text data structures. But, how can we
dump that data, and compare it to the situation where the problem is fixed
temporarily? Even pressing ctrl+l, and then ctrl+j causes the paragraph to be
displayed correctly.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150286] Wrong justification of Persian/Arabic text

2022-09-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150286

Michael Warner  changed:

   What|Removed |Added

 Blocks||150285


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=150285
[Bug 150285] [META] Problems with Justified Arabic/Persian text
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150286] Wrong justification of Persian/Arabic text

2022-09-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150286

--- Comment #10 from خالد حسني  ---
I spent some time debugging this, but went no where. I have no idea what is
going on here or even where to start.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150286] Wrong justification of Persian/Arabic text

2022-09-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150286

خالد حسني  changed:

   What|Removed |Added

 Blocks|150285  |

--- Comment #9 from خالد حسني  ---
This happens with no justification at all.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=150285
[Bug 150285] [META] Problems with Justified Arabic/Persian text
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150286] Wrong justification of Persian/Arabic text

2022-09-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150286

خالد حسني  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150286] Wrong justification of Persian/Arabic text

2022-08-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150286

--- Comment #8 from Hossein  ---
Created attachment 182120
  --> https://bugs.documentfoundation.org/attachment.cgi?id=182120&action=edit
PDF Output after removing all footnotes

As visible in the output, right after removing all the footnotes, the text goes
out of the margin.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150286] Wrong justification of Persian/Arabic text

2022-08-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150286

--- Comment #7 from Hossein  ---
(In reply to خالد حسني from comment #5)
> I’m skeptical that the mentioned commit is the source of this. The
> formatting seems to be unstable, changing the font fixes the issue, but it
> shows up again after closing and opening the file.
> 
> It seems to be related to the tab stops and/or the footnote numbers, which
> is higher level that the code this commit touches.
You're right. As the other problem with justified Arabic text (bug 146713), It
was off by one, and the responsible commit was setting HarfBuzz as the default
for the text rendering engine.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150286] Wrong justification of Persian/Arabic text

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150286

--- Comment #6 from Khaled Hosny  ---
This seems to be similar to (if not a duplicate of) bug 138199.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150286] Wrong justification of Persian/Arabic text

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150286

--- Comment #5 from Khaled Hosny  ---
I’m skeptical that the mentioned commit is the source of this. The formatting
seems to be unstable, changing the font fixes the issue, but it shows up again
after closing and opening the file.

It seems to be related to the tab stops and/or the footnote numbers, which is
higher level that the code this commit touches.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150286] Wrong justification of Persian/Arabic text

2022-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150286

Hossein  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||6713

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150286] Wrong justification of Persian/Arabic text

2022-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150286

Hossein  changed:

   What|Removed |Added

  Regression By||dr.khaled.ho...@gmail.com
 Blocks||150285
   Keywords||bibisected, bisected,
   ||regression


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=150285
[Bug 150285] (Justified-Arabic-Text-Kashida) - [META] Problems with Justified
Arabic/Persian text
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150286] Wrong justification of Persian/Arabic text

2022-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150286

--- Comment #4 from Hossein  ---
This is a regression, bibisected to:

commit f0393d7ff69011a16b100541ef18e5090544e4a1
Author: Khaled Hosny 
Date:   Mon May 6 16:54:53 2013 +0200

[harfbuzz] Fix text width calculation, 3rd try

It turns out storing the width in the layout is not so good idea,
because in some mysterious cases when font fallback is involved we call
GetTextWidth() without calling LayoutText() first, and we return the
width of the previous text run.

It seems all I needed is to pass down the X offset with the glyph item,
and take it into account when calculating the width.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150286] Wrong justification of Persian/Arabic text

2022-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150286

--- Comment #3 from Hossein  ---
Created attachment 181642
  --> https://bugs.documentfoundation.org/attachment.cgi?id=181642&action=edit
Vazirmatn font

The latest version of "Vazirmatn" font, which is currently 33.003, can be
downloaded from:

https://github.com/rastikerdar/vazirmatn/releases

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150286] Wrong justification of Persian/Arabic text

2022-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150286

--- Comment #2 from Hossein  ---
Created attachment 181641
  --> https://bugs.documentfoundation.org/attachment.cgi?id=181641&action=edit
Incorrect justified text with LO 7.5 dev master

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150286] Wrong justification of Persian/Arabic text

2022-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150286

--- Comment #1 from Hossein  ---
Created attachment 181640
  --> https://bugs.documentfoundation.org/attachment.cgi?id=181640&action=edit
Correct justified text with LO 4.4

-- 
You are receiving this mail because:
You are the assignee for the bug.