[Libreoffice-bugs] [Bug 150647] Autofilter result is wrong when filtering (empty) records

2022-09-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150647

Xisco Faulí  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |l.lu...@collabora.com
   |desktop.org |
 Status|RESOLVED|VERIFIED

--- Comment #13 from Xisco Faulí  ---
Thanks Lubos for fixing this issue!!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150647] Autofilter result is wrong when filtering (empty) records

2022-09-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150647

Xisco Faulí  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #12 from Xisco Faulí  ---
Verified in

Version: 7.4.3.0.0+ / LibreOffice Community
Build ID: 403ff3d3ccba1498568e82e4840a12e53a188406
CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: es-ES (es_ES.UTF-8); UI: en-US
Calc: threaded

I guess we can close it as VERIFIED FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150647] Autofilter result is wrong when filtering (empty) records

2022-09-26 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150647

--- Comment #11 from Commit Notification 
 ---
Luboš Luňák committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/66ebf61975a5d8d860eda5e661c5a82a9ca763b7

make sure SharedString::EMPTY_STRING is interned in pools (tdf#150647)

It will be available in 7.3.7.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150647] Autofilter result is wrong when filtering (empty) records

2022-09-26 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150647

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:7.5.0 target:7.4.3   |target:7.5.0 target:7.4.3
   ||target:7.3.7

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150647] Autofilter result is wrong when filtering (empty) records

2022-09-26 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150647

--- Comment #10 from Commit Notification 
 ---
Luboš Luňák committed a patch related to this issue.
It has been pushed to "libreoffice-7-4":

https://git.libreoffice.org/core/commit/15d1660ef04492bfffe4fd30d7c1942499d44f0c

make sure SharedString::EMPTY_STRING is interned in pools (tdf#150647)

It will be available in 7.4.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150647] Autofilter result is wrong when filtering (empty) records

2022-09-26 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150647

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:7.5.0|target:7.5.0 target:7.4.3

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150647] Autofilter result is wrong when filtering (empty) records

2022-09-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150647

Kevin Suo  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||1152

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150647] Autofilter result is wrong when filtering (empty) records

2022-09-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150647

--- Comment #9 from Commit Notification 
 ---
Luboš Luňák committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/e47e0cb0ad1dc3554e9b57f8562a217cf785edbf

make sure SharedString::EMPTY_STRING is interned in pools (tdf#150647)

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150647] Autofilter result is wrong when filtering (empty) records

2022-09-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150647

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.5.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150647] Autofilter result is wrong when filtering (empty) records

2022-09-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150647

Xisco Faulí  changed:

   What|Removed |Added

   Severity|normal  |major
   Priority|medium  |high

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150647] Autofilter result is wrong when filtering (empty) records

2022-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150647

Kevin Suo  changed:

   What|Removed |Added

Version|7.4.0.3 release |7.3.0.0 beta1+

--- Comment #8 from Kevin Suo  ---
Adjusting the version field to 7.3 accordingly as this also affects 7.3 branch.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150647] Autofilter result is wrong when filtering (empty) records

2022-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150647

Xisco Faulí  changed:

   What|Removed |Added

   Keywords||bisected
 CC||l.lu...@collabora.com

--- Comment #7 from Xisco Faulí  ---
Regression introduced by 

author  Luboš Luňák  2021-11-23 21:15:23 +0100
committer   Luboš Luňák  2021-11-23 22:41:28
+0100
commit  990d32dad6bdf5d92a14d8bc02ae2853facd9097 (patch)
treeb049c19cf6664ba7960c8ed522031a577353d8b6
parent  758ff97066652fbdd960121d42e659d3ab90e7d4 (diff)
allow matching of empty cells as svl::SharedString (tdf#133804)
This may speed up some lookups.

when 938c899831bd5b165b2b7db3945867a1ce155483 is not in place

@Luboš, I'm wondering whether we should just revert that patch now ?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150647] Autofilter result is wrong when filtering (empty) records

2022-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150647

--- Comment #6 from Xisco Faulí  ---
an update on this, I'm bisecting it manually building LibreOffice on every step
reverting 938c899831bd5b165b2b7db3945867a1ce155483 and the commit introduced
the issue is in this range:
https://cgit.freedesktop.org/libreoffice/core/log/?qt=range=899e8f813c559384ba11eb1d4ceafaf29b5e73a9..3d09becf194bf1702a389ee59a7d6df899a570dd.
6 steps to go...

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150647] Autofilter result is wrong when filtering (empty) records

2022-09-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150647

Xisco Faulí  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||0452

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150647] Autofilter result is wrong when filtering (empty) records

2022-09-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150647

--- Comment #5 from Xisco Faulí  ---
I moved my branch to libreoffice-7-3, specifically to commit
20f35b9e185d501398619a615a3ebbb44db1b2a5, applied the revert and retested. The
issue is already reproducible there

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150647] Autofilter result is wrong when filtering (empty) records

2022-09-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150647

--- Comment #4 from Xisco Faulí  ---
Also reproduced in

Version: 7.3.7.0.0+ / LibreOffice Community
Build ID: d0312786571221c2dd4f63fa69f6f0489d7d39ec
CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: es-ES (es_ES.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150647] Autofilter result is wrong when filtering (empty) records

2022-09-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150647

--- Comment #3 from Xisco Faulí  ---
Hi Kevin,
Thanks for the bisection.
This is a bit weird since my commit just revert a patch.
I expected the regression to be reproducible before
3749d9af3745c0eaff7239e379578e4e2af89e9d ( the commit I reverted ? but it's not
the case. Investigating

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150647] Autofilter result is wrong when filtering (empty) records

2022-08-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150647

stragu  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW
 Blocks||103512
 CC||stephane.guil...@member.fsf
   ||.org

--- Comment #2 from stragu  ---
Reproduced with:

Version: 7.5.0.0.alpha0+ / LibreOffice Community
Build ID: 24087697d5cf78aac346d4dcea0596373e15a95c
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103512
[Bug 103512] [META] AutoFilter-related bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150647] Autofilter result is wrong when filtering (empty) records

2022-08-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150647

Kevin Suo  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org
   Keywords||bibisected, regression

--- Comment #1 from Kevin Suo  ---
Bibisected to the following range which covers 3 commits:
7d730cd58..938c89983

in which the following seems related:

commit 938c899831bd5b165b2b7db3945867a1ce155483
Author: Xisco Fauli 
Date:   Wed Aug 17 12:59:51 2022 +0200

tdf#150452: Revert "tdf#130795 use concurrent hashmap in SharedStringPool"

Adding cc to Xisco Fauli: any idea? I don't think we should do a "revert
revert".

-- 
You are receiving this mail because:
You are the assignee for the bug.