[Libreoffice-bugs] [Bug 151544] “Lines per page" in Grid Mode is not accurately applied (always 1 line less than set in page style dalog)
https://bugs.documentfoundation.org/show_bug.cgi?id=151544 Kevin Suo changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |suokunl...@126.com |desktop.org | Status|NEW |ASSIGNED --- Comment #8 from Kevin Suo --- I think I get it. The tine space above each line is the "ruby" which should only be there when in squared page mode. The code seems to be trying to set the ruby height to zero in line https://opengrok.libreoffice.org/xref/core/sw/source/ui/misc/pggrid.cxx?r=384167ab#388 but there seems to be a conversion loss, thus each line finally contains a tiny ruby height, which makes the page not able to hold the number of lines set on the UI. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151544] “Lines per page" in Grid Mode is not accurately applied (always 1 line less than set in page style dalog)
https://bugs.documentfoundation.org/show_bug.cgi?id=151544 Kevin Suo changed: What|Removed |Added Attachment #183369|screenshot showing spaces |screenshotShowingSpacesBtwL filename|btw lines.pdf |ines.pdf -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151544] “Lines per page" in Grid Mode is not accurately applied (always 1 line less than set in page style dalog)
https://bugs.documentfoundation.org/show_bug.cgi?id=151544 --- Comment #7 from Kevin Suo --- Created attachment 183369 --> https://bugs.documentfoundation.org/attachment.cgi?id=183369=edit screenshot showing spaces btw lines.pdf -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151544] “Lines per page" in Grid Mode is not accurately applied (always 1 line less than set in page style dalog)
https://bugs.documentfoundation.org/show_bug.cgi?id=151544 --- Comment #6 from Kevin Suo --- https://opengrok.libreoffice.org/xref/core/sw/source/ui/misc/pggrid.cxx?r=384167ab#294 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151544] “Lines per page" in Grid Mode is not accurately applied (always 1 line less than set in page style dalog)
https://bugs.documentfoundation.org/show_bug.cgi?id=151544 --- Comment #5 from Kevin Suo --- I did some debugging. In function SwTextGridPage::UpdatePageSize(const SfxItemSet& rSet), currently when calculating the page height (net of the header, footer, top space, bottom space etc) (strictly speaking it is the height of the text area, should not be named "page size"), it used the following code: sal_Int32 nValue1 = rSize.GetSize().Height() - nDistanceUL - rBox.GetDistance(SvxBoxItemLine::TOP) - rBox.GetDistance(SvxBoxItemLine::BOTTOM); When I change this to: sal_Int32 nValue1 = rSize.GetSize().Height() - nDistanceUL - rBox.GetDistance(SvxBoxItemLine::TOP) - rBox.GetDistance(SvxBoxItemLine::BOTTOM) - 425; (i.e. deducting the calculated text area height by 425 twips), then if I set the page grid to 22 lines then there would be 22 lines perfectly shown on the page. As a result, I guess the problem may be that when calculating the text area height it did not take into account the spaces between the lines, as when you enlarge the page you will see that there are spaces between each lines. The exact additional spaces to be deducted should be the height of each space multiplied by the lines to be displayed on the page. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151544] “Lines per page" in Grid Mode is not accurately applied (always 1 line less than set in page style dalog)
https://bugs.documentfoundation.org/show_bug.cgi?id=151544 Kevin Suo changed: What|Removed |Added Version|7.3.6.2 release |Inherited From OOo --- Comment #4 from Kevin Suo --- Also reproducible in the "oldest" version of the "releases" bibisect repo, thus this is inherited from OOo. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151544] “Lines per page" in Grid Mode is not accurately applied (always 1 line less than set in page style dalog)
https://bugs.documentfoundation.org/show_bug.cgi?id=151544 Kevin Suo changed: What|Removed |Added CC||mark...@gmail.com --- Comment #3 from Kevin Suo --- I could not reproduce the crash, although there seems to be a hang. Adding Mark Hung to cc as he had worked on bug 141957. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151544] “Lines per page" in Grid Mode is not accurately applied (always 1 line less than set in page style dalog)
https://bugs.documentfoundation.org/show_bug.cgi?id=151544 --- Comment #2 from Kevin Suo --- Seems like an off-by-one error. Since there is a crash when lines on the page is set to 1, need a backtrace to locate the code pointer. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151544] “Lines per page" in Grid Mode is not accurately applied (always 1 line less than set in page style dalog)
https://bugs.documentfoundation.org/show_bug.cgi?id=151544 Dieter changed: What|Removed |Added Status|UNCONFIRMED |NEW Whiteboard| QA:needsComment| Ever confirmed|0 |1 CC||dgp-m...@gmx.de Summary|“Lines per page" in Grid|“Lines per page" in Grid |Mode is not accurately |Mode is not accurately |applied (there are 21 lines |applied (always 1 line less |if I set it to be 22 lines) |than set in page style ||dalog) --- Comment #1 from Dieter --- I confirm it with Version: 7.4.2.2 (x64) / LibreOffice Community Build ID: 1726efbecd001a1fe871cba3e00e71283688f34d CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL Steps 1. Make sure, that "Asian" is set in Tools -> options -> Language Settings -> Languages 2. Open attachment 183063 3. Count lines per page (are 21; should be 22) 4. Change lines per page in grid tap of page style dialog and recount Actual result There is always one line missing on a page. If you choose one line per page, LO freezes Expected result Number of lines per page, should be the same as set in the Page Style settings. -- You are receiving this mail because: You are the assignee for the bug.
