[Libreoffice-bugs] [Bug 152724] FILESAVE FORMATTING Cell custom Format Code with _- (UI visible space width) is not saved correctly

2023-02-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152724

Laurent Balland  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |jumbo4...@yahoo.fr
   |desktop.org |
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152724] FILESAVE FORMATTING Cell custom Format Code with _- (UI visible space width) is not saved correctly

2023-02-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152724

--- Comment #14 from Laurent Balland  ---
(In reply to ady from comment #13)
> I'd like to emphasize that combining "?0" was not working in 7.4.4.2 for
> ods. I understand that you worked on the "?" part for 7.6; my point is that
> saying "0 was already treated" might be confusing to users, since the
> combination of "0" with some of the other codes was not working.
As ? was not working, any combination with ? was not working. Combining # and 0
was working fine.

> Would you please be so kind and mention here some example of "unreasonable"
> combination of "#, ? and 0"? Not only it would help for testing (now and in
> future versions), but especially to be aware and to be able to provide such
> information to other users.
Sorry I went too fast. 
The format code of integer part must be in the following order:
- zero or any number of "#"
- zero or any number of "?"
- zero or any number of "0"
For the decimal part, it is the opposite order. For instance, these formats are
correct:
##??00.00??##
?0.#
But if you mix order of coding characters, format will be non sense. These
formats cannot be saved in ODF (even if you can save them in XLSX) because they
are not coherent:
00?#?.#0?0
?#0.?0

> > _x still needs an ODF extension. I accordingly modified the summary.
> 
> Would this RFE be assigned to someone for that?
There may be someone who could assigned it to him/herself, but nobody will
assigned to someone else. It's a voluntary project.
As far as I am concerned, I could have a look in few weeks, if nobody takes
care of it.

> Please note the double zeros in the last one. Whether this could generate
> problems with users sharing files between different versions of LO, IDK.
> Whether this can be avoided, IDK either.
Replacing ? with 0 is the best choice for versions unable to interpret ? in
integer part: a place is reserved for the digit.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152724] FILESAVE FORMATTING Cell custom Format Code with _- (UI visible space width) is not saved correctly

2023-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152724

--- Comment #13 from ady  ---
(In reply to Laurent Balland from comment #12)
> ? is now fixed in master (see bug 118324)

TY.

> 0 was already treated

I'd like to emphasize that combining "?0" was not working in 7.4.4.2 for ods. I
understand that you worked on the "?" part for 7.6; my point is that saying "0
was already treated" might be confusing to users, since the combination of "0"
with some of the other codes was not working.


> 0 was already treated, and any "reasonable" format combining #, ? and 0
> should be preserved in ODF in integer and decimal part.

Would you please be so kind and mention here some example of "unreasonable"
combination of "#, ? and 0"? Not only it would help for testing (now and in
future versions), but especially to be aware and to be able to provide such
information to other users.


> _x still needs an ODF extension. I accordingly modified the summary.

Would this RFE be assigned to someone for that?


I compared the following 2 versions with an .ods file:

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: d8e6b488ceaff7c88856ebcfcfec14d2d8cd7652
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: en-US (es_AR); UI: en-US
Calc: CL threaded


Version: 7.4.4.2 (x64) / LibreOffice Community
Build ID: 85569322deea74ec9134968a29af2df5663baa21
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: default; VCL: win
Locale: en-US (es_AR); UI: en-US
Calc: CL


Steps and Results (in the same order as described here):


With 7.4.4.2:

Saved as:
_-?0;-?0;_-?0;@

Opened as:
[>0]" "#;[<0]-#;" "#;@

Then with 7.6.0.0.alpha0+...

Saved as:
_-?0;-?0;_-?0;@

Opened as:
[>0]" "?0;[<0]-?0;" "?0;@

Then closed without saving, and opened it in 7.4.4.2:
[>0]" "00;[<0]-00;" "00;@


Please note the double zeros in the last one. Whether this could generate
problems with users sharing files between different versions of LO, IDK.
Whether this can be avoided, IDK either.

(On a side note, the ods file seemed to be opened slightly slower in the
aforementioned 7.6.0.0.alpha0+ than in 7.4.4.2.)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152724] FILESAVE FORMATTING Cell custom Format Code with _- (UI visible space width) is not saved correctly

2023-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152724

Laurent Balland  changed:

   What|Removed |Added

Summary|FILESAVE FORMATTING Cell|FILESAVE FORMATTING Cell
   |custom Format Code with _-  |custom Format Code with _-
   |(UI visible space width)|(UI visible space width) is
   |and ? (optional digit space |not saved correctly
   |placeholder) is not saved   |
   |correctly   |

--- Comment #12 from Laurent Balland  ---
(In reply to ady from comment #11)
> There are at least 3 codes (and their combinations) that are not saved
> correctly in ods. Currently, the custom Format Codes are being saved as
> follows:
> 
> ?  -> #
> 0  -> #
> _- -> " "
> 
> 
> See comment #8 for sum-up.

? is now fixed in master (see bug 118324)
0 was already treated, and any "reasonable" format combining #, ? and 0 should
be preserved in ODF in integer and decimal part.

_x still needs an ODF extension. I accordingly modified the summary.

-- 
You are receiving this mail because:
You are the assignee for the bug.