[Libreoffice-bugs] [Bug 155007] FILESAVE XLS Excessive number of rows or columns warning when saving after selecting all

2023-04-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155007

ady  changed:

   What|Removed |Added

   Keywords||bibisected,
   ||implementationError

--- Comment #7 from ady  ---
To sum up...

Each of the possible messages (depending on the specific "selected area") are:

"
The document contains more columns than supported in the selected format.
Additional columns were not saved.
"
"
The document contains more rows than supported in the selected format.
Additional rows were not saved.
"

The messages themselves are not the real problem.

The problem is that the "selected" area should not really be part of the active
area – or however the actually-relevant area is supposed to be named – to be
(checked for limits in XLS format and) saved.

I guess the problem is in:

sc/source/filter/excel/xehelper.cxx

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155007] FILESAVE XLS Excessive number of rows or columns warning when saving after selecting all

2023-04-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155007

--- Comment #6 from Buovjaga  ---
(In reply to ady from comment #5)
> > fdo#40694 - Error in message when truncating col/row numbers in calc
> > 
> > It looks like while older version (3.5.x) gives a wrong warning
> > The newer version doesn't give any warnings.
> > With this it gives the warning with correct message.
> 
> In LO 4.2, there was no warning when some data would had been lost while
> saving as XLS (i.e. beyond cell IV65536).
> 
> In LO 4.3, the warning indeed exists.
> 
> The problem is that, even with no relevant/real dependency beyond cell
> IV65536, by just selecting (for instance) an entire row/column while saving
> as XLS, the warning is shown even if there is no real data loss. In such
> cases, the warning is misleading.
> 
> Is the "selected area(s)" even really "saved" somewhere in the XLS file?
> 
> If there is no real data loss, the warning should not be shown.

Maybe I should have added that that was me quoting the commit message.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155007] FILESAVE XLS Excessive number of rows or columns warning when saving after selecting all

2023-04-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155007

--- Comment #5 from ady  ---
> fdo#40694 - Error in message when truncating col/row numbers in calc
> 
> It looks like while older version (3.5.x) gives a wrong warning
> The newer version doesn't give any warnings.
> With this it gives the warning with correct message.

In LO 4.2, there was no warning when some data would had been lost while saving
as XLS (i.e. beyond cell IV65536).

In LO 4.3, the warning indeed exists.

The problem is that, even with no relevant/real dependency beyond cell IV65536,
by just selecting (for instance) an entire row/column while saving as XLS, the
warning is shown even if there is no real data loss. In such cases, the warning
is misleading.

Is the "selected area(s)" even really "saved" somewhere in the XLS file?

If there is no real data loss, the warning should not be shown.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155007] FILESAVE XLS Excessive number of rows or columns warning when saving after selecting all

2023-04-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155007

--- Comment #4 from Buovjaga  ---
That's bug 40694

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155007] FILESAVE XLS Excessive number of rows or columns warning when saving after selecting all

2023-04-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155007

Buovjaga  changed:

   What|Removed |Added

 CC||ilmari.lauhakangas@libreoff
   ||ice.org
Summary|FILESAVE XLS Excessive  |FILESAVE XLS Excessive
   |number of rows or columns   |number of rows or columns
   |warning |warning when saving after
   ||selecting all

--- Comment #3 from Buovjaga  ---
Bibisected the behaviour change with linux-43max to
28e9efe5b4d6699b33498953e798f76008edaeda

fdo#40694 - Error in message when truncating col/row numbers in calc

It looks like while older version (3.5.x) gives a wrong warning
The newer version doesn't give any warnings.
With this it gives the warning with correct message.

-- 
You are receiving this mail because:
You are the assignee for the bug.