[Libreoffice-bugs] [Bug 155736] Fileopen DOCX:Page numbers (from field of course, but inside a nested block SDT) are missing in the footer for a particular file
https://bugs.documentfoundation.org/show_bug.cgi?id=155736 SATYA SRINIVAS K changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |skompe...@opentext.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155736] Fileopen DOCX:Page numbers (from field of course, but inside a nested block SDT) are missing in the footer for a particular file
https://bugs.documentfoundation.org/show_bug.cgi?id=155736 --- Comment #9 from Justin L --- (In reply to Justin L from comment #8) > IIUC, this is a lot of hacky stuff, so it all could be dreadfully wrong. I > believe there was a lot of code changes/research into this area recently See bug 154478 which replaces a similar fix made for bug 154481. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155736] Fileopen DOCX:Page numbers (from field of course, but inside a nested block SDT) are missing in the footer for a particular file
https://bugs.documentfoundation.org/show_bug.cgi?id=155736 --- Comment #8 from Justin L --- (In reply to SATYA SRINIVAS K from comment #7) > Please let me know, if you have a direct answer or guess. IIUC, this is a lot of hacky stuff, so it all could be dreadfully wrong. I believe there was a lot of code changes/research into this area recently, and some of it dealt with exceptions. So, it will take a fair amount of work to try and wrap your mind around what the code is doing here. I suggest adding SAL_WARN statements when TOC starts and stops, when Push/PopPageHeaderFooter, at Push/PopSdt, and when CloseSectionGroup so that you get a feel for the flow of the code. In general, we have a LOT of problems in writerfilter because we don't have a stack. For example, you may be working in a paragraph, and then begin a content control (which also has its own paragraph) which contains a shape (which also has its own paragraph). So now, which of the writerfilter properties can you believe? You can't trust the "this is the first paragraph in the section" or pretty much any other property. Likely the same thing is true for m_bStartTOC. I tried to create stack properties once, but failed because RTF format doesn't track closely enough with DOCX (and they both share the same code). But in this case you can probably say "since I am in a footer, I can ignore any TOC flags because obviously I am not building a TOC right now". You will find lots of IsInHeaderFooter() examples similar to this in writerfilter. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155736] Fileopen DOCX:Page numbers (from field of course, but inside a nested block SDT) are missing in the footer for a particular file
https://bugs.documentfoundation.org/show_bug.cgi?id=155736 --- Comment #7 from SATYA SRINIVAS K --- Justin, It looks like the commit you pointed out is the culprit. Page numbers are displaying as expected if I comment this line m_bStartTOC = true; in DomainMapper_Impl::handleToc method. I still need to track down how this member m_bStartTOC is causing this issue when set to true. Please let me know, if you have a direct answer or guess. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155736] Fileopen DOCX:Page numbers (from field of course, but inside a nested block SDT) are missing in the footer for a particular file
https://bugs.documentfoundation.org/show_bug.cgi?id=155736 Gabor Kelemen (allotropia) changed: What|Removed |Added CC||kelem...@ubuntu.com --- Comment #6 from Gabor Kelemen (allotropia) --- This also seems to do with the footer placement: If I copy the paragraph from the footer and insert it in the document body in Word, then it works in Writer, the initial values are visible and adding a page break increases the second number (of pages). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155736] Fileopen DOCX:Page numbers (from field of course, but inside a nested block SDT) are missing in the footer for a particular file
https://bugs.documentfoundation.org/show_bug.cgi?id=155736 --- Comment #5 from Justin L --- The range of commit was https://cgit.freedesktop.org/libreoffice/core/log/?qt=range=c619f8747bcf04454645774729ccf5d91fac55f1..92518d513fe021be58a0bbeb04fd9306eb23ebda The other bug reports that reference the bad commit might be helpful as well. https://bugs.documentfoundation.org/buglist.cgi?list_id=1610858=9679e9c23216decb5f9f25f85b04cb3f2521_type=allwordssubstr_format=advanced=---=FIXED=INVALID=WONTFIX=DUPLICATE=WORKSFORME=MOVED=NOTABUG=NOTOURBUG=INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155736] Fileopen DOCX:Page numbers (from field of course, but inside a nested block SDT) are missing in the footer for a particular file
https://bugs.documentfoundation.org/show_bug.cgi?id=155736 Justin L changed: What|Removed |Added Keywords||bibisected, bisected, ||filter:docx, regression Version|7.5.3.2 release |4.2.6.2 release Blocks||113363 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=113363 [Bug 113363] [META] DOCX (OOXML) content control-related issues -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155736] Fileopen DOCX:Page numbers (from field of course, but inside a nested block SDT) are missing in the footer for a particular file
https://bugs.documentfoundation.org/show_bug.cgi?id=155736 Justin L changed: What|Removed |Added Summary|Fileopen DOCX:Page numbers |Fileopen DOCX:Page numbers |are missing on the footer |(from field of course, but |for a particular file |inside a nested block SDT) ||are missing in the footer ||for a particular file Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #4 from Justin L --- This is a field inside of a content control (regular SDT with a blockSDT) Nothing was seen in the footer in OOo 3.3. It was working in 4.0, and broke in 4.2.6. Using bibisect-43max, I hit a short range of 5 commits that had to be skipped. Almost certainly due to this commit, since it was backported to 4.2.6: commit 9679e9c23216decb5f9f25f85b04cb3f2521 Author: Vinaya Mandke on Mon Dec 30 16:22:30 2013 +0530 tdf#69649 Fix for pre-rendered Table Of Contents -- You are receiving this mail because: You are the assignee for the bug.
